The ChangeLog file was added in 1.6.0 and contains useful information
for users.
The AUTHORS file was removed from %doc in znc-1.7.0-1, because the file
was no longer present in the upstream tarball. Prior to that, the
AUTHORS file was a symlink to the (unpackaged) NOTICES file from
znc-1.2-0.1.alpha1 through znc-1.6.6.
This is minor, but rpmlint complains about the summaries for the perl
and python modules otherwise.
Use "%{summary}." for the %description of the mod(perl|python|tcl)
packages.
On x86_64 the default search path configure uses for tclConfig.sh
does not include /usr/lib64. The tcl module builds with default
settings, but we can do better by explicitly setting --with-tcl. This
ensures that TCL_FLAGS is set by tclConfig.sh rather than guessed.
Manually maintaining the module list is tedious and error-prone.
Include all files under %{_libdir}/znc by default. Use %exclude to
filter out the modperl, modpython, and modtcl files.
Upstream provides signatures for the source tarballs. Automatically
verify them in %prep. This is one less manual step for maintainers.
The upstream tarballs are signed by Alexey Sokolov, AKA DarthGandalf.
The key was initially taken from Alexey's profile page at
savannah.gnu.org¹. The key was then refreshed from the public
keyservers to pick up changes to the expiration date. Lastly, it was
exported via the following command:
gpg2 --armor --export-options export-minimal --export \
D5823CACB477191CAC0075555AE420CC0209989E > gpgkey-5AE420CC0209989E.asc
¹ https://savannah.gnu.org/users/darthgandalf
While upstream redirects to https these days, avoid sending users to the
non-secure site. As %url is used for Source0 it's preferable to
download source tarballs via a secure channel.
Using %autosetup removes the need to manually define %patchN macros.
Using %make_build and %make_install handles %{?_smp_mflags} and DESTDIR.
Also remove cruft related to the znc systemd service file install, left
after a53b3b8 ("cleanup conditionals, use upstream unit file",
2016-10-07).
The znc.cpp file was moved in znc-1.0 and the pattern used in the perl
replacement changed. No one seems to have missed the addition of the
%%{release} macro which was intended. Drop the command and avoid an rpm
build warning.
Similarly, the q.cpp file mode no longer needs to be fixed.
Using a pattern to match the source tar.gz files prevents fedpkg upload
from needlessly appending each new source file to .gitignore.
Also ignore *.rpm, the results dir from mockbuild, and expanded source
directories.
Fedora Release Engineering
Nick Bebout
Jitka Plesnikova
Jason Tibbitts
Pete Walter
Björn Esser
Nick Bebout
Miro Hrončok
Todd Zullinger
Nick Bebout
Petr Písař
Nick Bebout