From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: Jan200101 Date: Sun, 26 May 2024 15:13:33 +0200 Subject: [PATCH] cmake: correct PIE support detection, add error output for debugging `check_pie_supported` only uses the `OUTPUT_VARIABLE` to to signify errors if PIE is actually supported is signaled by `CMAKE__LINK_PIE_SUPPORTED`. Checking if `OUTPUT_VARIABLE` is empty is not enough either since the check is bypassed if its results are cached but the output variable is not cached. Signed-off-by: Jan200101 --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 06df068919..a1b8aa57a0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -125,8 +125,8 @@ check_pie_supported( OUTPUT_VARIABLE ZIG_PIE_SUPPORTED_BY_CMAKE LANGUAGES C CXX ) -if(ZIG_PIE AND NOT ZIG_PIE_SUPPORTED_BY_CMAKE) - message(SEND_ERROR "ZIG_PIE was requested but CMake does not support it for \"zigcpp\" target") +if(ZIG_PIE AND NOT CMAKE_CXX_LINK_PIE_SUPPORTED) + message(SEND_ERROR "ZIG_PIE was requested but CMake does not support it for \"zigcpp\" target: ${ZIG_PIE_SUPPORTED_BY_CMAKE}") endif()