From 39205cc2da444a73f116c8ac794fe2d47370c059 Mon Sep 17 00:00:00 2001 From: Peter Robinson Date: Tue, 10 Nov 2020 10:25:30 +0000 Subject: [PATCH] Fix Keyboard and USB-A ports on Pinebook Pro Signed-off-by: Peter Robinson --- rk3399-Pinebook-pro-EDP-support.patch | 101 -------------------------- rockchip-Pinebook-Pro-Fix-USB.patch | 39 ++++++++++ uboot-tools.spec | 2 + 3 files changed, 41 insertions(+), 101 deletions(-) create mode 100644 rockchip-Pinebook-Pro-Fix-USB.patch diff --git a/rk3399-Pinebook-pro-EDP-support.patch b/rk3399-Pinebook-pro-EDP-support.patch index ae07e11..3fd30cb 100644 --- a/rk3399-Pinebook-pro-EDP-support.patch +++ b/rk3399-Pinebook-pro-EDP-support.patch @@ -738,107 +738,6 @@ Index: u-boot/arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi + rockchip,panel = <&edp_panel>; +}; -From patchwork Tue Oct 27 13:21:37 2020 -Content-Type: text/plain; charset="utf-8" -MIME-Version: 1.0 -Content-Transfer-Encoding: 7bit -X-Patchwork-Submitter: "Arnaud Patard (Rtp)" -X-Patchwork-Id: 1388578 -X-Patchwork-Delegate: ykai007@gmail.com -Return-Path: -X-Original-To: incoming@patchwork.ozlabs.org -Delivered-To: patchwork-incoming@bilbo.ozlabs.org -Authentication-Results: ozlabs.org; - spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de - (client-ip=85.214.62.61; helo=phobos.denx.de; - envelope-from=u-boot-bounces@lists.denx.de; receiver=) -Authentication-Results: ozlabs.org; - dmarc=fail (p=none dis=none) header.from=rtp-net.org -Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) - (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) - key-exchange X25519 server-signature RSA-PSS (4096 bits)) - (No client certificate requested) - by ozlabs.org (Postfix) with ESMTPS id 4CLC9J4D9wz9sSf - for ; Wed, 28 Oct 2020 00:24:35 +1100 (AEDT) -Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) - by phobos.denx.de (Postfix) with ESMTP id 164CE82494; - Tue, 27 Oct 2020 14:23:56 +0100 (CET) -Authentication-Results: phobos.denx.de; - dmarc=fail (p=none dis=none) header.from=rtp-net.org -Authentication-Results: phobos.denx.de; - spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de -Received: by phobos.denx.de (Postfix, from userid 109) - id 980AA824B8; Tue, 27 Oct 2020 14:23:49 +0100 (CET) -X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de -X-Spam-Level: -X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, - URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 -Received: from lechat.rtp-net.org (lechat.rtp-net.org [51.15.165.164]) - (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) - (No client certificate requested) - by phobos.denx.de (Postfix) with ESMTPS id 1369A82430 - for ; Tue, 27 Oct 2020 14:23:45 +0100 (CET) -Authentication-Results: phobos.denx.de; - dmarc=pass (p=none dis=none) header.from=rtp-net.org -Authentication-Results: phobos.denx.de; - spf=pass smtp.mailfrom=arnaud.patard@rtp-net.org -Received: by lechat.rtp-net.org (Postfix, from userid 1000) - id B8905180904; Tue, 27 Oct 2020 14:23:43 +0100 (CET) -Message-ID: <20201027132235.984153676@rtp-net.org> -User-Agent: quilt/0.66 -Date: Tue, 27 Oct 2020 14:21:37 +0100 -From: Arnaud Patard (Rtp) -To: u-boot@lists.denx.de -Cc: Kever Yang , - Anatolij Gustschin , - Philipp Tomsich , - Peter Robinson , - Samuel Dionne-Riel , - Alper Nebi Yasak , - Arnaud Patard -Subject: [patch v2 06/10] configs/pinebook-pro-rk3399_defconfig: enable - SYS_USB_EVENT_POLL_VIA_INT_QUEUE -References: <20201027132131.016984025@rtp-net.org> -MIME-Version: 1.0 -X-BeenThere: u-boot@lists.denx.de -X-Mailman-Version: 2.1.34 -Precedence: list -List-Id: U-Boot discussion -List-Unsubscribe: , - -List-Archive: -List-Post: -List-Help: -List-Subscribe: , - -Errors-To: u-boot-bounces@lists.denx.de -Sender: "U-Boot" -X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de -X-Virus-Status: Clean - -The default configuration will use SYS_USB_EVENT_POLL for handling the -usb keyboard and it makes the system really slow (eg slow keypress, -loading kernel/initrd from grub-efi is taking ages). - -Using CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE seems to be improving -things a lot, so use it. - -Tested-by: Samuel Dionne-Riel -Signed-off-by: Arnaud Patard - -Index: u-boot/configs/pinebook-pro-rk3399_defconfig -=================================================================== ---- u-boot.orig/configs/pinebook-pro-rk3399_defconfig -+++ u-boot/configs/pinebook-pro-rk3399_defconfig -@@ -78,6 +78,7 @@ CONFIG_USB_OHCI_GENERIC=y - CONFIG_USB_DWC3=y - CONFIG_ROCKCHIP_USB2_PHY=y - CONFIG_USB_KEYBOARD=y -+CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y - CONFIG_USB_HOST_ETHER=y - CONFIG_USB_ETHER_ASIX=y - CONFIG_USB_ETHER_RTL8152=y - From patchwork Tue Oct 27 13:21:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 diff --git a/rockchip-Pinebook-Pro-Fix-USB.patch b/rockchip-Pinebook-Pro-Fix-USB.patch new file mode 100644 index 0000000..8f81454 --- /dev/null +++ b/rockchip-Pinebook-Pro-Fix-USB.patch @@ -0,0 +1,39 @@ +From 12bc3e2c7c805f989629d1a546276491a7d28922 Mon Sep 17 00:00:00 2001 +From: Peter Robinson +Date: Mon, 9 Nov 2020 23:01:19 +0000 +Subject: [PATCH] rockchip: Pinebook Pro: Fix USB + +Improve USB config so keyboard and USB-A ports work. + +Signed-off-by: Peter Robinson +--- + configs/pinebook-pro-rk3399_defconfig | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig +index 1ed54ad0ed..8fbd7280ac 100644 +--- a/configs/pinebook-pro-rk3399_defconfig ++++ b/configs/pinebook-pro-rk3399_defconfig +@@ -55,6 +55,8 @@ CONFIG_SPI_FLASH_WINBOND=y + CONFIG_DM_ETH=y + CONFIG_NVME=y + CONFIG_PCI=y ++CONFIG_PHY_ROCKCHIP_INNO_USB2=y ++CONFIG_PHY_ROCKCHIP_TYPEC=y + CONFIG_DM_PMIC_FAN53555=y + CONFIG_PMIC_RK8XX=y + CONFIG_REGULATOR_PWM=y +@@ -76,8 +78,9 @@ CONFIG_USB_EHCI_GENERIC=y + CONFIG_USB_OHCI_HCD=y + CONFIG_USB_OHCI_GENERIC=y + CONFIG_USB_DWC3=y +-CONFIG_ROCKCHIP_USB2_PHY=y ++CONFIG_USB_DWC3_GENERIC=y + CONFIG_USB_KEYBOARD=y ++CONFIG_SYS_USB_EVENT_POLL_VIA_INT_QUEUE=y + CONFIG_USB_HOST_ETHER=y + CONFIG_USB_ETHER_ASIX=y + CONFIG_USB_ETHER_RTL8152=y +-- +2.28.0 + diff --git a/uboot-tools.spec b/uboot-tools.spec index 9cbd2ad..8b15690 100644 --- a/uboot-tools.spec +++ b/uboot-tools.spec @@ -39,6 +39,7 @@ Patch13: arm-rk3399-enable-rng-on-rock960-and-firefly3399.patch Patch14: rockchip-Rock960-Fix-up-USB-support.patch Patch15: rockchip-Move-Bob-specific-bits-to-it-s-specific-u-b.patch Patch16: rk3399-Pinebook-pro-EDP-support.patch +Patch17: rockchip-Pinebook-Pro-Fix-USB.patch BuildRequires: bc BuildRequires: dtc @@ -255,6 +256,7 @@ cp -p board/warp7/README builds/docs/README.warp7 * Sun Nov 8 2020 Peter Robinson - 2020.10-3 - Fix SPI on Rockchip devices - Latest Pinebook Pro display patches +- Fix Keyboard and USB-A ports on Pinebook Pro * Wed Oct 28 2020 Peter Robinson - 2020.10-2 - Fix kernel installs for non EBBR systems