2014-11-02 22:15:07 +00:00
|
|
|
From c96c14e1f545e6533c781e33c2238d1433deb30f Mon Sep 17 00:00:00 2001
|
2014-11-02 19:18:20 +00:00
|
|
|
From: Kay Sievers <kay@vrfy.org>
|
|
|
|
Date: Thu, 30 Oct 2014 01:18:34 +0100
|
|
|
|
Subject: [PATCH] udev: path_id - update comments
|
|
|
|
|
|
|
|
(cherry picked from commit a42cdff19f2d34f12ceca0f40707421a8aaa2c2f)
|
|
|
|
---
|
|
|
|
src/udev/udev-builtin-path_id.c | 12 ++++++------
|
|
|
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
|
|
|
|
|
|
|
diff --git a/src/udev/udev-builtin-path_id.c b/src/udev/udev-builtin-path_id.c
|
|
|
|
index 0d247f6b5a..df996cb17a 100644
|
|
|
|
--- a/src/udev/udev-builtin-path_id.c
|
|
|
|
+++ b/src/udev/udev-builtin-path_id.c
|
|
|
|
@@ -548,9 +548,9 @@ static int builtin_path_id(struct udev_device *dev, int argc, char *argv[], bool
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
- * Do return devices with have an unknown type of parent device, they
|
|
|
|
- * might produce conflicting IDs below multiple independent parent
|
|
|
|
- * devices.
|
|
|
|
+ * Do not return devices with an unknown parent device type. They
|
|
|
|
+ * might produce conflicting IDs if the parent does not provide a
|
|
|
|
+ * unique and predictable name.
|
|
|
|
*/
|
|
|
|
if (!supported_parent) {
|
|
|
|
free(path);
|
|
|
|
@@ -558,9 +558,9 @@ static int builtin_path_id(struct udev_device *dev, int argc, char *argv[], bool
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
- * Do not return a have-only a single-parent block devices, some
|
|
|
|
- * have entire hidden buses behind it, and not create predictable
|
|
|
|
- * IDs that way.
|
|
|
|
+ * Do not return block devices without a well-known transport. Some
|
|
|
|
+ * devices do not expose their buses and do not provide a unique
|
|
|
|
+ * and predictable name that way.
|
|
|
|
*/
|
|
|
|
if (streq(udev_device_get_subsystem(dev), "block") && !supported_transport) {
|
|
|
|
free(path);
|