c0971b7e39
- Resolves: upstream#3821 - crash related to sbus_router_destructor()
- Resolves: upstream#3810 - sbus2: fix memory leak in sbus_message_bound_ref
- Resolves: upstream#3819 - sssd only sets the SELinux login context if it
differs from the default
- Resolves: upstream#3807 - The sbus codegen script relies on "python" which
might not be available on all distributions
- Resolves: upstream#3820 - sudo: search with lower cased name for case
insensitive domains
- Resolves: upstream#3701 - [RFE] Allow changing default behavior of SSSD from
an allow-any default to a deny-any default when it
can't find any GPOs to apply to a user login.
- Resolves: upstream#3828 - Invalid domain provider causes SSSD to abort
startup
- Resolves: upstream#3500 - Make sure sssd is a replacement for pam_pkcs11
also for local account authentication
- Resolves: upstream#3812 - sssd 2.0.0 segfaults on startup
- Resolves: upstream#3826 - Remove references of sss_user/group/add/del
commands in man pages since local provider is
deprecated
- Resolves: upstream#3827 - SSSD should log to syslog if a domain is not
started due to a misconfiguration
- Resolves: upstream#3830 - Printing incorrect information about domain with
sssctl utility
- Resolves: upstream#3489 - p11_child should work wit openssl1.0+
- Resolves: upstream#3750 - [RFE] man 5 sssd-files should mention necessary
changes in nsswitch.conf
- Resovles: upstream#3650 - RFE: Require smartcard authentication
- Resolves: upstream#3334 - sssctl config-check does not check any special
characters in domain name of domain section
- Resolves: upstream#3849 - Files: The files provider always enumerates
which causes duplicate when running getent passwd
- Related: upstream#3855 - session not recording for local user when groups
defined
- Resolves: upstream#3802 - Reuse sysdb_error_to_errno() outside sysdb
- Related: upstream#3493 - Remove the pysss.local interface
44 lines
1.6 KiB
Diff
44 lines
1.6 KiB
Diff
From fc29c3eb9750c5e7def4e1ab6eb18f4f5024f567 Mon Sep 17 00:00:00 2001
|
|
From: Jakub Hrozek <jhrozek@redhat.com>
|
|
Date: Tue, 16 Oct 2018 10:42:43 +0200
|
|
Subject: [PATCH 83/83] UTIL: Suppress Coverity warning
|
|
|
|
We recently added this code:
|
|
if (domain_name != NULL
|
|
&& is_files_provider(find_domain_by_name(dom,
|
|
domain_name,
|
|
false)))
|
|
|
|
find_domain_by_name returns NULL if the domain_name can't be found. This
|
|
of course makes mostly sense for trusted domains that can appear and
|
|
disappear. And is_files_provider() didn't handle the situation where the
|
|
domain pointer was NULL and would directly dereference it.
|
|
|
|
This commit just adds a NULL check for the domain pointer so that
|
|
is_files_provider() returns 'false' if the domain pointer was NULL.
|
|
|
|
Another alternative might be to check the return value of
|
|
find_domain_by_name(), but I don't think it's worth the trouble.
|
|
|
|
Reviewed-by: Sumit Bose <sbose@redhat.com>
|
|
---
|
|
src/util/domain_info_utils.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/src/util/domain_info_utils.c b/src/util/domain_info_utils.c
|
|
index 8bef6c9..ffb8cdf 100644
|
|
--- a/src/util/domain_info_utils.c
|
|
+++ b/src/util/domain_info_utils.c
|
|
@@ -931,6 +931,7 @@ bool sss_domain_info_get_output_fqnames(struct sss_domain_info *domain)
|
|
|
|
bool is_files_provider(struct sss_domain_info *domain)
|
|
{
|
|
- return domain->provider != NULL &&
|
|
+ return domain != NULL &&
|
|
+ domain->provider != NULL &&
|
|
strcasecmp(domain->provider, "files") == 0;
|
|
}
|
|
--
|
|
2.9.5
|
|
|