c0971b7e39
- Resolves: upstream#3821 - crash related to sbus_router_destructor()
- Resolves: upstream#3810 - sbus2: fix memory leak in sbus_message_bound_ref
- Resolves: upstream#3819 - sssd only sets the SELinux login context if it
differs from the default
- Resolves: upstream#3807 - The sbus codegen script relies on "python" which
might not be available on all distributions
- Resolves: upstream#3820 - sudo: search with lower cased name for case
insensitive domains
- Resolves: upstream#3701 - [RFE] Allow changing default behavior of SSSD from
an allow-any default to a deny-any default when it
can't find any GPOs to apply to a user login.
- Resolves: upstream#3828 - Invalid domain provider causes SSSD to abort
startup
- Resolves: upstream#3500 - Make sure sssd is a replacement for pam_pkcs11
also for local account authentication
- Resolves: upstream#3812 - sssd 2.0.0 segfaults on startup
- Resolves: upstream#3826 - Remove references of sss_user/group/add/del
commands in man pages since local provider is
deprecated
- Resolves: upstream#3827 - SSSD should log to syslog if a domain is not
started due to a misconfiguration
- Resolves: upstream#3830 - Printing incorrect information about domain with
sssctl utility
- Resolves: upstream#3489 - p11_child should work wit openssl1.0+
- Resolves: upstream#3750 - [RFE] man 5 sssd-files should mention necessary
changes in nsswitch.conf
- Resovles: upstream#3650 - RFE: Require smartcard authentication
- Resolves: upstream#3334 - sssctl config-check does not check any special
characters in domain name of domain section
- Resolves: upstream#3849 - Files: The files provider always enumerates
which causes duplicate when running getent passwd
- Related: upstream#3855 - session not recording for local user when groups
defined
- Resolves: upstream#3802 - Reuse sysdb_error_to_errno() outside sysdb
- Related: upstream#3493 - Remove the pysss.local interface
43 lines
1.6 KiB
Diff
43 lines
1.6 KiB
Diff
From 9245bf1afe6767a0412212bc0040e606ee850e7d Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina@redhat.com>
|
|
Date: Wed, 12 Sep 2018 13:21:11 +0200
|
|
Subject: [PATCH 41/83] sbus: read destination after sender is set
|
|
|
|
dbus_message_set_sender may reallocate internal fields which will yield pointer
|
|
obtained by dbus_message_get_* invalid.
|
|
|
|
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
|
|
---
|
|
src/sbus/server/sbus_server_handler.c | 8 +++++---
|
|
1 file changed, 5 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/src/sbus/server/sbus_server_handler.c b/src/sbus/server/sbus_server_handler.c
|
|
index c300d81..d4e4547 100644
|
|
--- a/src/sbus/server/sbus_server_handler.c
|
|
+++ b/src/sbus/server/sbus_server_handler.c
|
|
@@ -148,9 +148,6 @@ sbus_server_filter(DBusConnection *dbus_conn,
|
|
return DBUS_HANDLER_RESULT_HANDLED;
|
|
}
|
|
|
|
- destination = dbus_message_get_destination(message);
|
|
- type = dbus_message_get_type(message);
|
|
-
|
|
conn = dbus_connection_get_data(dbus_conn, server->data_slot);
|
|
if (conn == NULL) {
|
|
DEBUG(SSSDBG_CRIT_FAILURE, "Unknown connection!\n");
|
|
@@ -173,6 +170,11 @@ sbus_server_filter(DBusConnection *dbus_conn,
|
|
return DBUS_HANDLER_RESULT_HANDLED;
|
|
}
|
|
|
|
+ /* Set sender may reallocate internal fields so this needs to be read
|
|
+ * after we call dbus_message_set_sender(). */
|
|
+ destination = dbus_message_get_destination(message);
|
|
+ type = dbus_message_get_type(message);
|
|
+
|
|
if (type == DBUS_MESSAGE_TYPE_SIGNAL) {
|
|
return sbus_server_route_signal(server, conn, message, destination);
|
|
}
|
|
--
|
|
2.9.5
|
|
|