c0971b7e39
- Resolves: upstream#3821 - crash related to sbus_router_destructor()
- Resolves: upstream#3810 - sbus2: fix memory leak in sbus_message_bound_ref
- Resolves: upstream#3819 - sssd only sets the SELinux login context if it
differs from the default
- Resolves: upstream#3807 - The sbus codegen script relies on "python" which
might not be available on all distributions
- Resolves: upstream#3820 - sudo: search with lower cased name for case
insensitive domains
- Resolves: upstream#3701 - [RFE] Allow changing default behavior of SSSD from
an allow-any default to a deny-any default when it
can't find any GPOs to apply to a user login.
- Resolves: upstream#3828 - Invalid domain provider causes SSSD to abort
startup
- Resolves: upstream#3500 - Make sure sssd is a replacement for pam_pkcs11
also for local account authentication
- Resolves: upstream#3812 - sssd 2.0.0 segfaults on startup
- Resolves: upstream#3826 - Remove references of sss_user/group/add/del
commands in man pages since local provider is
deprecated
- Resolves: upstream#3827 - SSSD should log to syslog if a domain is not
started due to a misconfiguration
- Resolves: upstream#3830 - Printing incorrect information about domain with
sssctl utility
- Resolves: upstream#3489 - p11_child should work wit openssl1.0+
- Resolves: upstream#3750 - [RFE] man 5 sssd-files should mention necessary
changes in nsswitch.conf
- Resovles: upstream#3650 - RFE: Require smartcard authentication
- Resolves: upstream#3334 - sssctl config-check does not check any special
characters in domain name of domain section
- Resolves: upstream#3849 - Files: The files provider always enumerates
which causes duplicate when running getent passwd
- Related: upstream#3855 - session not recording for local user when groups
defined
- Resolves: upstream#3802 - Reuse sysdb_error_to_errno() outside sysdb
- Related: upstream#3493 - Remove the pysss.local interface
69 lines
2.3 KiB
Diff
69 lines
2.3 KiB
Diff
From d7f0b58e2896ed2ef9ed5a390815c1e4df6caaee Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= <pbrezina@redhat.com>
|
|
Date: Thu, 6 Sep 2018 13:38:56 +0200
|
|
Subject: [PATCH 18/83] sudo: respect case sensitivity in sudo responder
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
If the domain is not case sensitive and the case of the original user
|
|
or group name differs from the name in the rule we failed to find the
|
|
rule.
|
|
|
|
Now we filter the rule only with lower cased values in such domain.
|
|
|
|
Steps to reproduce:
|
|
1. Add user/group with upper case, e.g. USER-1
|
|
2. Add sudo rule with lower cased name, e.g. sudoUser: user-1
|
|
3. Login to system with lower case, e.g. user-1
|
|
4. Run sudo -l
|
|
|
|
Without the patch, rule is not found.
|
|
|
|
Resolves:
|
|
https://pagure.io/SSSD/sssd/issue/3820
|
|
|
|
Reviewed-by: Michal Židek <mzidek@redhat.com>
|
|
---
|
|
src/db/sysdb_sudo.c | 17 ++++++++++++++---
|
|
1 file changed, 14 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/src/db/sysdb_sudo.c b/src/db/sysdb_sudo.c
|
|
index 3ad462d..19ed97b 100644
|
|
--- a/src/db/sysdb_sudo.c
|
|
+++ b/src/db/sysdb_sudo.c
|
|
@@ -418,7 +418,17 @@ sysdb_get_sudo_user_info(TALLOC_CTX *mem_ctx,
|
|
ret = EINVAL;
|
|
goto done;
|
|
}
|
|
- DEBUG(SSSDBG_TRACE_FUNC, "original name: %s\n", orig_name);
|
|
+
|
|
+ DEBUG(SSSDBG_TRACE_FUNC, "Original name: %s\n", orig_name);
|
|
+
|
|
+ orig_name = sss_get_cased_name(tmp_ctx, orig_name, domain->case_sensitive);
|
|
+ if (orig_name == NULL) {
|
|
+ DEBUG(SSSDBG_CRIT_FAILURE, "Out of memory!\n");
|
|
+ ret = ENOMEM;
|
|
+ goto done;
|
|
+ }
|
|
+
|
|
+ DEBUG(SSSDBG_TRACE_FUNC, "Cased name: %s\n", orig_name);
|
|
|
|
if (_uid != NULL) {
|
|
uid = ldb_msg_find_attr_as_uint64(res->msgs[0], SYSDB_UIDNUM, 0);
|
|
@@ -450,8 +460,9 @@ sysdb_get_sudo_user_info(TALLOC_CTX *mem_ctx,
|
|
continue;
|
|
}
|
|
|
|
- sysdb_groupnames[num_groups] = talloc_strdup(sysdb_groupnames,
|
|
- groupname);
|
|
+ sysdb_groupnames[num_groups] = \
|
|
+ sss_get_cased_name(sysdb_groupnames, groupname,
|
|
+ domain->case_sensitive);
|
|
if (sysdb_groupnames[num_groups] == NULL) {
|
|
DEBUG(SSSDBG_MINOR_FAILURE, "Cannot strdup %s\n", groupname);
|
|
continue;
|
|
--
|
|
2.9.5
|
|
|