33 lines
1.2 KiB
Diff
33 lines
1.2 KiB
Diff
From ee280ed38752e60d7cba0abc1c9370b016ca3a27 Mon Sep 17 00:00:00 2001
|
|
From: Jakub Hrozek <jhrozek@redhat.com>
|
|
Date: Sun, 23 Nov 2014 19:58:45 +0100
|
|
Subject: [PATCH 20/26] SBUS: Initialize DBusError before using it
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
In case either handler_fn() or invoker_fn() failed in
|
|
sbus_request_invoke_or_finish() we would have accessed an uninitialized
|
|
DBusError variable, causing a segfault.
|
|
|
|
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
|
|
---
|
|
src/sbus/sssd_dbus_request.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/src/sbus/sssd_dbus_request.c b/src/sbus/sssd_dbus_request.c
|
|
index 7729d4e0d7bf6e517e2efce4dbeb064f6f471b87..0028d3537adeddc26e7b8480eb37e979a6cdb7ba 100644
|
|
--- a/src/sbus/sssd_dbus_request.c
|
|
+++ b/src/sbus/sssd_dbus_request.c
|
|
@@ -79,6 +79,7 @@ sbus_request_invoke_or_finish(struct sbus_request *dbus_req,
|
|
sbus_request_finish(dbus_req, NULL);
|
|
break;
|
|
default:
|
|
+ dbus_error_init(&error);
|
|
dbus_set_error_const(&error, DBUS_ERROR_FAILED, INTERNAL_ERROR);
|
|
sbus_request_fail_and_finish(dbus_req, &error);
|
|
break;
|
|
--
|
|
2.1.0
|
|
|