54 lines
1.8 KiB
Diff
54 lines
1.8 KiB
Diff
|
From 7a2e56d061085c155a51253bd612255a4d24cb57 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Tomas Halman <thalman@redhat.com>
|
||
|
|
Date: Mon, 8 Oct 2018 12:47:40 +0200
|
||
|
|
Subject: [PATCH 69/83] test_config: Test for invalid characker in domain
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
There was bug allowing forbidden characters in config file section name.
|
||
|
|
Bug has been fixed meantime but we decided to write the test to avoid
|
||
|
|
regeression.
|
||
|
|
|
||
|
|
Resolves:
|
||
|
|
https://pagure.io/SSSD/sssd/issue/3334
|
||
|
|
|
||
|
|
Reviewed-by: Michal Židek <mzidek@redhat.com>
|
||
|
|
---
|
||
|
|
src/tests/cmocka/test_config_check.c | 12 ++++++++++++
|
||
|
|
1 file changed, 12 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/src/tests/cmocka/test_config_check.c b/src/tests/cmocka/test_config_check.c
|
||
|
|
index a2958de..61c7886 100644
|
||
|
|
--- a/src/tests/cmocka/test_config_check.c
|
||
|
|
+++ b/src/tests/cmocka/test_config_check.c
|
||
|
|
@@ -106,6 +106,17 @@ void config_check_test_bad_section_name(void **state)
|
||
|
|
config_check_test_common(cfg_str, 1, expected_errors);
|
||
|
|
}
|
||
|
|
|
||
|
|
+void config_check_test_bad_chars_in_section_name(void **state)
|
||
|
|
+{
|
||
|
|
+ char cfg_str[] = "[domain/LD@P]";
|
||
|
|
+ const char *expected_errors[] = {
|
||
|
|
+ "[rule/allowed_sections]: Section [domain/LD@P] is not allowed. "
|
||
|
|
+ "Check for typos.",
|
||
|
|
+ };
|
||
|
|
+
|
||
|
|
+ config_check_test_common(cfg_str, 1, expected_errors);
|
||
|
|
+}
|
||
|
|
+
|
||
|
|
void config_check_test_too_many_subdomains(void **state)
|
||
|
|
{
|
||
|
|
char cfg_str[] = "[domain/ad.test/b.test/c.test]";
|
||
|
|
@@ -264,6 +275,7 @@ int main(int argc, const char *argv[])
|
||
|
|
|
||
|
|
const struct CMUnitTest tests[] = {
|
||
|
|
cmocka_unit_test(config_check_test_bad_section_name),
|
||
|
|
+ cmocka_unit_test(config_check_test_bad_chars_in_section_name),
|
||
|
|
cmocka_unit_test(config_check_test_too_many_subdomains),
|
||
|
|
cmocka_unit_test(config_check_test_bad_sssd_option_name),
|
||
|
|
cmocka_unit_test(config_check_test_bad_pam_option_name),
|
||
|
|
--
|
||
|
|
2.9.5
|
||
|
|
|