62 lines
2.4 KiB
Diff
62 lines
2.4 KiB
Diff
|
From b54d79cf3c8017e186b5ea7cdc383746233db39b Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= <fidencio@redhat.com>
|
||
|
|
Date: Mon, 14 Aug 2017 15:28:41 +0200
|
||
|
|
Subject: [PATCH 63/93] NEGCACHE: Add some comments about each step of
|
||
|
|
sss_ncache_prepopulate()
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The comments help to understand which part of the code is dealing with
|
||
|
|
users or groups of specific or non-specific domain filters.
|
||
|
|
|
||
|
|
Related: https://pagure.io/SSSD/sssd/issue/3460
|
||
|
|
|
||
|
|
Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
|
||
|
|
|
||
|
|
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
|
||
|
|
---
|
||
|
|
src/responder/common/negcache.c | 5 ++++-
|
||
|
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/src/responder/common/negcache.c b/src/responder/common/negcache.c
|
||
|
|
index 084c47aa8a0cfec88edf8e3e30e94299792feeb5..376c3e6565f218067b57f564ffab06f40e0ae0ca 100644
|
||
|
|
--- a/src/responder/common/negcache.c
|
||
|
|
+++ b/src/responder/common/negcache.c
|
||
|
|
@@ -786,7 +786,7 @@ errno_t sss_ncache_prepopulate(struct sss_nc_ctx *ncache,
|
||
|
|
return ENOMEM;
|
||
|
|
}
|
||
|
|
|
||
|
|
- /* Populate domain-specific negative cache entries */
|
||
|
|
+ /* Populate domain-specific negative cache user entries */
|
||
|
|
for (dom = domain_list; dom; dom = get_next_domain(dom, 0)) {
|
||
|
|
conf_path = talloc_asprintf(tmpctx, CONFDB_DOMAIN_PATH_TMPL,
|
||
|
|
dom->name);
|
||
|
|
@@ -844,6 +844,7 @@ errno_t sss_ncache_prepopulate(struct sss_nc_ctx *ncache,
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
+ /* Populate non domain-specific negative cache user entries */
|
||
|
|
ret = confdb_get_string_as_list(cdb, tmpctx, CONFDB_NSS_CONF_ENTRY,
|
||
|
|
CONFDB_NSS_FILTER_USERS, &filter_list);
|
||
|
|
if (ret == ENOENT) {
|
||
|
|
@@ -920,6 +921,7 @@ errno_t sss_ncache_prepopulate(struct sss_nc_ctx *ncache,
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
+ /* Populate domain-specific negative cache group entries */
|
||
|
|
filter_set = false;
|
||
|
|
for (dom = domain_list; dom; dom = get_next_domain(dom, 0)) {
|
||
|
|
conf_path = talloc_asprintf(tmpctx, CONFDB_DOMAIN_PATH_TMPL, dom->name);
|
||
|
|
@@ -970,6 +972,7 @@ errno_t sss_ncache_prepopulate(struct sss_nc_ctx *ncache,
|
||
|
|
}
|
||
|
|
}
|
||
|
|
|
||
|
|
+ /* Populate non domain-specific negative cache group entries */
|
||
|
|
ret = confdb_get_string_as_list(cdb, tmpctx, CONFDB_NSS_CONF_ENTRY,
|
||
|
|
CONFDB_NSS_FILTER_GROUPS, &filter_list);
|
||
|
|
if (ret == ENOENT) {
|
||
|
|
--
|
||
|
|
2.14.1
|
||
|
|
|