From d0d893f8a27cc81249e7326d4d8a9f06db80a3e4 Mon Sep 17 00:00:00 2001 From: Jesus Checa Hidalgo Date: Tue, 19 Oct 2021 10:15:25 +0200 Subject: [PATCH] Ensure that rust don't break other packages Added two tests that build stratisd and librsvg2. Rust is listed as BuildRequires in those packages, so the aim of these tests is to detect upfront if rust breaks depending packages builds. --- tests/Sanity/build-stratisd/Makefile | 63 ++++++++++++++++++++++ tests/Sanity/build-stratisd/PURPOSE | 3 ++ tests/Sanity/build-stratisd/main.fmf | 17 ++++++ tests/Sanity/build-stratisd/runtest.sh | 65 +++++++++++++++++++++++ tests/Sanity/rpmbuild-librsvg2/Makefile | 65 +++++++++++++++++++++++ tests/Sanity/rpmbuild-librsvg2/PURPOSE | 3 ++ tests/Sanity/rpmbuild-librsvg2/main.fmf | 18 +++++++ tests/Sanity/rpmbuild-librsvg2/runtest.sh | 65 +++++++++++++++++++++++ 8 files changed, 299 insertions(+) create mode 100644 tests/Sanity/build-stratisd/Makefile create mode 100644 tests/Sanity/build-stratisd/PURPOSE create mode 100644 tests/Sanity/build-stratisd/main.fmf create mode 100755 tests/Sanity/build-stratisd/runtest.sh create mode 100644 tests/Sanity/rpmbuild-librsvg2/Makefile create mode 100644 tests/Sanity/rpmbuild-librsvg2/PURPOSE create mode 100644 tests/Sanity/rpmbuild-librsvg2/main.fmf create mode 100755 tests/Sanity/rpmbuild-librsvg2/runtest.sh diff --git a/tests/Sanity/build-stratisd/Makefile b/tests/Sanity/build-stratisd/Makefile new file mode 100644 index 0000000..a085527 --- /dev/null +++ b/tests/Sanity/build-stratisd/Makefile @@ -0,0 +1,63 @@ +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Makefile of /tools/rust/Sanity/build-stratisd +# Description: rpmbuild stratisd +# Author: Edjunior Machado +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2018 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +export TEST=/tools/rust/Sanity/build-stratisd +export TESTVERSION=1.0 + +BUILT_FILES= + +FILES=$(METADATA) runtest.sh Makefile PURPOSE + +.PHONY: all install download clean + +run: $(FILES) build + ./runtest.sh + +build: $(BUILT_FILES) + test -x runtest.sh || chmod a+x runtest.sh + +clean: + rm -f *~ $(BUILT_FILES) + + +include /usr/share/rhts/lib/rhts-make.include + +$(METADATA): Makefile + @echo "Owner: Edjunior Machado " > $(METADATA) + @echo "Name: $(TEST)" >> $(METADATA) + @echo "TestVersion: $(TESTVERSION)" >> $(METADATA) + @echo "Path: $(TEST_DIR)" >> $(METADATA) + @echo "Description: rpmbuild stratisd" >> $(METADATA) + @echo "Type: Sanity" >> $(METADATA) + @echo "TestTime: 1h" >> $(METADATA) + @echo "RunFor: rust" >> $(METADATA) + @echo "Requires: rust rpm-build yum-utils stratisd" >> $(METADATA) + @echo "Priority: Normal" >> $(METADATA) + @echo "License: GPLv2+" >> $(METADATA) + @echo "Confidential: no" >> $(METADATA) + @echo "Destructive: no" >> $(METADATA) + @echo "Releases: RHEL8 RHEL9" >> $(METADATA) + + rhts-lint $(METADATA) diff --git a/tests/Sanity/build-stratisd/PURPOSE b/tests/Sanity/build-stratisd/PURPOSE new file mode 100644 index 0000000..c790991 --- /dev/null +++ b/tests/Sanity/build-stratisd/PURPOSE @@ -0,0 +1,3 @@ +PURPOSE of /tools/rust/Sanity/build-stratisd +Description: rpmbuild stratisd +Author: Edjunior Machado diff --git a/tests/Sanity/build-stratisd/main.fmf b/tests/Sanity/build-stratisd/main.fmf new file mode 100644 index 0000000..0617757 --- /dev/null +++ b/tests/Sanity/build-stratisd/main.fmf @@ -0,0 +1,17 @@ +summary: rpmbuild stratisd +description: + - 'Ensure that rust does not break stratisd rpmbuild' +contact: + - Jesus Checa Hidalgo +component: + - rust +test: ./runtest.sh +framework: beakerlib +recommend: + - rust + - rpm-build + - yum-utils + - stratisd +duration: 1h +extra-summary: /tools/rust/Sanity/build-stratisd +extra-task: /tools/rust/Sanity/build-stratisd diff --git a/tests/Sanity/build-stratisd/runtest.sh b/tests/Sanity/build-stratisd/runtest.sh new file mode 100755 index 0000000..693a72f --- /dev/null +++ b/tests/Sanity/build-stratisd/runtest.sh @@ -0,0 +1,65 @@ +#!/bin/bash +# vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# runtest.sh of /tools/rust/Sanity/build-stratisd +# Description: rpmbuild stratisd +# Author: Edjunior Machado +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2018 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +# Include Beaker environment +. /usr/share/beakerlib/beakerlib.sh || exit 1 + +PACKAGE="$(rpm -qf $(which rustc))" + +rlJournalStart + rlPhaseStartSetup + rlAssertRpm $PACKAGE || rlDie "rustc not found. Aborting testcase..." + rlRun "TmpDir=\$(mktemp -d)" 0 "Creating tmp directory" + rlRun "pushd $TmpDir" + rlPhaseEnd + + PKG_TO_BUILD=stratisd + rlPhaseStart FAIL ${PKG_TO_BUILD}FetchSrcAndInstallBuildDeps + if ! rlCheckRpm $PKG_TO_BUILD; then + rlRun "yum install -y $PKG_TO_BUILD" + rlAssertRpm $PKG_TO_BUILD + fi + rlFetchSrcForInstalled $PKG_TO_BUILD + rlRun SRPM=$(ls -1 ${PKG_TO_BUILD}*src.rpm) + rlRun "rpm -ivh $SRPM" + rlRun SPECDIR="$(rpm -E '%{_specdir}')" + + rlRun "yum-builddep -y ${SRPM}" + rlPhaseEnd + + rlPhaseStartTest + set -o pipefail + rlRun "rpmbuild -bb ${SPECDIR}/${PKG_TO_BUILD}.spec |& tee ${SRPM}_rpmbuild.log" + rlFileSubmit "${SRPM}_rpmbuild.log" + rlPhaseEnd + + rlPhaseStartCleanup + rlRun "popd" + rlRun "rm -r $TmpDir" 0 "Removing tmp directory" + rlPhaseEnd +rlJournalPrintText +rlJournalEnd diff --git a/tests/Sanity/rpmbuild-librsvg2/Makefile b/tests/Sanity/rpmbuild-librsvg2/Makefile new file mode 100644 index 0000000..bd22601 --- /dev/null +++ b/tests/Sanity/rpmbuild-librsvg2/Makefile @@ -0,0 +1,65 @@ +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Makefile of /tools/rust/Sanity/rpmbuild-librsvg2 +# Description: rpmbuild librsvg2 +# Author: Edjunior Machado +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2018 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +export TEST=/tools/rust/Sanity/rpmbuild-librsvg2 +export TESTVERSION=1.0 + +BUILT_FILES= + +FILES=$(METADATA) runtest.sh Makefile PURPOSE + +.PHONY: all install download clean + +run: $(FILES) build + ./runtest.sh + +build: $(BUILT_FILES) + test -x runtest.sh || chmod a+x runtest.sh + +clean: + rm -f *~ $(BUILT_FILES) + + +include /usr/share/rhts/lib/rhts-make.include + +$(METADATA): Makefile + @echo "Owner: Edjunior Machado " > $(METADATA) + @echo "Name: $(TEST)" >> $(METADATA) + @echo "TestVersion: $(TESTVERSION)" >> $(METADATA) + @echo "Path: $(TEST_DIR)" >> $(METADATA) + @echo "Description: rpmbuild librsvg2" >> $(METADATA) + @echo "Type: Sanity" >> $(METADATA) + @echo "TestTime: 1h" >> $(METADATA) + @echo "RunFor: rust" >> $(METADATA) + # Due to bz1980717 librsvg2 requires git to build the srpm, but it's missing + # from the BuildRequires + @echo "Requires: rust rpm-build yum-utils librsvg2 git" >> $(METADATA) + @echo "Priority: Normal" >> $(METADATA) + @echo "License: GPLv2+" >> $(METADATA) + @echo "Confidential: no" >> $(METADATA) + @echo "Destructive: no" >> $(METADATA) + @echo "Releases: RHEL8 RHEL9" >> $(METADATA) + + rhts-lint $(METADATA) diff --git a/tests/Sanity/rpmbuild-librsvg2/PURPOSE b/tests/Sanity/rpmbuild-librsvg2/PURPOSE new file mode 100644 index 0000000..d3a05af --- /dev/null +++ b/tests/Sanity/rpmbuild-librsvg2/PURPOSE @@ -0,0 +1,3 @@ +PURPOSE of /tools/rust/Sanity/rpmbuild-librsvg2 +Description: rpmbuild librsvg2 +Author: Edjunior Machado diff --git a/tests/Sanity/rpmbuild-librsvg2/main.fmf b/tests/Sanity/rpmbuild-librsvg2/main.fmf new file mode 100644 index 0000000..decb64d --- /dev/null +++ b/tests/Sanity/rpmbuild-librsvg2/main.fmf @@ -0,0 +1,18 @@ +summary: rpmbuild librsvg2 +description: + - 'Ensure that rust does not break librsvg2 rpmbuild' +contact: + - Jesus Checa Hidalgo +component: + - rust +test: ./runtest.sh +framework: beakerlib +recommend: + - rust + - rpm-build + - yum-utils + - librsvg2 + - git +duration: 1h +extra-summary: /tools/rust/Sanity/rpmbuild-librsvg2 +extra-task: /tools/rust/Sanity/rpmbuild-librsvg2 diff --git a/tests/Sanity/rpmbuild-librsvg2/runtest.sh b/tests/Sanity/rpmbuild-librsvg2/runtest.sh new file mode 100755 index 0000000..8965c9e --- /dev/null +++ b/tests/Sanity/rpmbuild-librsvg2/runtest.sh @@ -0,0 +1,65 @@ +#!/bin/bash +# vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# runtest.sh of /tools/rust/Sanity/rpmbuild-librsvg2 +# Description: rpmbuild librsvg2 +# Author: Edjunior Machado +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2018 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +# Include Beaker environment +. /usr/share/beakerlib/beakerlib.sh || exit 1 + +PACKAGE="$(rpm -qf $(which rustc))" + +rlJournalStart + rlPhaseStartSetup + rlAssertRpm $PACKAGE || rlDie "rustc not found. Aborting testcase..." + rlRun "TmpDir=\$(mktemp -d)" 0 "Creating tmp directory" + rlRun "pushd $TmpDir" + rlPhaseEnd + + PKG_TO_BUILD=librsvg2 + rlPhaseStart FAIL ${PKG_TO_BUILD}FetchSrcAndInstallBuildDeps + if ! rlCheckRpm $PKG_TO_BUILD; then + rlRun "yum install -y $PKG_TO_BUILD ${YUM_SWITCHES}" + rlAssertRpm $PKG_TO_BUILD + fi + rlFetchSrcForInstalled $PKG_TO_BUILD + rlRun SRPM=$(ls -1 ${PKG_TO_BUILD}*src.rpm) + rlRun "rpm -ivh $SRPM" + rlRun SPECDIR="$(rpm -E '%{_specdir}')" + + rlRun "yum-builddep -y ${SPECDIR}/${PKG_TO_BUILD}.spec ${YUM_SWITCHES}" + rlPhaseEnd + + rlPhaseStartTest + set -o pipefail + rlRun "rpmbuild -bb ${SPECDIR}/${PKG_TO_BUILD}.spec |& tee ${SRPM}_rpmbuild.log" + rlFileSubmit "${SRPM}_rpmbuild.log" + rlPhaseEnd + + rlPhaseStartCleanup + rlRun "popd" + rlRun "rm -r $TmpDir" 0 "Removing tmp directory" + rlPhaseEnd +rlJournalPrintText +rlJournalEnd