This could be done in /usr/lib/rpm/macros.d/macros.perl, but redhat
macros can override it thus keeping all custom changes in one place.
We also don't need to rebuild perl again.
We have to disable test suite subpackages in perl packages to avoid
breaking conflict as the feature uses %__spec_check_pre, which is
used by us to disable %check section.
Alternative could be doing this in redhat macros:
%__spec_check_args %{nil}
%__spec_check_post exit 0
We basically remove '-e' from arguments and then at the end do 'exit 0',
but it's no perfect as someone could do 'exit ABC' in %check. We wanted
to completely disable %check section.
Signed-off-by: David Abdurachmanov <david.abdurachmanov@gmail.com>
Using the modification time of the snapshot tarball for computing dist is a bad idea, since it's different on different machines.
For example, the computed date during the `buildSRPMfromSCM` koji task is likely different from the local date when the package was prepared, and so package builds (especially EVRs and changelog entries) are not reproducible.
With this change, the snapshot date is not calculated magically, but the packager has to set "%global date YYYYMMDD" manually. I also adapted the documentation for the macro to reflect that change.
This is related to the following FPC issue: https://pagure.io/packaging-committee/issue/719
This patch adds two additional rpm macros, __brp_mangle_shebangs_exclude_file
and __brp_mangle_shebangs_exclude_from_file, to specify files from which
to read the extended regexps used for excluding shebangs and target
files.
Additionally, this adds documentation in the macros file and
--help/--usage/-?/-h to brp-mangle-shebangs, so that it's possible to
actually discover what the intended behavior is without reading the
script itself.
Signed-off-by: Peter Jones <pjones@redhat.com>
If %ldconfig is not defined, then "%ldconfig_post/%ldconfig_postun foo"
will expand to " foo" which is breaking packages.
Also now it is possible to move %end into post/postun.
Reported-by: Terje Røsten <terjeros@phys.ntnu.no>
References: https://bugzilla.redhat.com/show_bug.cgi?id=1548331
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
If people choose to use %ldconfig_post/%ldconfig_postun, let them to
deal with %end.
Reported-by: Harald Reindl <h.reindl@thelounge.net>
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1547838
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
Some people tend to use comments in spec files which adds them into the
scriptlet and we don't want this.
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
Now it starts requiring bash instead of POSIX-compatible shell, but this
is not a problem since other scripts in here do same.
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
Introduces __brp_mangle_shebangs_exclude_from and __brp_mangle_shebangs_exclude
* the first allows to explude specific paths from the mangling
* the second allows to exlude specific shebangs
Both are used with `grep -E`. Similar escaping rules as in [1] apply.
[1] https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering
With https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
we try to remove ldconfig scriptlets, but it would make every package
look horrible with all those conditionals. So let's just wrap ldconfig
scriptlets into macro so it doesn't look that horrible and error-prone.
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
If there are unpackaged symlinks, build will fail with unpackaged files.
People can %undefine __brp_ldconfig if they need to and they should make
sure that they call ldconfig themselves.
Right now, script doesn't guide packagers what to do, but it's not
prerequisite.
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
Fabio Valentini
David Abdurachmanov
Peter Jones
Florian Weimer
Jason Tibbitts
Nicolas Mailhot
Zbigniew Jędrzejewski-Szmek
Igor Gnatenko
Miro Hrončok
Peter Robinson