From 9e10bb665ec2d3cc4b1ea613a7fe8e99e467e64e Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Wed, 11 Jan 2023 11:54:21 -0500 Subject: [PATCH] Disable frame pointers on ELN and RHEL RHEL does not intend to enable frame pointers at this time, and any change will be done so based on a variety of inputs including the data from Fedora. Disable them for ELN to set proper expectations. Signed-off-by: Stephen Gallagher --- macros | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/macros b/macros index 3c6b27e..385cd7d 100644 --- a/macros +++ b/macros @@ -334,14 +334,14 @@ print(result) # to move the annobin notes into the separate debuginfo file. %_find_debuginfo_extra_opts %{?_annotated_build:--remove-section .gnu.build.attributes} -# Always include frame pointer information +# Include frame pointer information by default, except on RHEL # https://fedoraproject.org/wiki/Changes/fno-omit-frame-pointer # Use "%undefine _include_frame_pointers" to disable. -%_include_frame_pointers 1 -%_frame_pointers_cflags %{?_include_frame_pointers:-fno-omit-frame-pointer} -%_frame_pointers_cflags_x86_64 %{?_include_frame_pointers:-mno-omit-leaf-frame-pointer} -%_frame_pointers_cflags_aarch64 %{?_include_frame_pointers:-mno-omit-leaf-frame-pointer} -%_frame_pointers_cflags_s390x %{?_include_frame_pointers:-mbackchain} +%_include_frame_pointers %{undefined rhel} +%_frame_pointers_cflags %[ 0%{?_include_frame_pointers} ? "-fno-omit-frame-pointer" : "" ] +%_frame_pointers_cflags_x86_64 %[ 0%{?_include_frame_pointers} ? "-mno-omit-leaf-frame-pointer" : "" ] +%_frame_pointers_cflags_aarch64 %[ 0%{?_include_frame_pointers} ? "-mno-omit-leaf-frame-pointer" : "" ] +%_frame_pointers_cflags_s390x %[ 0%{?_include_frame_pointers} ? "-mbackchain" : "" ] # Fail linking if there are undefined symbols. Required for proper # ELF symbol versioning support. Disabled by default.