From 924b9f3be4b4e8074af8d42b0f524092e8add189 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADt=20Ondruch?= Date: Tue, 17 Mar 2020 12:17:57 +0100 Subject: [PATCH] Drop `%requires_eq`. This macro calls `rpm` on background, which is not good idea. Luckily, it seems to be used just by samba package, so it should not cause any substantial issues. More details at \[[1]\] where the guideline to ban `rpm` call during build is discussed. [1]: https://pagure.io/packaging-committee/pull-request/954 --- macros | 3 --- 1 file changed, 3 deletions(-) diff --git a/macros b/macros index ee0d81b..9646f6b 100644 --- a/macros +++ b/macros @@ -269,6 +269,3 @@ print(result) %global __find_provides /bin/sh -c "%{?__filter_prov_cmd} %{__deploop P} %{?__filter_from_prov}" \ %global __find_requires /bin/sh -c "%{?__filter_req_cmd} %{__deploop R} %{?__filter_from_req}" \ } - -# Temporary shelter for rpm 4.15 refugees -%requires_eq() %(LC_ALL="C" echo '%*' | xargs -r rpm -q --qf 'Requires: %%{name} = %%{epoch}:%%{version}\\n' | sed -e 's/ (none):/ /' -e 's/ 0:/ /' | grep -v "is not")