5.9.6

and use %%make_build

.gitignore

@@ -1,3 +1,3 @@
-/qtdeclarative-opensource-src-5.9.1.tar.xz
-/qtdeclarative-opensource-src-5.9.2.tar.xz
-/qtdeclarative-opensource-src-5.9.3.tar.xz
+/qtdeclarative-opensource-src-5.9.4.tar.xz
+/qtdeclarative-opensource-src-5.9.6.tar.xz
+/qtdeclarative-everywhere-src-5.11.0.tar.xz

0028-Rebuild-property-cache-in-QObjectWrapper-getProperty.patch

@@ -0,0 +1,41 @@
+From 73e8321255d9f0e70529a58c10dbaf4790a9a659 Mon Sep 17 00:00:00 2001
+From: David Edmundson <davidedmundson@kde.org>
+Date: Tue, 6 Mar 2018 10:56:23 +0000
+Subject: [PATCH 28/29] Rebuild property cache in QObjectWrapper::getProperty
+ if deleted
+
+QQmlData is shared between engines, but the relevant QObjectWrapper is
+not.
+
+Since 749a7212e903d8e8c6f256edb1836b9449cc7fe1 when a QObjectWrapper is
+deleted it resets the shared QQmlData propertyCache.
+
+ab5d4c78224c9ec79165e8890e5f8b8e838e0709 fixed this situation for
+bindings, however we would still hit effectively the same crash in the
+same situation if a function is evaluated before a binding.
+
+Change-Id: I20cd91cd8e31fd0176d542822c67e81a790599ba
+Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
+---
+ src/qml/jsruntime/qv4qobjectwrapper.cpp | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/src/qml/jsruntime/qv4qobjectwrapper.cpp b/src/qml/jsruntime/qv4qobjectwrapper.cpp
+index 5ebd385cf..c1bbe2a33 100644
+--- a/src/qml/jsruntime/qv4qobjectwrapper.cpp
++++ b/src/qml/jsruntime/qv4qobjectwrapper.cpp
+@@ -335,6 +335,11 @@ ReturnedValue QObjectWrapper::getProperty(ExecutionEngine *engine, QObject *obje
+     if (!ddata)
+         return QV4::Encode::undefined();
+ 
++    if (Q_UNLIKELY(!ddata->propertyCache)) {
++        ddata->propertyCache = QQmlEnginePrivate::get(engine)->cache(object->metaObject());
++        ddata->propertyCache->addref();
++    }
++
+     QQmlPropertyCache *cache = ddata->propertyCache;
+     Q_ASSERT(cache);
+     QQmlPropertyData *property = cache->property(propertyIndex);
+-- 
+2.14.3
+

qt5-qtdeclarative.spec

@@ -13,7 +13,7 @@
 
 Summary: Qt5 - QtDeclarative component
 Name:    qt5-%{qt_module}
-Version: 5.9.3
+Version: 5.9.6
 Release: 1%{?dist}
 
 # See LICENSE.GPL LICENSE.LGPL LGPL_EXCEPTION.txt, for details
@@ -35,10 +35,17 @@ Patch1: qtdeclarative-opensource-src-5.9.0-no_sse2.patch
 Patch2: qtdeclarative-QQuickShaderEffectSource_deadlock.patch
 
 ## upstream patches
+# https://codereview.qt-project.org/#/c/224684/
+Patch100: qtdeclarative-leak.patch
+
 # regression https://bugreports.qt.io/browse/QTBUG-64017
 # so revert this offending commit (for now)
 Patch111: 0111-Fix-qml-cache-invalidation-when-changing-dependent-C.patch
 
+# 5.11 branch fixes
+Patch128: 0028-Rebuild-property-cache-in-QObjectWrapper-getProperty.patch
+
+
 ## upstreamable patches
 # use system double-conversation
 # https://bugs.kde.org/show_bug.cgi?id=346118#c108
@@ -101,7 +108,12 @@ Requires: %{name}%{?_isa} = %{version}-%{release}
 %endif
 %patch2 -p1 -b .QQuickShaderEffectSource_deadlock
 
-%patch111 -p1 -R -b .0111
+%patch100 -p1 -b .memleak
+
+## try 5.9.6 without reversing this patch and see -- rex
+#patch111 -p1 -R -b .0111
+
+%patch128 -p1 -b .0028
 
 %patch201 -p0 -b .kdebug346118
 %patch202 -p1 -b .no_sse2_non_fatal
@@ -114,14 +126,14 @@ mkdir -p %{_target_platform}-no_sse2
 pushd    %{_target_platform}-no_sse2
 %{qmake_qt5} -config no_sse2 ..
 make sub-src-clean
-make %{?_smp_mflags} -C src/qml
+%make_build -C src/qml
 popd
 %endif
 
 # no shadow builds until fixed: https://bugreports.qt.io/browse/QTBUG-37417
 %{qmake_qt5}
 
-make %{?_smp_mflags}
+%make_build
 
 
 %install
@@ -232,6 +244,18 @@ make check -k -C tests ||:
 
 
 %changelog
+* Mon Jun 11 2018 Rex Dieter <rdieter@fedoraproject.org> - 5.9.6-1
+- 5.9.6
+
+* Thu Apr 19 2018 Rex Dieter <rdieter@fedoraproject.org> - 5.9.4-3
+- backport qv4qobjectwrapper fixes
+
+* Tue Apr 03 2018 Rex Dieter <rdieter@fedoraproject.org> - 5.9.4-2
+- pull in candidate memleak fix (review#224684)
+
+* Wed Jan 24 2018 Rex Dieter <rdieter@fedoraproject.org> - 5.9.4-1
+- 5.9.4
+
 * Thu Nov 23 2017 Jan Grulich <jgrulich@redhat.com> - 5.9.3-1
 - 5.9.3
 

qtdeclarative-leak.patch

@@ -0,0 +1,22 @@
+diff -up qtdeclarative-everywhere-src-5.10.1/src/quick/scenegraph/qsgrenderloop.cpp.leak qtdeclarative-everywhere-src-5.10.1/src/quick/scenegraph/qsgrenderloop.cpp
+--- qtdeclarative-everywhere-src-5.10.1/src/quick/scenegraph/qsgrenderloop.cpp.leak	2018-04-03 11:14:09.975064043 -0500
++++ qtdeclarative-everywhere-src-5.10.1/src/quick/scenegraph/qsgrenderloop.cpp	2018-04-03 11:15:29.347573091 -0500
+@@ -305,6 +305,8 @@ void QSGGuiThreadRenderLoop::hide(QQuick
+ {
+     QQuickWindowPrivate *cd = QQuickWindowPrivate::get(window);
+     cd->fireAboutToStop();
++    if (m_windows.contains(window))
++        m_windows[window].updatePending = false;
+ }
+ 
+ void QSGGuiThreadRenderLoop::windowDestroyed(QQuickWindow *window)
+@@ -494,7 +496,8 @@ QImage QSGGuiThreadRenderLoop::grab(QQui
+ 
+ void QSGGuiThreadRenderLoop::maybeUpdate(QQuickWindow *window)
+ {
+-    if (!m_windows.contains(window))
++     QQuickWindowPrivate *cd = QQuickWindowPrivate::get(window);
++     if (!cd->isRenderable() || !m_windows.contains(window))
+         return;
+ 
+     m_windows[window].updatePending = true;

sources

@@ -1 +1 @@
-SHA512 (qtdeclarative-opensource-src-5.9.3.tar.xz) = 933caf5848437cde45b4bbf0c70b6cafbc690657c651508b28138b2f90d2f823f4842bc709f4726e2c88d3913a92240b0dcd9248d83af0d06d7127b9a8211b24
+SHA512 (qtdeclarative-opensource-src-5.9.6.tar.xz) = 1fc7a542c60e8c13ba9b791d7b83a916fc1ffb1d3ab505405055a13d597a2c406f29bbd9309603af5bf56492874efeee33ab0128af1fa44866d66d689147ac39