Fix libvirt + seccomp combo (bz #855162) Fix scsi hotplug crash (bz #879657) Fix QOM refcount crash (bz #881486)
193 lines
5.2 KiB
Diff
193 lines
5.2 KiB
Diff
From b6407e30c30268cdeddec6e2b115f419647cc07f Mon Sep 17 00:00:00 2001
|
|
From: Aurelien Jarno <aurelien@aurel32.net>
|
|
Date: Sun, 16 Sep 2012 13:12:21 +0200
|
|
Subject: [PATCH] gdbstub/sh4: fix build with USE_SOFTFLOAT_STRUCT_TYPES
|
|
|
|
We have to use different type to access float values when
|
|
USE_SOFTFLOAT_STRUCT_TYPES is defined.
|
|
|
|
Rework SH4 version of cpu_gdb_{read,write}_register() using
|
|
a single case, and fixing the coding style. Use ldll_p() and
|
|
stfl_p() to access float values.
|
|
|
|
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
|
|
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
|
|
---
|
|
gdbstub.c | 144 +++++++++++++++++++++++++++++++++++++++-----------------------
|
|
1 file changed, 90 insertions(+), 54 deletions(-)
|
|
|
|
diff --git a/gdbstub.c b/gdbstub.c
|
|
index 5d37dd9..a91709f 100644
|
|
--- a/gdbstub.c
|
|
+++ b/gdbstub.c
|
|
@@ -1226,33 +1226,48 @@ static int cpu_gdb_write_register(CPUOpenRISCState *env,
|
|
|
|
static int cpu_gdb_read_register(CPUSH4State *env, uint8_t *mem_buf, int n)
|
|
{
|
|
- if (n < 8) {
|
|
+ switch (n) {
|
|
+ case 0 ... 7:
|
|
if ((env->sr & (SR_MD | SR_RB)) == (SR_MD | SR_RB)) {
|
|
GET_REGL(env->gregs[n + 16]);
|
|
} else {
|
|
GET_REGL(env->gregs[n]);
|
|
}
|
|
- } else if (n < 16) {
|
|
+ case 8 ... 15:
|
|
GET_REGL(env->gregs[n]);
|
|
- } else if (n >= 25 && n < 41) {
|
|
- GET_REGL(env->fregs[(n - 25) + ((env->fpscr & FPSCR_FR) ? 16 : 0)]);
|
|
- } else if (n >= 43 && n < 51) {
|
|
- GET_REGL(env->gregs[n - 43]);
|
|
- } else if (n >= 51 && n < 59) {
|
|
- GET_REGL(env->gregs[n - (51 - 16)]);
|
|
- }
|
|
- switch (n) {
|
|
- case 16: GET_REGL(env->pc);
|
|
- case 17: GET_REGL(env->pr);
|
|
- case 18: GET_REGL(env->gbr);
|
|
- case 19: GET_REGL(env->vbr);
|
|
- case 20: GET_REGL(env->mach);
|
|
- case 21: GET_REGL(env->macl);
|
|
- case 22: GET_REGL(env->sr);
|
|
- case 23: GET_REGL(env->fpul);
|
|
- case 24: GET_REGL(env->fpscr);
|
|
- case 41: GET_REGL(env->ssr);
|
|
- case 42: GET_REGL(env->spc);
|
|
+ case 16:
|
|
+ GET_REGL(env->pc);
|
|
+ case 17:
|
|
+ GET_REGL(env->pr);
|
|
+ case 18:
|
|
+ GET_REGL(env->gbr);
|
|
+ case 19:
|
|
+ GET_REGL(env->vbr);
|
|
+ case 20:
|
|
+ GET_REGL(env->mach);
|
|
+ case 21:
|
|
+ GET_REGL(env->macl);
|
|
+ case 22:
|
|
+ GET_REGL(env->sr);
|
|
+ case 23:
|
|
+ GET_REGL(env->fpul);
|
|
+ case 24:
|
|
+ GET_REGL(env->fpscr);
|
|
+ case 25 ... 40:
|
|
+ if (env->fpscr & FPSCR_FR) {
|
|
+ stfl_p(mem_buf, env->fregs[n - 9]);
|
|
+ } else {
|
|
+ stfl_p(mem_buf, env->fregs[n - 25]);
|
|
+ }
|
|
+ return 4;
|
|
+ case 41:
|
|
+ GET_REGL(env->ssr);
|
|
+ case 42:
|
|
+ GET_REGL(env->spc);
|
|
+ case 43 ... 50:
|
|
+ GET_REGL(env->gregs[n - 43]);
|
|
+ case 51 ... 58:
|
|
+ GET_REGL(env->gregs[n - (51 - 16)]);
|
|
}
|
|
|
|
return 0;
|
|
@@ -1260,42 +1275,63 @@ static int cpu_gdb_read_register(CPUSH4State *env, uint8_t *mem_buf, int n)
|
|
|
|
static int cpu_gdb_write_register(CPUSH4State *env, uint8_t *mem_buf, int n)
|
|
{
|
|
- uint32_t tmp;
|
|
-
|
|
- tmp = ldl_p(mem_buf);
|
|
-
|
|
- if (n < 8) {
|
|
+ switch (n) {
|
|
+ case 0 ... 7:
|
|
if ((env->sr & (SR_MD | SR_RB)) == (SR_MD | SR_RB)) {
|
|
- env->gregs[n + 16] = tmp;
|
|
+ env->gregs[n + 16] = ldl_p(mem_buf);
|
|
} else {
|
|
- env->gregs[n] = tmp;
|
|
+ env->gregs[n] = ldl_p(mem_buf);
|
|
}
|
|
- return 4;
|
|
- } else if (n < 16) {
|
|
- env->gregs[n] = tmp;
|
|
- return 4;
|
|
- } else if (n >= 25 && n < 41) {
|
|
- env->fregs[(n - 25) + ((env->fpscr & FPSCR_FR) ? 16 : 0)] = tmp;
|
|
- return 4;
|
|
- } else if (n >= 43 && n < 51) {
|
|
- env->gregs[n - 43] = tmp;
|
|
- return 4;
|
|
- } else if (n >= 51 && n < 59) {
|
|
- env->gregs[n - (51 - 16)] = tmp;
|
|
- return 4;
|
|
- }
|
|
- switch (n) {
|
|
- case 16: env->pc = tmp; break;
|
|
- case 17: env->pr = tmp; break;
|
|
- case 18: env->gbr = tmp; break;
|
|
- case 19: env->vbr = tmp; break;
|
|
- case 20: env->mach = tmp; break;
|
|
- case 21: env->macl = tmp; break;
|
|
- case 22: env->sr = tmp; break;
|
|
- case 23: env->fpul = tmp; break;
|
|
- case 24: env->fpscr = tmp; break;
|
|
- case 41: env->ssr = tmp; break;
|
|
- case 42: env->spc = tmp; break;
|
|
+ break;
|
|
+ case 8 ... 15:
|
|
+ env->gregs[n] = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 16:
|
|
+ env->pc = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 17:
|
|
+ env->pr = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 18:
|
|
+ env->gbr = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 19:
|
|
+ env->vbr = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 20:
|
|
+ env->mach = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 21:
|
|
+ env->macl = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 22:
|
|
+ env->sr = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 23:
|
|
+ env->fpul = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 24:
|
|
+ env->fpscr = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 25 ... 40:
|
|
+ if (env->fpscr & FPSCR_FR) {
|
|
+ env->fregs[n - 9] = ldfl_p(mem_buf);
|
|
+ } else {
|
|
+ env->fregs[n - 25] = ldfl_p(mem_buf);
|
|
+ }
|
|
+ break;
|
|
+ case 41:
|
|
+ env->ssr = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 42:
|
|
+ env->spc = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 43 ... 50:
|
|
+ env->gregs[n - 43] = ldl_p(mem_buf);
|
|
+ break;
|
|
+ case 51 ... 58:
|
|
+ env->gregs[n - (51 - 16)] = ldl_p(mem_buf);
|
|
+ break;
|
|
default: return 0;
|
|
}
|
|
|
|
--
|
|
1.8.0.2
|
|
|