09bf21d16d
block: Fix memory alignment of requests (rhbz#2174139)
43 lines
1.4 KiB
Diff
43 lines
1.4 KiB
Diff
From cd316ab11b01b3470148612e6df9891faf1fb311 Mon Sep 17 00:00:00 2001
|
|
From: Keith Busch <kbusch@kernel.org>
|
|
Date: Thu, 29 Sep 2022 13:05:23 -0700
|
|
Subject: [PATCH] block: use the request length for iov alignment
|
|
|
|
An iov length needs to be aligned to the logical block size, which may
|
|
be larger than the memory alignment.
|
|
|
|
Tested-by: Jens Axboe <axboe@kernel.dk>
|
|
Signed-off-by: Keith Busch <kbusch@kernel.org>
|
|
Message-Id: <20220929200523.3218710-3-kbusch@meta.com>
|
|
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
(cherry picked from commit 25474d90aa50bd32e0de395a33d8de42dd6f2aef)
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
---
|
|
block/file-posix.c | 3 ++-
|
|
1 file changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/block/file-posix.c b/block/file-posix.c
|
|
index 0185b4e..6818b0e 100644
|
|
--- a/block/file-posix.c
|
|
+++ b/block/file-posix.c
|
|
@@ -2054,13 +2054,14 @@ static bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov)
|
|
{
|
|
int i;
|
|
size_t alignment = bdrv_min_mem_align(bs);
|
|
+ size_t len = bs->bl.request_alignment;
|
|
IO_CODE();
|
|
|
|
for (i = 0; i < qiov->niov; i++) {
|
|
if ((uintptr_t) qiov->iov[i].iov_base % alignment) {
|
|
return false;
|
|
}
|
|
- if (qiov->iov[i].iov_len % alignment) {
|
|
+ if (qiov->iov[i].iov_len % len) {
|
|
return false;
|
|
}
|
|
}
|
|
--
|
|
2.39.2
|
|
|