1369de9828
CVE-2014-3689 vmware_vga: insufficient parameter validation in rectangle functions (bz #1153038, bz #1153035)
35 lines
1010 B
Diff
35 lines
1010 B
Diff
From: Gerd Hoffmann <kraxel@redhat.com>
|
|
Date: Wed, 29 Oct 2014 12:56:06 +0100
|
|
Subject: [PATCH] vmware-vga: CVE-2014-3689: turn off hw accel
|
|
|
|
Quick & easy stopgap for CVE-2014-3689: We just compile out the
|
|
hardware acceleration functions which lack sanity checks. Thankfully
|
|
we have capability bits for them (SVGA_CAP_RECT_COPY and
|
|
SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory.
|
|
|
|
Subsequent patches will add the missing checks and re-enable the
|
|
hardware acceleration emulation.
|
|
|
|
Cc: qemu-stable@nongnu.org
|
|
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
Reviewed-by: Don Koch <dkoch@verizon.com>
|
|
---
|
|
hw/display/vmware_vga.c | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
|
|
index a6a8cdc..113ce1f 100644
|
|
--- a/hw/display/vmware_vga.c
|
|
+++ b/hw/display/vmware_vga.c
|
|
@@ -27,8 +27,10 @@
|
|
#include "hw/pci/pci.h"
|
|
|
|
#undef VERBOSE
|
|
+#if 0
|
|
#define HW_RECT_ACCEL
|
|
#define HW_FILL_ACCEL
|
|
+#endif
|
|
#define HW_MOUSE_ACCEL
|
|
|
|
#include "vga_int.h"
|