34 lines
1.2 KiB
Diff
34 lines
1.2 KiB
Diff
From: Li Qiang <liqiang6-s@360.cn>
|
|
Date: Sat, 21 Jan 2017 23:42:33 -0800
|
|
Subject: [PATCH] virtio-gpu: fix memory leak in set scanout
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
In virtio_gpu_set_scanout function, when creating the 'rect'
|
|
its refcount is set to 2, by pixman_image_create_bits and
|
|
qemu_create_displaysurface_pixman function. This can lead
|
|
a memory leak issues. This patch avoid this issue.
|
|
|
|
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
|
|
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
|
|
Message-id: 5884626f.5b2f6b0a.1bfff.3037@mx.google.com
|
|
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
|
|
(cherry picked from commit dd248ed7e204ee8a1873914e02b8b526e8f1b80d)
|
|
---
|
|
hw/display/virtio-gpu.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c
|
|
index cadd7d899d..7c8fda1733 100644
|
|
--- a/hw/display/virtio-gpu.c
|
|
+++ b/hw/display/virtio-gpu.c
|
|
@@ -602,6 +602,7 @@ static void virtio_gpu_set_scanout(VirtIOGPU *g,
|
|
cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC;
|
|
return;
|
|
}
|
|
+ pixman_image_unref(rect);
|
|
dpy_gfx_replace_surface(g->scanout[ss.scanout_id].con, scanout->ds);
|
|
}
|
|
|