59 lines
2.2 KiB
Diff
59 lines
2.2 KiB
Diff
From 153f39dc6eec56092cc2b44b5690c9cdd77927b4 Mon Sep 17 00:00:00 2001
|
|
From: Igor Mammedov <imammedo@redhat.com>
|
|
Date: Fri, 14 Jan 2022 09:26:41 -0500
|
|
Subject: [PATCH] tests: acpi: test short OEM_ID/OEM_TABLE_ID values in
|
|
test_oem_fields()
|
|
Content-type: text/plain
|
|
|
|
Previous patch [1] added explicit whitespace padding to OEM_ID/OEM_TABLE_ID
|
|
values used in test_oem_fields() testcase to avoid false positive and
|
|
bisection issues when QEMU is switched to \0' padding. As result
|
|
testcase ceased to test values that were shorter than max possible
|
|
length values.
|
|
|
|
Update testcase to make sure that it's testing shorter IDs like it
|
|
used to before [2].
|
|
|
|
1) "tests: acpi: manually pad OEM_ID/OEM_TABLE_ID for test_oem_fields() test"
|
|
2) 602b458201 ("acpi: Permit OEM ID and OEM table ID fields to be changed")
|
|
|
|
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
|
|
Message-Id: <20220114142641.1727679-1-imammedo@redhat.com>
|
|
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
|
|
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
|
|
(cherry picked from commit 408ca92634770de5eac7965ed97c6260e770f2e7)
|
|
---
|
|
tests/qtest/bios-tables-test.c | 12 ++++++------
|
|
1 file changed, 6 insertions(+), 6 deletions(-)
|
|
|
|
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
|
|
index f5ae719b96..5c497aa0ae 100644
|
|
--- a/tests/qtest/bios-tables-test.c
|
|
+++ b/tests/qtest/bios-tables-test.c
|
|
@@ -71,10 +71,10 @@
|
|
|
|
#define ACPI_REBUILD_EXPECTED_AML "TEST_ACPI_REBUILD_AML"
|
|
|
|
-#define OEM_ID "TEST "
|
|
-#define OEM_TABLE_ID "OEM "
|
|
-#define OEM_TEST_ARGS "-machine x-oem-id='" OEM_ID "',x-oem-table-id='" \
|
|
- OEM_TABLE_ID "'"
|
|
+#define OEM_ID "TEST"
|
|
+#define OEM_TABLE_ID "OEM"
|
|
+#define OEM_TEST_ARGS "-machine x-oem-id=" OEM_ID ",x-oem-table-id=" \
|
|
+ OEM_TABLE_ID
|
|
|
|
typedef struct {
|
|
bool tcg_only;
|
|
@@ -1479,8 +1479,8 @@ static void test_oem_fields(test_data *data)
|
|
continue;
|
|
}
|
|
|
|
- g_assert(memcmp(sdt->aml + 10, OEM_ID, 6) == 0);
|
|
- g_assert(memcmp(sdt->aml + 16, OEM_TABLE_ID, 8) == 0);
|
|
+ g_assert(strncmp((char *)sdt->aml + 10, OEM_ID, 6) == 0);
|
|
+ g_assert(strncmp((char *)sdt->aml + 16, OEM_TABLE_ID, 8) == 0);
|
|
}
|
|
}
|
|
|