42 lines
1.5 KiB
Diff
42 lines
1.5 KiB
Diff
From: Tony Breeds <tony@bakeyournoodle.com>
|
|
Date: Fri, 26 Sep 2014 09:14:11 +1000
|
|
Subject: [PATCH] block/raw-posix: Fix disk corruption in try_fiemap
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter.
|
|
|
|
Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl. This has
|
|
the downside of significantly reducing performance.
|
|
|
|
Reported-By: Michael Steffens <michael_steffens@posteo.de>
|
|
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
|
|
Cc: Kevin Wolf <kwolf@redhat.com>
|
|
Cc: Markus Armbruster <armbru@redhat.com>
|
|
Cc: Stefan Hajnoczi <stefanha@redhat.com>
|
|
Cc: Max Reitz <mreitz@redhat.com>
|
|
Cc: Pádraig Brady <pbrady@redhat.com>
|
|
Cc: Eric Blake <eblake@redhat.com>
|
|
Reviewed-by: Eric Blake <eblake@redhat.com>
|
|
Reviewed-by: Max Reitz <mreitz@redhat.com>
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
(cherry picked from commit 38c4d0aea3e1264c86e282d99560330adf2b6e25)
|
|
---
|
|
block/raw-posix.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/block/raw-posix.c b/block/raw-posix.c
|
|
index ba721d3..a6e13fb 100644
|
|
--- a/block/raw-posix.c
|
|
+++ b/block/raw-posix.c
|
|
@@ -1108,7 +1108,7 @@ static int coroutine_fn raw_co_is_allocated(BlockDriverState *bs,
|
|
|
|
f.fm.fm_start = start;
|
|
f.fm.fm_length = (int64_t)nb_sectors * BDRV_SECTOR_SIZE;
|
|
- f.fm.fm_flags = 0;
|
|
+ f.fm.fm_flags = FIEMAP_FLAG_SYNC;
|
|
f.fm.fm_extent_count = 1;
|
|
f.fm.fm_reserved = 0;
|
|
if (ioctl(s->fd, FS_IOC_FIEMAP, &f) == -1) {
|