The binfmt masks are slightly different but I think they are
functionally equivalent. The script handles arch collision
automatically which lets us drop a lot of the %ifarch stuff
- rdma-core, xen, spice, numactl are available in more places
- drop presumably obsolete aarch64 ld flag droppage
- centralize arch dep checks in one place
We previously disabled the hardened build macros because they broke
static linking. This is now resolved, so we can use them as is, which in
turn ensures ksmctl gets linked correctly.
While doing this it is not neccessary to pass -pie in ldflags, as we are
already giving the --enable-pie configure option. This lets us move
setting of linker/compiler flags into the common run_configure
function, rather than duplicating them for static & dynamic builds
Finally, even though QEMU sets _FORTIFY_SOURCE itself, there's no reason
to strip it from the RPM provided build flags - it is harmless for it to
appear twice on compiler args. This ensures ksmctl.c gets fortified.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
The /usr/bin/python binary has started spewing text to stderr, even when
not connected to a tty, which breaks QEMU test suite.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
There are multiple problems with the license tag
- A bunch of QEMU code is GPLv2-only, not GPLv2-or-later
- Fedora licensing guidelines say that if "GPLv2" is
listed, it is redundant to list "GPLv2+" / "LGPLv2+",
since those licenses are forced to be equiv to "GPLv2"
in the combined work
- QEMU also includes code / files under MIT and CC-BY
license
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Note: this is kinda a temporary fix, but I don't want to wait
for a 'real' fix from upstream as I want to build os-autoinst
for Rawhide and this bug prevents its test suite working right.
An inverted conditional meant that test suite failures were previously
being ignored on all architectures by default, instead of only on the
blacklisted arches (currently none)
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
The previous rebuild was sent to builders before the build root had
updated to pull in the new libiscsi, so it just built with the old
libiscsi again.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
