The conditionals for completely skipping testing, or ignoring all test
failures are much too big a hammer. They are resulting in seriously
broken QEMU binaries making their way into the rawhide repos.
When failures happen the smallest possible number of individual tests
need to be disabled/skipped, but *only* if failure is confined to the
test suite. If there are problems affecting functionality in QEMU
itself, the build should not be forced through, instead QEMU must be
fixed before a build is made.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
The tests were not actually passing, the spec file had been set to
ignore all test failures, and as a result we were shipping completely
fubar builds.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Drop podlators since QEMU no longer uses POD for man pages.
Drop all version numbers, since we can assume Fedora has new enough
packages.
Make comments a little more consistent.
Drop rados2-devel as it is implied by rbd-devel
Use rbd-devel instead of rbd1-devel due to rename
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
From Igor Mammedov:
QEMU doesn't need iasl for building since 2.6,
where we switched to generating acpi tables
using internal aml_foo() API and stopped using
precompiled templates.
Signed-off-by: Cole Robinson <crobinso@redhat.com>
If it ever breaks, it can be skipped by setting the %qemu_sanity_check
variable to 0.
This ensures it does not bit-rot again in future and actually adds some
value to the build.
It has to be skipped for ARM for now due to inability to select the
machine type.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
In a mock build root the kernel probably won't exist in /boot and the
QEMU sanity check script won't search /lib/modules. So we must find the
vmlinuz file and pass it explicitly.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
One part of the spec file checked %{kernel_arches} while the other
checked %{hostqemu}. In fact both conditions need to be valid in
order to be able to run the sanity check. Introduce an explicit
%{qemu_sanity_check} variable to express this rule.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Rawhide grubby deps are currently broken. And I'm not sure if
this is even still required for qemu-sanity-check, so let's see
Signed-off-by: Cole Robinson <crobinso@redhat.com>
