rpms/qemu
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove conditionals for skipping/ignoring tests

Browse Source 
The conditionals for completely skipping testing, or ignoring all test
failures are much too big a hammer. They are resulting in seriously
broken QEMU binaries making their way into the rawhide repos.

When failures happen the smallest possible number of individual tests
need to be disabled/skipped, but *only* if failure is confined to the
test suite. If there are problems affecting functionality in QEMU
itself, the build should not be forced through, instead QEMU must be
fixed before a build is made.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2020-11-05 10:31:27 +00:00
parent 9fb824102c
commit 581fcfe335
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
qemu.spec
View File

@ -1402,10 +1402,6 @@ chmod +x %{buildroot}%{_libdir}/qemu/*.so
%check
%global tests_skip 0
# Enable this temporarily if tests are broken
%global tests_nofail 0
# 2020-08-31: tests passing, but s390x fails due to
# spurious warning breaking an iotest case
# https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg03279.html
@ -1414,12 +1410,7 @@ perl -i -p -e 's/^(127|267)/# $1/' tests/qemu-iotests/group
%endif
pushd build-dynamic
%if !%{tests_skip}
%if %{tests_nofail}
make check V=1 || :
%else
make check V=1
%endif
make check V=1
# Check the binary runs (see eg RHBZ#998722).
b="./x86_64-softmmu/qemu-system-x86_64"
@ -1432,7 +1423,6 @@ echo "Trying to boot kernel $KERNEL with %{?hostqemu}"
qemu-sanity-check --qemu=%{?hostqemu} --kernel=$KERNEL
%endif
%endif
popd