From 357c686a3e95c6ae8015ac8c9999c10f41aeac80 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Wed, 4 Nov 2020 15:27:17 +0000 Subject: [PATCH] Disable LTO again because it is massively broken MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The tests were not actually passing, the spec file had been set to ignore all test failures, and as a result we were shipping completely fubar builds. Signed-off-by: Daniel P. Berrangé --- qemu.spec | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/qemu.spec b/qemu.spec index 409d1dd..8c55ff0 100644 --- a/qemu.spec +++ b/qemu.spec @@ -194,7 +194,7 @@ Summary: QEMU is a FAST! processor emulator Name: qemu Version: 5.1.0 -Release: 6%{?rcrel}%{?dist} +Release: 7%{?rcrel}%{?dist} Epoch: 2 License: GPLv2 and BSD and MIT and CC-BY URL: http://www.qemu.org/ @@ -1015,6 +1015,9 @@ pathfix.py -pni "%{__python3} %{py3_shbang_opts}" scripts/qemu-trace-stap %build +# Disable LTO since it caused lots of strange assert failures. +%define _lto_cflags %{nil} + # OOM killer breaks builds with parallel make on s390(x) %ifarch s390x %global _smp_mflags %{nil} @@ -1908,6 +1911,9 @@ getent passwd qemu >/dev/null || \ %changelog +* Thu Nov 5 2020 Daniel P. Berrangé - 5.1.0-7 +- Disable LTO again. Tests were not passing, we were ignoring failures. + * Mon Oct 26 2020 Daniel P. Berrangé - 5.1.0-6 - Re-enable LTO since tests now pass without asserts