32 lines
1.2 KiB
Diff
32 lines
1.2 KiB
Diff
|
From: Prasad J Pandit <pjp@fedoraproject.org>
|
||
|
|
Date: Wed, 25 May 2016 17:41:44 +0530
|
||
|
|
Subject: [PATCH] scsi: megasas: initialise local configuration data buffer
|
||
|
|
|
||
|
|
When reading MegaRAID SAS controller configuration via MegaRAID
|
||
|
|
Firmware Interface(MFI) commands, routine megasas_dcmd_cfg_read
|
||
|
|
uses an uninitialised local data buffer. Initialise this buffer
|
||
|
|
to avoid stack information leakage.
|
||
|
|
|
||
|
|
Reported-by: Li Qiang <liqiang6-s@360.cn>
|
||
|
|
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
|
||
|
|
Message-Id: <1464178304-12831-1-git-send-email-ppandit@redhat.com>
|
||
|
|
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
|
||
|
|
(cherry picked from commit d37af740730dbbb93960cd318e040372d04d6dcf)
|
||
|
|
---
|
||
|
|
hw/scsi/megasas.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
|
||
|
|
index dcbd3e1..bf642d4 100644
|
||
|
|
--- a/hw/scsi/megasas.c
|
||
|
|
+++ b/hw/scsi/megasas.c
|
||
|
|
@@ -1293,7 +1293,7 @@ static int megasas_dcmd_ld_get_info(MegasasState *s, MegasasCmd *cmd)
|
||
|
|
|
||
|
|
static int megasas_dcmd_cfg_read(MegasasState *s, MegasasCmd *cmd)
|
||
|
|
{
|
||
|
|
- uint8_t data[4096];
|
||
|
|
+ uint8_t data[4096] = { 0 };
|
||
|
|
struct mfi_config_data *info;
|
||
|
|
int num_pd_disks = 0, array_offset, ld_offset;
|
||
|
|
BusChild *kid;
|