2017-01-16 21:04:06 +00:00
|
|
|
From: Li Qiang <liqiang6-s@360.cn>
|
|
|
|
|
Date: Mon, 17 Oct 2016 14:13:58 +0200
|
|
|
|
|
Subject: [PATCH] 9pfs: fix information leak in xattr read
|
|
|
|
|
|
|
|
|
|
9pfs uses g_malloc() to allocate the xattr memory space, if the guest
|
|
|
|
|
reads this memory before writing to it, this will leak host heap memory
|
|
|
|
|
to the guest. This patch avoid this.
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
|
|
|
|
|
Reviewed-by: Greg Kurz <groug@kaod.org>
|
|
|
|
|
Signed-off-by: Greg Kurz <groug@kaod.org>
|
|
|
|
|
(cherry picked from commit eb687602853b4ae656e9236ee4222609f3a6887d)
|
|
|
|
|
---
|
|
|
|
|
hw/9pfs/9p.c | 2 +-
|
|
|
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
|
|
|
|
|
|
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
|
2017-07-12 22:19:21 +00:00
|
|
|
index 2b161ed6c0..0c0645fe9a 100644
|
2017-01-16 21:04:06 +00:00
|
|
|
--- a/hw/9pfs/9p.c
|
|
|
|
|
+++ b/hw/9pfs/9p.c
|
|
|
|
|
@@ -3270,7 +3270,7 @@ static void v9fs_xattrcreate(void *opaque)
|
|
|
|
|
xattr_fidp->fs.xattr.flags = flags;
|
|
|
|
|
v9fs_string_init(&xattr_fidp->fs.xattr.name);
|
|
|
|
|
v9fs_string_copy(&xattr_fidp->fs.xattr.name, &name);
|
|
|
|
|
- xattr_fidp->fs.xattr.value = g_malloc(size);
|
|
|
|
|
+ xattr_fidp->fs.xattr.value = g_malloc0(size);
|
|
|
|
|
err = offset;
|
|
|
|
|
put_fid(pdu, file_fidp);
|
|
|
|
|
out_nofid:
|
