2013-04-02 16:35:23 +00:00
|
|
|
From 16bd0559ba4870cf2f8c62654bcf1ee523e89afd Mon Sep 17 00:00:00 2001
|
2012-01-13 19:46:23 +00:00
|
|
|
From: Alon Levy <alevy@redhat.com>
|
|
|
|
Date: Thu, 28 Jul 2011 15:08:48 +0300
|
2013-04-02 16:35:23 +00:00
|
|
|
Subject: [PATCH] virtio-serial-bus: replay guest_open on migration
|
2012-01-13 19:46:23 +00:00
|
|
|
|
|
|
|
When migrating a host with with a spice agent running the mouse becomes
|
|
|
|
non operational after the migration. This is rhbz #725965.
|
|
|
|
|
|
|
|
The problem is that after migration spice doesn't know the guest agent is open.
|
|
|
|
Spice is just a char dev here. And a chardev cannot query it's device, the
|
|
|
|
device has to let the chardev know when it is open. Right now after migration
|
|
|
|
the chardev which is recreated is in it's default state, which assumes the
|
|
|
|
guest is disconnected.
|
|
|
|
|
|
|
|
Char devices carry no information across migration, but the virtio-serial does
|
|
|
|
already carry the guest_connected state. This patch passes that bit to the
|
|
|
|
chardev.
|
|
|
|
|
|
|
|
Signed-off-by: Alon Levy <alevy@redhat.com>
|
|
|
|
---
|
2013-04-02 16:35:23 +00:00
|
|
|
hw/virtio-serial-bus.c | 6 ++++++
|
|
|
|
1 file changed, 6 insertions(+)
|
2012-01-13 19:46:23 +00:00
|
|
|
|
|
|
|
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
|
|
|
|
index a4825b9..e5f343f 100644
|
|
|
|
--- a/hw/virtio-serial-bus.c
|
|
|
|
+++ b/hw/virtio-serial-bus.c
|
|
|
|
@@ -618,6 +618,7 @@ static int virtio_serial_load(QEMUFile *f, void *opaque, int version_id)
|
|
|
|
for (i = 0; i < nr_active_ports; i++) {
|
|
|
|
uint32_t id;
|
|
|
|
bool host_connected;
|
|
|
|
+ VirtIOSerialPortInfo *info;
|
2013-04-02 16:35:23 +00:00
|
|
|
|
2012-01-13 19:46:23 +00:00
|
|
|
id = qemu_get_be32(f);
|
|
|
|
port = find_port_by_id(s, id);
|
|
|
|
@@ -626,6 +627,11 @@ static int virtio_serial_load(QEMUFile *f, void *opaque, int version_id)
|
|
|
|
}
|
2013-04-02 16:35:23 +00:00
|
|
|
|
2012-01-13 19:46:23 +00:00
|
|
|
port->guest_connected = qemu_get_byte(f);
|
|
|
|
+ info = DO_UPCAST(VirtIOSerialPortInfo, qdev, port->dev.info);
|
|
|
|
+ if (port->guest_connected && info->guest_open) {
|
|
|
|
+ /* replay guest open */
|
|
|
|
+ info->guest_open(port);
|
|
|
|
+ }
|
|
|
|
host_connected = qemu_get_byte(f);
|
|
|
|
if (host_connected != port->host_connected) {
|
|
|
|
/*
|