From 1092d478f540ba9d510316205eca201e5c5d07e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Fri, 7 Dec 2018 10:03:24 +0100 Subject: [PATCH] Make sure we don't ship any exe files (not needed an prebuilt) Such files are only used to create Microsoft Windows installers and that functionality is broken on Linux anyway. We can keep the exe files in SRPM, as they are free software as confirmed by the Python Software Foundation: > Hello, > > Shipping and distributing these files is ok. > > These files are stubs, used as the executable part of a self-unzipping > executable and showing an "installer window" to the user. > They are original to Python and, while they call win32 functions, > they don't have Windows SDK code in them. > The source is at: PC/bdist_wininst/install.c > > The binaries are included so that anyone creating a bdist_wininst > distribution (mostly deprecated, actually) can do so, even when > cross-compiling. > > Thanks, > Van (Lindberg) See also https://mail.python.org/pipermail/python-dev/2018-October/155507.html --- python3.spec | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/python3.spec b/python3.spec index bb020fa..7472a57 100644 --- a/python3.spec +++ b/python3.spec @@ -14,7 +14,7 @@ URL: https://www.python.org/ # WARNING When rebasing to a new Python version, # remember to update the python3-docs package as well Version: %{pybasever}.1 -Release: 4%{?dist} +Release: 5%{?dist} License: Python @@ -627,6 +627,10 @@ version once Python %{pybasever} is stable. %prep %setup -q -n Python-%{version}%{?prerel} +# Remove all exe files to ensure we are not shipping prebuilt binaries +# note that those are only used to create Microsoft Windows installers +# and that functionality is broken on Linux anyway +find -name '*.exe' -print -delete # Remove bundled libraries to ensure that we're using the system copy. rm -r Modules/expat @@ -1283,7 +1287,6 @@ CheckPython optimized %{pylibdir}/distutils/__pycache__/*%{bytecode_suffixes} %{pylibdir}/distutils/README %{pylibdir}/distutils/command -%exclude %{pylibdir}/distutils/command/wininst-*.exe %dir %{pylibdir}/email/ %dir %{pylibdir}/email/__pycache__/ @@ -1353,7 +1356,6 @@ CheckPython optimized %exclude %{pylibdir}/config-%{LDVERSION_optimized}-%{_arch}-linux%{_gnu}/Makefile %exclude %{_includedir}/python%{LDVERSION_optimized}/%{_pyconfig_h} %endif -%{pylibdir}/distutils/command/wininst-*.exe %{_includedir}/python%{LDVERSION_optimized}/*.h %doc Misc/README.valgrind Misc/valgrind-python.supp Misc/gdbinit @@ -1575,6 +1577,9 @@ CheckPython optimized # ====================================================== %changelog +* Fri Dec 07 2018 Miro Hrončok - 3.7.1-5 +- Make sure we don't ship any exe files (not needed an prebuilt) + * Wed Nov 21 2018 Miro Hrončok - 3.7.1-4 - Make sure the entire test.support module is in python3-libs (#1651245)