From 593224df205ac6ca88f402c8134bea239873a696 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Fri, 23 Apr 2021 12:57:43 +0200 Subject: [PATCH] Stop Recommending setuptools and move the pip Recommendation to python3-devel With modern pip, setuptools is not required on runtime. Python packages use PEP 517 instead. Hence, we no longer Recommend setuptools and pip, but pip only. Users who are impacted may see one of: ModuleNotFoundError: No module named 'setuptools' ModuleNotFoundError: No module named 'pkg_resoureces' They can easily recover by installing python3-setuptools or python3-pkg_resources. Related but not explicitly part of: https://fedoraproject.org/wiki/Changes/Reduce_dependencies_on_python3-setuptools Together with this change, we move the pip Recommendation to the python3-devel package. "Regular users" of Fedora are less likely to need pip and more likely to brick their systems with it. If they need pip, they can dnf install pip. Pip (incl. setuptools) still works in environments created with venv or virtualenv. Not bumping the release because this only affects the package when we upgrade the main Python in Fedora to 3.10. --- python3.10.spec | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/python3.10.spec b/python3.10.spec index 49d4aed..90360d6 100644 --- a/python3.10.spec +++ b/python3.10.spec @@ -359,12 +359,6 @@ Provides: python(abi) = %{pybasever} Requires: %{pkgname}-libs%{?_isa} = %{version}-%{release} -# Previously, this was required for our rewheel patch to work. -# This is technically no longer needed, but we keep it recommended -# for the developer experience. -Recommends: %{pkgname}-setuptools -Recommends: %{pkgname}-pip - # This prevents ALL subpackages built from this spec to require # /usr/bin/python3* or python(abi). Granularity per subpackage is impossible. # It's intended for the libs package not to drag in the interpreter, see @@ -454,6 +448,9 @@ Requires: %{pkgname}-libs%{?_isa} = %{version}-%{release} Requires: (python-rpm-macros if rpm-build) Requires: (python3-rpm-macros if rpm-build) +# Python developers are very likely to need pip +Recommends: %{pkgname}-pip + %if %{without bootstrap} Requires: (python3-rpm-generators if rpm-build) %endif