new version by mjw in attachment 390110 of rhbz:545179, as this should eliminate the performance penalty for the case where the probes aren't in use, and eliminate all architecture-specific code (rhbz:563541; except on sparc)
197 lines
6.0 KiB
Diff
197 lines
6.0 KiB
Diff
diff -up Python-2.6.4/configure.in.systemtap Python-2.6.4/configure.in
|
|
--- Python-2.6.4/configure.in.systemtap 2009-12-18 15:37:15.632242686 -0500
|
|
+++ Python-2.6.4/configure.in 2009-12-18 15:37:15.713244483 -0500
|
|
@@ -2481,6 +2481,38 @@ if test "$with_valgrind" != no; then
|
|
)
|
|
fi
|
|
|
|
+# Check for dtrace support
|
|
+AC_MSG_CHECKING(for --with-dtrace)
|
|
+AC_ARG_WITH(dtrace,
|
|
+ AC_HELP_STRING(--with(out)-dtrace, disable/enable dtrace support))
|
|
+
|
|
+if test ! -z "$with_dtrace"
|
|
+then
|
|
+ if dtrace -G -o /dev/null -s $srcdir/Include/pydtrace.d 2>/dev/null
|
|
+ then
|
|
+ AC_DEFINE(WITH_DTRACE, 1,
|
|
+ [Define if you want to compile in Dtrace support])
|
|
+ with_dtrace="Sun"
|
|
+ DTRACEOBJS="Python/dtrace.o"
|
|
+ DTRADEHDRS=""
|
|
+ elif dtrace -h -o /dev/null -s $srcdir/Include/pydtrace.d
|
|
+ then
|
|
+ AC_DEFINE(WITH_DTRACE, 1,
|
|
+ [Define if you want to compile in Dtrace support])
|
|
+ with_dtrace="Apple"
|
|
+ DTRACEOBJS=""
|
|
+ DTRADEHDRS="pydtrace.h"
|
|
+ else
|
|
+ with_dtrace="no"
|
|
+ fi
|
|
+else
|
|
+ with_dtrace="no"
|
|
+fi
|
|
+
|
|
+AC_MSG_RESULT($with_dtrace)
|
|
+AC_SUBST(DTRACEOBJS)
|
|
+AC_SUBST(DTRACEHDRS)
|
|
+
|
|
# Check for --with-wctype-functions
|
|
AC_MSG_CHECKING(for --with-wctype-functions)
|
|
AC_ARG_WITH(wctype-functions,
|
|
diff -up Python-2.6.4/Include/pydtrace.d.systemtap Python-2.6.4/Include/pydtrace.d
|
|
--- Python-2.6.4/Include/pydtrace.d.systemtap 2009-12-18 15:37:15.697243772 -0500
|
|
+++ Python-2.6.4/Include/pydtrace.d 2009-12-18 15:37:15.697243772 -0500
|
|
@@ -0,0 +1,10 @@
|
|
+provider python {
|
|
+ probe function__entry(const char *, const char *, int);
|
|
+ probe function__return(const char *, const char *, int);
|
|
+};
|
|
+
|
|
+#pragma D attributes Evolving/Evolving/Common provider python provider
|
|
+#pragma D attributes Private/Private/Common provider python module
|
|
+#pragma D attributes Private/Private/Common provider python function
|
|
+#pragma D attributes Evolving/Evolving/Common provider python name
|
|
+#pragma D attributes Evolving/Evolving/Common provider python args
|
|
diff -up Python-2.6.4/Makefile.pre.in.systemtap Python-2.6.4/Makefile.pre.in
|
|
--- Python-2.6.4/Makefile.pre.in.systemtap 2009-12-18 15:37:15.399242581 -0500
|
|
+++ Python-2.6.4/Makefile.pre.in 2009-12-18 15:37:15.715242573 -0500
|
|
@@ -290,6 +290,7 @@ PYTHON_OBJS= \
|
|
Python/formatter_unicode.o \
|
|
Python/formatter_string.o \
|
|
Python/$(DYNLOADFILE) \
|
|
+ @DTRACEOBJS@ \
|
|
$(LIBOBJS) \
|
|
$(MACHDEP_OBJS) \
|
|
$(THREADOBJ)
|
|
@@ -577,6 +578,18 @@ Python/formatter_unicode.o: $(srcdir)/Py
|
|
Python/formatter_string.o: $(srcdir)/Python/formatter_string.c \
|
|
$(STRINGLIB_HEADERS)
|
|
|
|
+# Only needed with --with-dtrace
|
|
+buildinclude:
|
|
+ mkdir -p Include
|
|
+
|
|
+Include/pydtrace.h: buildinclude $(srcdir)/Include/pydtrace.d
|
|
+ dtrace -o $@ $(DFLAGS) -C -h -s $(srcdir)/Include/pydtrace.d
|
|
+
|
|
+Python/ceval.o: Include/pydtrace.h
|
|
+
|
|
+Python/dtrace.o: buildinclude $(srcdir)/Include/pydtrace.d Python/ceval.o
|
|
+ dtrace -o $@ $(DFLAGS) -C -G -s $(srcdir)/Include/pydtrace.d Python/ceval.o
|
|
+
|
|
############################################################################
|
|
# Header files
|
|
|
|
@@ -1213,6 +1231,6 @@ Python/thread.o: @THREADHEADERS@
|
|
.PHONY: frameworkinstall frameworkinstallframework frameworkinstallstructure
|
|
.PHONY: frameworkinstallmaclib frameworkinstallapps frameworkinstallunixtools
|
|
.PHONY: frameworkaltinstallunixtools recheck autoconf clean clobber distclean
|
|
-.PHONY: smelly funny patchcheck
|
|
+.PHONY: smelly funny patchcheck buildinclude
|
|
|
|
# IF YOU PUT ANYTHING HERE IT WILL GO AWAY
|
|
diff -up Python-2.6.4/pyconfig.h.in.systemtap Python-2.6.4/pyconfig.h.in
|
|
--- Python-2.6.4/pyconfig.h.in.systemtap 2009-12-18 15:37:15.649243175 -0500
|
|
+++ Python-2.6.4/pyconfig.h.in 2009-12-18 15:37:15.719242803 -0500
|
|
@@ -964,6 +989,9 @@
|
|
/* Define if you want documentation strings in extension modules */
|
|
#undef WITH_DOC_STRINGS
|
|
|
|
+/* Define if you want to compile in Dtrace support */
|
|
+#undef WITH_DTRACE
|
|
+
|
|
/* Define if you want to use the new-style (Openstep, Rhapsody, MacOS) dynamic
|
|
linker (dyld) instead of the old-style (NextStep) dynamic linker (rld).
|
|
Dyld is necessary to support frameworks. */
|
|
diff -up Python-2.6.4/Python/ceval.c.systemtap Python-2.6.4/Python/ceval.c
|
|
--- Python-2.6.4/Python/ceval.c.systemtap 2009-05-30 17:43:48.000000000 -0400
|
|
+++ Python-2.6.4/Python/ceval.c 2009-12-18 15:37:15.723242474 -0500
|
|
@@ -19,6 +19,10 @@
|
|
|
|
#include <ctype.h>
|
|
|
|
+#ifdef WITH_DTRACE
|
|
+#include "pydtrace.h"
|
|
+#endif
|
|
+
|
|
#ifndef WITH_TSC
|
|
|
|
#define READ_TIMESTAMP(var)
|
|
@@ -527,6 +531,55 @@ PyEval_EvalCode(PyCodeObject *co, PyObje
|
|
NULL);
|
|
}
|
|
|
|
+#ifdef WITH_DTRACE
|
|
+static void
|
|
+dtrace_entry(PyFrameObject *f)
|
|
+{
|
|
+ const char *filename;
|
|
+ const char *fname;
|
|
+ int lineno;
|
|
+
|
|
+ filename = PyString_AsString(f->f_code->co_filename);
|
|
+ fname = PyString_AsString(f->f_code->co_name);
|
|
+ lineno = PyCode_Addr2Line(f->f_code, f->f_lasti);
|
|
+
|
|
+ PYTHON_FUNCTION_ENTRY((char *)filename, (char *)fname, lineno);
|
|
+
|
|
+ /*
|
|
+ * Currently a USDT tail-call will not receive the correct arguments.
|
|
+ * Disable the tail call here.
|
|
+ */
|
|
+#if defined(__sparc)
|
|
+ asm("nop");
|
|
+#endif
|
|
+}
|
|
+
|
|
+static void
|
|
+dtrace_return(PyFrameObject *f)
|
|
+{
|
|
+ const char *filename;
|
|
+ const char *fname;
|
|
+ int lineno;
|
|
+
|
|
+ filename = PyString_AsString(f->f_code->co_filename);
|
|
+ fname = PyString_AsString(f->f_code->co_name);
|
|
+ lineno = PyCode_Addr2Line(f->f_code, f->f_lasti);
|
|
+ PYTHON_FUNCTION_RETURN((char *)filename, (char *)fname, lineno);
|
|
+
|
|
+ /*
|
|
+ * Currently a USDT tail-call will not receive the correct arguments.
|
|
+ * Disable the tail call here.
|
|
+ */
|
|
+#if defined(__sparc)
|
|
+ asm("nop");
|
|
+#endif
|
|
+}
|
|
+#else
|
|
+#define PYTHON_FUNCTION_ENTRY_ENABLED() 0
|
|
+#define PYTHON_FUNCTION_RETURN_ENABLED() 0
|
|
+#define dtrace_entry(f)
|
|
+#define dtrace_return(f)
|
|
+#endif
|
|
|
|
/* Interpreter main loop */
|
|
|
|
@@ -763,6 +891,9 @@ PyEval_EvalFrameEx(PyFrameObject *f, int
|
|
}
|
|
}
|
|
|
|
+ if (PYTHON_FUNCTION_ENTRY_ENABLED())
|
|
+ dtrace_entry(f);
|
|
+
|
|
co = f->f_code;
|
|
names = co->co_names;
|
|
consts = co->co_consts;
|
|
@@ -2723,6 +2863,8 @@ fast_yield:
|
|
|
|
/* pop frame */
|
|
exit_eval_frame:
|
|
+ if (PYTHON_FUNCTION_RETURN_ENABLED())
|
|
+ dtrace_return(f);
|
|
Py_LeaveRecursiveCall();
|
|
tstate->frame = f->f_back;
|
|
|