rebase: update to 9.5.9

Per release notes:
http://www.postgresql.org/docs/9.5/static/release-9-5-9.html

Version: 9.5.9-1

.gitignore

@@ -1,3 +1,6 @@
-/postgresql-*.tar.bz2*
-/postgresql-setup-*.tar.gz
-/postgresql-*-US.pdf
+/postgresql-9.4.14.tar.bz2
+/postgresql-9.4.14.tar.bz2.sha256
+/postgresql-9.5.9.tar.bz2
+/postgresql-9.5.9.tar.bz2.sha256
+/postgresql-setup-4.0.tar.gz
+/postgresql-9.5.9-US.pdf

Makefile.regress

@@ -47,9 +47,7 @@ installcheck-parallel: cleandirs
 cleandirs:
 	-rm -rf testtablespace results
 	mkdir testtablespace results
-	if test -x /usr/bin/chcon && ! test -f /.dockerenv; then \
-	    /usr/bin/chcon -u system_u -r object_r -t postgresql_db_t testtablespace results ; \
-	fi
+	[ -x /usr/bin/chcon ] && /usr/bin/chcon -u system_u -r object_r -t postgresql_db_t testtablespace results
 
 # old interfaces follow...
 

gen_sources.sh

@@ -0,0 +1,10 @@
+#! /bin/sh -x
+
+set -e
+spectool -S *.spec | cut -d' ' -f2 \
+    | grep -E -e 'postgresql-.*\.tar\.*' -e 'postgresql.*\.pdf' | sort | \
+while read line
+do
+    base=`basename "$line"`
+    md5sum "$base"
+done

generate-sources-and-gitignore.sh

@@ -1,6 +1,6 @@
 #! /bin/sh
 
-rm sources
+rm sources .gitignore
 set -e
 spectool -S *.spec | cut -d' ' -f2 \
     | grep -E -e 'postgresql-.*\.tar\.*' -e 'postgresql.*\.pdf' | sort | \
@@ -9,4 +9,5 @@ do
     base=`basename "$line"`
     echo " * handling $base"
     sha512sum --tag "$base" >> sources
+    echo "/$base" >> .gitignore
 done

hstore-plperl-data-dumper.patch

@@ -1,192 +0,0 @@
-From 69db3b0cfccc0687dfbdf56afcfb2f8e536053c6 Mon Sep 17 00:00:00 2001
-From: Andrew Dunstan <andrew@dunslane.net>
-Date: Sun, 14 May 2017 01:10:18 -0400
-Subject: [PATCH] Suppress indentation from Data::Dumper in regression tests
-
-Ultra-modern versions of the perl Data::Dumper module have apparently
-changed how they indent output. Instead of trying to keep up we choose
-to tell it to supporess all indentation in the hstore_plperl regression
-tests.
-
-Backpatch to 9.5 where this feature was introduced.
----
- contrib/hstore_plperl/expected/hstore_plperlu.out | 44 ++++++-----------------
- contrib/hstore_plperl/sql/hstore_plperlu.sql      |  6 ++++
- 2 files changed, 17 insertions(+), 33 deletions(-)
-
-diff --git a/contrib/hstore_plperl/expected/hstore_plperlu.out b/contrib/hstore_plperl/expected/hstore_plperlu.out
-index b09fb78..d719d29 100644
---- a/contrib/hstore_plperl/expected/hstore_plperlu.out
-+++ b/contrib/hstore_plperl/expected/hstore_plperlu.out
-@@ -20,15 +20,12 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]));
- return scalar(keys %{$_[0]});
- $$;
- SELECT test1('aa=>bb, cc=>NULL'::hstore);
--INFO:  $VAR1 = {
--          'aa' => 'bb',
--          'cc' => undef
--        };
--
-+INFO:  $VAR1 = {'aa' => 'bb','cc' => undef};
-  test1 
- -------
-      2
-@@ -39,12 +36,12 @@ LANGUAGE plperlu
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]));
- return scalar(keys %{$_[0]});
- $$;
- SELECT test1none('aa=>bb, cc=>NULL'::hstore);
- INFO:  $VAR1 = '"aa"=>"bb", "cc"=>NULL';
--
-  test1none 
- -----------
-          0
-@@ -56,15 +53,12 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]));
- return scalar(keys %{$_[0]});
- $$;
- SELECT test1list('aa=>bb, cc=>NULL'::hstore);
--INFO:  $VAR1 = {
--          'aa' => 'bb',
--          'cc' => undef
--        };
--
-+INFO:  $VAR1 = {'aa' => 'bb','cc' => undef};
-  test1list 
- -----------
-          2
-@@ -77,18 +71,12 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]->[0], $_[0]->[1]));
- return scalar(keys %{$_[0]});
- $$;
- SELECT test1arr(array['aa=>bb, cc=>NULL'::hstore, 'dd=>ee']);
--INFO:  $VAR1 = {
--          'aa' => 'bb',
--          'cc' => undef
--        };
--$VAR2 = {
--          'dd' => 'ee'
--        };
--
-+INFO:  $VAR1 = {'aa' => 'bb','cc' => undef};$VAR2 = {'dd' => 'ee'};
-  test1arr 
- ----------
-         2
-@@ -101,6 +89,7 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- 
- $rv = spi_exec_query(q{SELECT 'aa=>bb, cc=>NULL'::hstore AS col1});
- elog(INFO, Dumper($rv->{rows}[0]->{col1}));
-@@ -111,13 +100,8 @@ $rv = spi_exec_prepared($plan, {}, $val);
- elog(INFO, Dumper($rv->{rows}[0]->{col1}));
- $$;
- SELECT test3();
--INFO:  $VAR1 = {
--          'aa' => 'bb',
--          'cc' => undef
--        };
--
-+INFO:  $VAR1 = {'aa' => 'bb','cc' => undef};
- INFO:  $VAR1 = '"a"=>"1", "b"=>"boo", "c"=>NULL';
--
-  test3 
- -------
-  
-@@ -138,6 +122,7 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_TD->{new}));
- if ($_TD->{new}{a} == 1) {
-     $_TD->{new}{b} = {a => 1, b => 'boo', c => undef};
-@@ -147,14 +132,7 @@ return "MODIFY";
- $$;
- CREATE TRIGGER test4 BEFORE UPDATE ON test1 FOR EACH ROW EXECUTE PROCEDURE test4();
- UPDATE test1 SET a = a;
--INFO:  $VAR1 = {
--          'a' => '1',
--          'b' => {
--                 'aa' => 'bb',
--                 'cc' => undef
--               }
--        };
--
-+INFO:  $VAR1 = {'a' => '1','b' => {'aa' => 'bb','cc' => undef}};
- SELECT * FROM test1;
-  a |                b                
- ---+---------------------------------
-diff --git a/contrib/hstore_plperl/sql/hstore_plperlu.sql b/contrib/hstore_plperl/sql/hstore_plperlu.sql
-index 8d8508c..c714b35 100644
---- a/contrib/hstore_plperl/sql/hstore_plperlu.sql
-+++ b/contrib/hstore_plperl/sql/hstore_plperlu.sql
-@@ -15,6 +15,7 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]));
- return scalar(keys %{$_[0]});
- $$;
-@@ -26,6 +27,7 @@ LANGUAGE plperlu
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]));
- return scalar(keys %{$_[0]});
- $$;
-@@ -38,6 +40,7 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]));
- return scalar(keys %{$_[0]});
- $$;
-@@ -52,6 +55,7 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_[0]->[0], $_[0]->[1]));
- return scalar(keys %{$_[0]});
- $$;
-@@ -66,6 +70,7 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- 
- $rv = spi_exec_query(q{SELECT 'aa=>bb, cc=>NULL'::hstore AS col1});
- elog(INFO, Dumper($rv->{rows}[0]->{col1}));
-@@ -90,6 +95,7 @@ TRANSFORM FOR TYPE hstore
- AS $$
- use Data::Dumper;
- $Data::Dumper::Sortkeys = 1;
-+$Data::Dumper::Indent = 0;
- elog(INFO, Dumper($_TD->{new}));
- if ($_TD->{new}{a} == 1) {
-     $_TD->{new}{b} = {a => 1, b => 'boo', c => undef};
--- 
-2.1.4

postgresql-config-comment.patch

@@ -0,0 +1,19 @@
+Add note warning users that Postgres' port number is forced in the service
+file, mainly because it's traditional in Red Hat installations to set it
+there rather than in postgresql.conf.  (There are minor usability benefits
+to doing it this way though, for example that the postmaster's port number
+is visible in "ps" as part of its command line.)
+
+
+diff -Naur postgresql-9.2rc1.orig/src/backend/utils/misc/postgresql.conf.sample postgresql-9.2rc1/src/backend/utils/misc/postgresql.conf.sample
+--- postgresql-9.2rc1.orig/src/backend/utils/misc/postgresql.conf.sample	2012-08-23 18:06:49.000000000 -0400
++++ postgresql-9.2rc1/src/backend/utils/misc/postgresql.conf.sample	2012-09-01 21:57:55.498629897 -0400
+@@ -61,6 +61,8 @@
+ 					# defaults to 'localhost'; use '*' for all
+ 					# (change requires restart)
+ #port = 5432				# (change requires restart)
++# Note: In RHEL/Fedora installations, you can't set the port number here;
++# adjust it in the service file instead.
+ #max_connections = 100			# (change requires restart)
+ #superuser_reserved_connections = 3	# (change requires restart)
+ #unix_socket_directories = '/tmp'	# comma-separated list of directories

postgresql-external-libpq.patch

@@ -1,43 +0,0 @@
-We don't build/install interfaces by upstream's implicit rules.
-
-This patch is used on two places; postgresql.spec and libecpg.spec -- keep those
-in sync!
-
-Related: rhbz#1618698
-
-diff --git a/src/Makefile b/src/Makefile
-index bcdbd95..4bea236 100644
---- a/src/Makefile
-+++ b/src/Makefile
-@@ -20,7 +20,6 @@ SUBDIRS = \
- 	backend/utils/mb/conversion_procs \
- 	backend/snowball \
- 	include \
--	interfaces \
- 	backend/replication/libpqwalreceiver \
- 	backend/replication/pgoutput \
- 	fe_utils \
-diff --git a/src/Makefile.global.in b/src/Makefile.global.in
-index b9d86ac..29df69f 100644
---- a/src/Makefile.global.in
-+++ b/src/Makefile.global.in
-@@ -549,7 +549,7 @@ endif
- # How to link to libpq.  (This macro may be used as-is by backend extensions.
- # Client-side code should go through libpq_pgport or libpq_pgport_shlib,
- # instead.)
--libpq = -L$(libpq_builddir) -lpq
-+libpq = -lpq
- 
- # libpq_pgport is for use by client executables (not libraries) that use libpq.
- # We force clients to pull symbols from the non-shared libraries libpgport
-@@ -579,7 +579,6 @@ endif
- # Commonly used submake targets
- 
- submake-libpq: | submake-generated-headers
--	$(MAKE) -C $(libpq_builddir) all
- 
- submake-libpgport: | submake-generated-headers
- 	$(MAKE) -C $(top_builddir)/src/port all
--- 
-2.21.0
-

postgresql-logging.patch

@@ -13,9 +13,9 @@ diff -Naur postgresql-9.1rc1.orig/src/backend/utils/misc/postgresql.conf.sample
  					# into log files. Required to be on for
  					# csvlogs.
  					# (change requires restart)
-@@ -355,11 +355,11 @@
+@@ -287,11 +287,11 @@
  # These are only used if logging_collector is on:
- #log_directory = 'log'			# directory where log files are written,
+ #log_directory = 'pg_log'		# directory where log files are written,
  					# can be absolute or relative to PGDATA
 -#log_filename = 'postgresql-%Y-%m-%d_%H%M%S.log'	# log file name pattern,
 +log_filename = 'postgresql-%a.log'	# log file name pattern,
@@ -27,7 +27,7 @@ diff -Naur postgresql-9.1rc1.orig/src/backend/utils/misc/postgresql.conf.sample
  					# same name as the new log file will be
  					# truncated rather than appended to.
  					# But such truncation only occurs on
-@@ -367,9 +367,9 @@
+@@ -299,9 +299,9 @@
  					# or size-driven rotation.  Default is
  					# off, meaning append to existing files
  					# in all cases.

postgresql-perl-rpath.patch

@@ -0,0 +1,22 @@
+We configure Postgres with --disable-rpath because for the most part we
+want to leave it to ldconfig to determine where libraries are.  However,
+for some reason the Perl package puts libperl.so in a nonstandard place
+and doesn't add that place to the ldconfig search path.  I think this
+is a Perl packaging bug, myself, but apparently it's not going to change.
+So work around it by adding an rpath spec to plperl.so (only).
+Per bug #162198.
+
+
+diff -Naur postgresql-9.1.5.orig/src/pl/plperl/GNUmakefile postgresql-9.1.5/src/pl/plperl/GNUmakefile
+--- postgresql-9.1.5.orig/src/pl/plperl/GNUmakefile	2012-08-14 18:41:04.000000000 -0400
++++ postgresql-9.1.5/src/pl/plperl/GNUmakefile	2012-08-17 11:15:09.457116708 -0400
+@@ -43,6 +43,9 @@
+ 
+ SHLIB_LINK = $(perl_embed_ldflags)
+ 
++# Force rpath to be used even though we disable it everywhere else
++SHLIB_LINK += $(rpath)
++
+ REGRESS_OPTS = --dbname=$(PL_TESTDB) --load-extension=plperl  --load-extension=plperlu
+ REGRESS = plperl plperl_lc plperl_trigger plperl_shared plperl_elog plperl_util plperl_init plperlu plperl_array
+ # if Perl can support two interpreters in one backend,

postgresql-server-pg_config.patch

@@ -1,59 +0,0 @@
-We should ideally provide '/bin/pg_config' in postgresql-server-devel, and
-provide no pg_config binary in libpq package.  But most of the Fedora packages
-that use pg_config actually only build against PG libraries (and
-postgresql-server-devel isn't needed).  So.., to avoid the initial rush around
-rhbz#1618698 change, rather provide pg_server_config binary, which int urn means
-that we'll have to fix only a minimal set of packages which really build
-PostgreSQL server modules.
-
-diff --git a/src/bin/pg_config/Makefile b/src/bin/pg_config/Makefile
-index 02e6f9d..f7c844f 100644
---- a/src/bin/pg_config/Makefile
-+++ b/src/bin/pg_config/Makefile
-@@ -11,28 +11,30 @@
- PGFILEDESC = "pg_config - report configuration information"
- PGAPPICON=win32
- 
-+PG_CONFIG = pg_server_config$(X)
-+
- subdir = src/bin/pg_config
- top_builddir = ../../..
- include $(top_builddir)/src/Makefile.global
- 
- OBJS=   pg_config.o $(WIN32RES)
- 
--all: pg_config
-+all: $(PG_CONFIG)
- 
--pg_config: $(OBJS) | submake-libpgport
--	$(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X)
-+$(PG_CONFIG): $(OBJS) | submake-libpgport
-+	$(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@
- 
- install: all installdirs
--	$(INSTALL_SCRIPT) pg_config$(X) '$(DESTDIR)$(bindir)/pg_config$(X)'
-+	$(INSTALL_SCRIPT) $(PG_CONFIG) '$(DESTDIR)$(bindir)/$(PG_CONFIG)'
- 
- installdirs:
- 	$(MKDIR_P) '$(DESTDIR)$(bindir)'
- 
- uninstall:
--	rm -f '$(DESTDIR)$(bindir)/pg_config$(X)'
-+	rm -f '$(DESTDIR)$(bindir)/$(PG_CONFIG)'
- 
- clean distclean maintainer-clean:
--	rm -f pg_config$(X) $(OBJS)
-+	rm -f $(PG_CONFIG)  $(OBJS)
- 	rm -rf tmp_check
- 
- check:
-diff --git a/src/bin/pg_config/nls.mk b/src/bin/pg_config/nls.mk
-index 1d41f90..0f34f37 100644
---- a/src/bin/pg_config/nls.mk
-+++ b/src/bin/pg_config/nls.mk
-@@ -1,4 +1,4 @@
- # src/bin/pg_config/nls.mk
--CATALOG_NAME     = pg_config
-+CATALOG_NAME     = pg_server_config
- AVAIL_LANGUAGES  = cs de es fr he it ja ko pl pt_BR ro ru sv tr uk vi zh_CN zh_TW
- GETTEXT_FILES    = pg_config.c ../../common/config_info.c ../../common/exec.c

sources

@@ -1,6 +1,6 @@
-SHA512 (postgresql-12.2.tar.bz2) = 0e0ce8e21856e8f43e58b840c10c4e3ffae6d5207e0d778e9176e36f8e20e34633cbb06f0030a7c963c3491bb7e941456d91b55444c561cfc6f283fba76f33ee
-SHA512 (postgresql-12.2.tar.bz2.sha256) = 8f94163228bb7d854d6fe4924a8a2ded00f90af662dd4a7c39b415be0826d9395e55f9b8e3b472baf7c19550e7c35198a650604a28756ad85d096bcfbaa5d1fd
-SHA512 (postgresql-12.2-US.pdf) = f086fead2c094e0f1148bcadaf13e240a84b53be289aa0a323295f65879699e81041b4bbc6cc3ce2744aac3fcb15083fa1cab583cd86fdc8ef626499e3cb3e71
-SHA512 (postgresql-11.7.tar.bz2) = 32c7ace228f9895241ce0d925fbfc60c0cd39f4cd35368fb10dc7db046151ffd59a9895b4c30a529627f0103051e84b4992ed60312cccd292489f3037076ca1e
-SHA512 (postgresql-11.7.tar.bz2.sha256) = 1c8bc319da6bc49000f14e4636f4410b3eb52ab41b0698e7f3ee945efe8e93b6f1758e3f60d8658b0ea6836ea0f271a61031554a10e64c61d2c670e97c63812c
-SHA512 (postgresql-setup-8.4.tar.gz) = eb73767d5c676481598aeb545e15027a29a438aa29480ad414f6af31c9df61138a51f5425999b4b35e776a3dbbb28c887790ea9771abc3328158dd1d34b1dce1
+SHA512 (postgresql-9.4.14.tar.bz2) = 5952479b7c911cc381744e72d44c7c2269f98f4dda677e8c20a8ac7f4281e143017d287634b707ed96859e5438e82e96668bc4c68bb0c2ce9f3853c5a38fd0b2
+SHA512 (postgresql-9.4.14.tar.bz2.sha256) = 6ce24c915f069748b14f393cfbb7e6ade849d07342a1ec00542e401e4e02cd84fd82c2b41c59b4d11be9fe5ae7ef9cb516b79ba08f3658b90ba31c18c1ec0b43
+SHA512 (postgresql-9.5.9.tar.bz2) = 2c6a887b80a4b1d1da18282f443419db2279d8fe61821aa6ed1e9af6d28dda41959981ccede2456bd8835dccd16a80fd485ebc0a1bdc9459996a5d27d7781c55
+SHA512 (postgresql-9.5.9.tar.bz2.sha256) = 2e41c8a4e4a702c621cde35adc9b3496a67190597673e3c725f4c03313dce22691896aae13813039dfbe46d9e131216bcd657210823a55840ddad110fc0d8cc7
+SHA512 (postgresql-setup-4.0.tar.gz) = ed5cb7046f9db4c16ef4f3f390768979b68cef47588c2e4b48efe7d4da815f5c656f58c1758e94b536a31a6ec4e2a5b1295752cac537561aea9c8c292b45b158
+SHA512 (postgresql-9.5.9-US.pdf) = 8d41ea6d58a62fbb35ed870c70f9ba5e045cb7dc156340ac9b6551877ab3a770a1bac562c6ef54d318f8d74aa0ad7b4ff180adfb630e71c2dc34fc090aff5c1b

tests/tests.yml

@@ -1,16 +0,0 @@
-# This package uses external repositories for maintaining CI test cases.
-# Please don't edit this file if possible.
-
-- hosts: localhost
-  roles:
-  - role: standard-test-beakerlib
-    repositories:
-    - repo: https://src.fedoraproject.org/tests/postgresql.git
-      dest: postgresql
-      # TODO: minimize: https://pagure.io/standard-test-roles/issue/294
-      fmf_filter: "tier: 1"
-    # TODO: minimize: https://pagure.io/standard-test-roles/issue/294
-    tags:
-    - classic
-    - container
-    - atomic