- incorporate the package review feedback

pilot-link.spec

@@ -3,13 +3,13 @@
 
 Name: pilot-link
 Version: 0.12.1
-Release: 4%{?dist}
+Release: 5%{?dist}
 Epoch: 2
 License: GPL
 Group: Applications/Communications
-Summary: File transfer utilities between Linux and PalmPilots.
+Summary: File transfer utilities between Linux and PalmPilots
 URL: http://www.pilot-link.org/
-BuildRoot: %{_tmppath}/%{name}-%{version}-root
+BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Source: pilot-link-%{version}.tar.bz2
 ExcludeArch: s390 s390x
 #Patch1: pilot-link-0.11.0-perlmd5.patch  # May be still applied
@@ -17,10 +17,10 @@ ExcludeArch: s390 s390x
 #Patch3: pilot-link-0.11.2-malsync.patch  # May be still applied
 Patch4: pilot-link-0.12.1-var.patch 
 
-Prereq: /sbin/ldconfig
+Requires: /sbin/ldconfig
 
 %if %{support_perl}
-BuildPrereq: perl
+BuildRequireseq: perl
 %endif
 
 BuildRequires: libpng-devel
@@ -41,7 +41,7 @@ Install pilot-link if you want to synchronize your Palm with your Red
 Hat Linux system.
 
 %package devel
-Summary: PalmPilot development header files.
+Summary: PalmPilot development header files
 Group: Development/Libraries
 Requires: %{name} = %{epoch}:%{version}-%{release}
 Requires: libpng-devel
@@ -95,8 +95,8 @@ if test -f bindings/Perl/Makefile.PL ; then
 fi
 %endif
 
-%makeinstall 
-%makeinstall -C doc/man
+make install DESTDIR=%{buildroot} libdir=%{_libdir} 
+make install -C doc/man DESTDIR=%{buildroot} libdir=%{_libdir}
 
 %if %{support_perl}
   make install -C bindings/Perl
@@ -120,7 +120,7 @@ rm -f %{buildroot}%{_bindir}/pilot-prc
 rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root)
+%defattr(-,root,root,-)
 %doc COPYING ChangeLog README NEWS
 %{_libdir}/*.so.*
 %if %{support_perl}
@@ -140,6 +140,9 @@ rm -rf %{buildroot}
 %{_datadir}/aclocal/*.m4
 
 %changelog
+* Fri Mar  9 2007 Ivana Varekova <varekova@redhat.com> - 2:0.12.1-5
+- incorporate the package review feedback
+
 * Thu Nov 30 2006 Ivana Varekova <varekova@redhat.com> - 2:0.12.1-4
 - fix undefined value problem #156682