Compare commits
16 Commits
Author | SHA1 | Date |
---|---|---|
Troy Dawson | 54924e89c5 | |
Paul Howarth | 4c331985df | |
Fedora Release Engineering | 324da16372 | |
Jitka Plesnikova | c7887bc4a6 | |
Jitka Plesnikova | 20771060c0 | |
Paul Howarth | 084f448cee | |
Paul Howarth | 2334201296 | |
Paul Howarth | 3fde4fe021 | |
Fedora Release Engineering | fb9e7a7a7c | |
Paul Howarth | 25940053c2 | |
Fedora Release Engineering | 8544f77e14 | |
Jitka Plesnikova | 28133176a5 | |
Jitka Plesnikova | 6e3f4a1ef5 | |
Paul Howarth | 6523de3347 | |
Paul Howarth | 53939a15c4 | |
Gwyn Ciesla | 18f7b3a91e |
|
@ -0,0 +1,371 @@
|
|||
From 2396c458927b78ee5616e322ae5ac2c55dd6503e Mon Sep 17 00:00:00 2001
|
||||
From: Paul Howarth <paul@city-fan.org>
|
||||
Date: Fri, 21 Jul 2017 11:50:35 +0100
|
||||
Subject: [PATCH] Change default spell check tool from aspell to hunspell
|
||||
|
||||
This is on the basis that most downstream users are already doing
|
||||
or have migrated from aspell to hunspell due to hunspell being
|
||||
actively maintained, unlike aspell.
|
||||
|
||||
https://wiki.ubuntu.com/ConsolidateSpellingLibs
|
||||
https://wiki.gnome.org/Initiatives/SpellChecking
|
||||
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=860895
|
||||
https://fedoraproject.org/wiki/Releases/FeatureDictionary
|
||||
|
||||
Unfortunately, hunspell prior to about version 1.2.12 (2010) had
|
||||
problems with ASCII apostrophes, thus flagging errors for words
|
||||
like "doesn't", "isn't" etc., which makes 1.2.12 pretty much a
|
||||
minimum version requirement if incorporating this change.
|
||||
---
|
||||
.travis.yml | 4 ++--
|
||||
bin/perlcritic | 2 +-
|
||||
.../BuiltinFunctions/ProhibitBooleanGrep.pm | 2 ++
|
||||
.../BuiltinFunctions/ProhibitLvalueSubstr.pm | 2 +-
|
||||
.../BuiltinFunctions/ProhibitShiftRef.pm | 2 +-
|
||||
.../Policy/Documentation/PodSpelling.pm | 20 +++++++++----------
|
||||
.../RequireCheckingReturnValueOfEval.pm | 2 +-
|
||||
.../Policy/Modules/RequireBarewordIncludes.pm | 2 ++
|
||||
.../ProhibitCaptureWithoutTest.pm | 2 ++
|
||||
.../ProhibitComplexRegexes.pm | 2 +-
|
||||
.../ProhibitFixedStringMatches.pm | 2 ++
|
||||
.../ProhibitSingleCharAlternation.pm | 2 ++
|
||||
.../ProhibitUnusedCapture.pm | 2 +-
|
||||
.../ProhibitUnusualDelimiters.pm | 2 ++
|
||||
.../RequireBracesForMultiline.pm | 2 ++
|
||||
.../Variables/ProhibitPunctuationVars.pm | 2 ++
|
||||
.../Variables/RequireLexicalLoopIterators.pm | 2 +-
|
||||
lib/Perl/Critic/Utils.pm | 2 ++
|
||||
lib/Perl/Critic/Utils/PPI.pm | 2 +-
|
||||
t/20_policy_pod_spelling.t | 4 ++--
|
||||
xt/40_perlcriticrc-code | 2 +-
|
||||
21 files changed, 41 insertions(+), 23 deletions(-)
|
||||
|
||||
diff --git a/.travis.yml b/.travis.yml
|
||||
index c907085f..9a01a667 100644
|
||||
--- a/.travis.yml
|
||||
+++ b/.travis.yml
|
||||
@@ -2,8 +2,8 @@
|
||||
addons:
|
||||
apt:
|
||||
packages:
|
||||
- - aspell
|
||||
- - aspell-en
|
||||
+ - hunspell
|
||||
+ - hunspell-en-us
|
||||
language: perl
|
||||
perl:
|
||||
# blead and dev don't play nicely with Module::Build
|
||||
diff --git a/bin/perlcritic b/bin/perlcritic
|
||||
index e9455658..08f8f0ec 100644
|
||||
--- a/bin/perlcritic
|
||||
+++ b/bin/perlcritic
|
||||
@@ -30,7 +30,7 @@ __END__
|
||||
|
||||
=for stopwords DGR INI-style vim-fu minibuffer -noprofile API
|
||||
-profileproto -profile-proto ben Jore formatter Peshak pbp Komodo
|
||||
-screenshots tty emacs gVIM plugin Perlish templating ActivePerl
|
||||
+screenshots tty emacs grep gVIM plugin Perlish templating ActivePerl
|
||||
ActiveState Twitter
|
||||
|
||||
=head1 NAME
|
||||
diff --git a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm
|
||||
index 26ee6107..876e5ed6 100644
|
||||
--- a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm
|
||||
+++ b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitBooleanGrep.pm
|
||||
@@ -86,6 +86,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords grep
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::BuiltinFunctions::ProhibitBooleanGrep - Use C<List::MoreUtils::any> instead of C<grep> in boolean context.
|
||||
diff --git a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
|
||||
index 53187398..4fa75fe0 100644
|
||||
--- a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
|
||||
+++ b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitLvalueSubstr.pm
|
||||
@@ -64,7 +64,7 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
-=for stopwords perlfunc substr 4th
|
||||
+=for stopwords perl5005delta perlfunc substr 4th
|
||||
|
||||
=head1 NAME
|
||||
|
||||
diff --git a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitShiftRef.pm b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitShiftRef.pm
|
||||
index 6fed7ef9..32d01e92 100644
|
||||
--- a/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitShiftRef.pm
|
||||
+++ b/lib/Perl/Critic/Policy/BuiltinFunctions/ProhibitShiftRef.pm
|
||||
@@ -94,7 +94,7 @@ modules.
|
||||
=head2 Background
|
||||
|
||||
Often, C<\shift> is used to create references that act much like an alias. By
|
||||
-creating an ‘alias’ that is named, the code becomes more readable. For example,
|
||||
+creating an 'alias' that is named, the code becomes more readable. For example,
|
||||
|
||||
sub routine {
|
||||
my $longstring = \shift;
|
||||
diff --git a/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm b/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
|
||||
index 5a18fe8f..9305065d 100644
|
||||
--- a/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
|
||||
+++ b/lib/Perl/Critic/Policy/Documentation/PodSpelling.pm
|
||||
@@ -39,7 +39,7 @@ sub supported_parameters {
|
||||
{
|
||||
name => 'spell_command',
|
||||
description => 'The command to invoke to check spelling.',
|
||||
- default_string => 'aspell list',
|
||||
+ default_string => 'hunspell -l',
|
||||
behavior => 'string',
|
||||
},
|
||||
{
|
||||
@@ -200,11 +200,11 @@ sub _run_spell_command {
|
||||
# run spell command and fetch output
|
||||
local $SIG{PIPE} = sub { $got_sigpipe = 1; };
|
||||
my $command_line = join $SPACE, @{$self->_get_spell_command_line()};
|
||||
- open my $aspell_out_fh, q{-|}, "$command_line < $outfile" ## Is this portable??
|
||||
+ open my $speller_out_fh, q{-|}, "$command_line < $outfile" ## Is this portable??
|
||||
or throw_generic "Failed to open handle to spelling program: $OS_ERROR";
|
||||
|
||||
- @words = uniq( <$aspell_out_fh> );
|
||||
- close $aspell_out_fh
|
||||
+ @words = uniq( <$speller_out_fh> );
|
||||
+ close $speller_out_fh
|
||||
or throw_generic "Failed to close handle to spelling program: $OS_ERROR";
|
||||
|
||||
for (@words) {
|
||||
@@ -324,11 +324,11 @@ set a global list of spelling exceptions. To do this, put entries in
|
||||
a F<.perlcriticrc> file like this:
|
||||
|
||||
[Documentation::PodSpelling]
|
||||
- spell_command = aspell list
|
||||
+ spell_command = hunspell -l
|
||||
stop_words = gibbles foobar
|
||||
stop_words_file = some/path/with/stop/words.txt
|
||||
|
||||
-The default spell command is C<aspell list> and it is interpreted as a
|
||||
+The default spell command is C<hunspell -l> and it is interpreted as a
|
||||
shell command. We parse the individual arguments via
|
||||
L<Text::ParseWords|Text::ParseWords> so feel free to use quotes around
|
||||
your arguments. If the executable path is an absolute file name, it
|
||||
@@ -358,13 +358,13 @@ together into a single list of exemptions.
|
||||
|
||||
A spell checking program is not included with Perl::Critic.
|
||||
|
||||
-The results of failures for this policy can be confusing when F<aspell>
|
||||
+The results of failures for this policy can be confusing when F<hunspell>
|
||||
complains about words containing punctuation such as hyphens and apostrophes.
|
||||
-In this situation F<aspell> will often only emit part of the word that it
|
||||
-thinks is misspelled. For example, if you ask F<aspell> to check
|
||||
+In this situation F<hunspell> will often only emit part of the word that it
|
||||
+thinks is misspelled. For example, if you ask F<hunspell> to check
|
||||
"foobie-bletch", the output only complains about "foobie". Unfortunately,
|
||||
you'll have to look through your POD to figure out what the real word that
|
||||
-F<aspell> is complaining about is. One thing to try is looking at the output
|
||||
+F<hunspell> is complaining about is. One thing to try is looking at the output
|
||||
of C<< perl -MPod::Spell -e 'print
|
||||
Pod::Spell->new()->parse_from_file("lib/Your/Module.pm")' >> to see what is
|
||||
actually being checked for spelling.
|
||||
diff --git a/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm b/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm
|
||||
index 591f1d43..9899c0f9 100644
|
||||
--- a/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm
|
||||
+++ b/lib/Perl/Critic/Policy/ErrorHandling/RequireCheckingReturnValueOfEval.pm
|
||||
@@ -299,7 +299,7 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
-=for stopwords destructors
|
||||
+=for stopwords destructors perl5
|
||||
|
||||
=head1 NAME
|
||||
|
||||
diff --git a/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm b/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm
|
||||
index bd5132d8..a8197541 100644
|
||||
--- a/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm
|
||||
+++ b/lib/Perl/Critic/Policy/Modules/RequireBarewordIncludes.pm
|
||||
@@ -46,6 +46,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords Perl4
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::Modules::RequireBarewordIncludes - Write C<require Module> instead of C<require 'Module.pm'>.
|
||||
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm
|
||||
index e47e4e10..ca9efec9 100644
|
||||
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm
|
||||
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitCaptureWithoutTest.pm
|
||||
@@ -307,6 +307,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords regexp
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::RegularExpressions::ProhibitCaptureWithoutTest - Capture variable used outside conditional.
|
||||
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm
|
||||
index 963dc53b..0b5a5459 100644
|
||||
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm
|
||||
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitComplexRegexes.pm
|
||||
@@ -99,7 +99,7 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
-=for stopwords BNF Tatsuhiko Miyagawa
|
||||
+=for stopwords BNF regexp RFC822 Tatsuhiko Miyagawa
|
||||
|
||||
=head1 NAME
|
||||
|
||||
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
|
||||
index 8821afa3..f2ca75b9 100644
|
||||
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
|
||||
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitFixedStringMatches.pm
|
||||
@@ -82,6 +82,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords regexp
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::RegularExpressions::ProhibitFixedStringMatches - Use C<eq> or hash instead of fixed-pattern regexps.
|
||||
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
|
||||
index 88c1e95e..eeecd5c8 100644
|
||||
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
|
||||
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitSingleCharAlternation.pm
|
||||
@@ -83,6 +83,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords regexp
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::RegularExpressions::ProhibitSingleCharAlternation - Use C<[abc]> instead of C<a|b|c>.
|
||||
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
|
||||
index 88760362..98363d54 100644
|
||||
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
|
||||
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusedCapture.pm
|
||||
@@ -715,7 +715,7 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
-=for stopwords refactored
|
||||
+=for stopwords refactored regexp
|
||||
|
||||
=head1 NAME
|
||||
|
||||
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
|
||||
index ddf703c3..497b5448 100644
|
||||
--- a/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
|
||||
+++ b/lib/Perl/Critic/Policy/RegularExpressions/ProhibitUnusualDelimiters.pm
|
||||
@@ -77,6 +77,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords regexp
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::RegularExpressions::ProhibitUnusualDelimiters - Use only C<//> or C<{}> to delimit regexps.
|
||||
diff --git a/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm b/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
|
||||
index ed4ffbef..b6363ef0 100644
|
||||
--- a/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
|
||||
+++ b/lib/Perl/Critic/Policy/RegularExpressions/RequireBracesForMultiline.pm
|
||||
@@ -77,6 +77,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords regexp
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::RegularExpressions::RequireBracesForMultiline - Use C<{> and C<}> to delimit multi-line regexps.
|
||||
diff --git a/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm b/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
|
||||
index 37d80063..ae5da1ec 100644
|
||||
--- a/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
|
||||
+++ b/lib/Perl/Critic/Policy/Variables/ProhibitPunctuationVars.pm
|
||||
@@ -326,6 +326,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords regexp
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Policy::Variables::ProhibitPunctuationVars - Write C<$EVAL_ERROR> instead of C<$@>.
|
||||
diff --git a/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm b/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm
|
||||
index 296bbdba..27afcc7c 100644
|
||||
--- a/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm
|
||||
+++ b/lib/Perl/Critic/Policy/Variables/RequireLexicalLoopIterators.pm
|
||||
@@ -66,7 +66,7 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
-=for stopwords foreach perlsyn
|
||||
+=for stopwords foreach perl5004delta perlsyn
|
||||
|
||||
=head1 NAME
|
||||
|
||||
diff --git a/lib/Perl/Critic/Utils.pm b/lib/Perl/Critic/Utils.pm
|
||||
index fccc823b..5806aa5b 100644
|
||||
--- a/lib/Perl/Critic/Utils.pm
|
||||
+++ b/lib/Perl/Critic/Utils.pm
|
||||
@@ -1397,6 +1397,8 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
+=for stopwords foo
|
||||
+
|
||||
=head1 NAME
|
||||
|
||||
Perl::Critic::Utils - General utility subroutines and constants for Perl::Critic and derivative distributions.
|
||||
diff --git a/lib/Perl/Critic/Utils/PPI.pm b/lib/Perl/Critic/Utils/PPI.pm
|
||||
index 38d49675..9245e3d5 100644
|
||||
--- a/lib/Perl/Critic/Utils/PPI.pm
|
||||
+++ b/lib/Perl/Critic/Utils/PPI.pm
|
||||
@@ -235,7 +235,7 @@ __END__
|
||||
|
||||
=pod
|
||||
|
||||
-=for stopwords
|
||||
+=for stopwords FOO
|
||||
|
||||
=head1 NAME
|
||||
|
||||
diff --git a/t/20_policy_pod_spelling.t b/t/20_policy_pod_spelling.t
|
||||
index 274b73d1..e9c5de4f 100644
|
||||
--- a/t/20_policy_pod_spelling.t
|
||||
+++ b/t/20_policy_pod_spelling.t
|
||||
@@ -58,10 +58,10 @@ $code = <<'END_PERL';
|
||||
=cut
|
||||
END_PERL
|
||||
|
||||
-# Sorry about the double negative. The idea is that if aspell fails (say,
|
||||
+# Sorry about the double negative. The idea is that if hunspell fails (say,
|
||||
# because it can not find the right dictionary) or pcritique returns a
|
||||
# non-zero number we want to skip. We have to negate the eval to catch the
|
||||
-# aspell failure, and then negate pcritique because we negated the eval.
|
||||
+# hunspell failure, and then negate pcritique because we negated the eval.
|
||||
# Clearer code welcome.
|
||||
if ( ! eval { ! pcritique($policy, \$code) } ) {
|
||||
skip 'Test environment is not English', $NUMBER_OF_TESTS;
|
||||
diff --git a/xt/40_perlcriticrc-code b/xt/40_perlcriticrc-code
|
||||
index 25d5a933..b488284e 100644
|
||||
--- a/xt/40_perlcriticrc-code
|
||||
+++ b/xt/40_perlcriticrc-code
|
||||
@@ -17,7 +17,7 @@ strict = 1
|
||||
[-CodeLayout::RequireTidyCode]
|
||||
|
||||
[Documentation::PodSpelling]
|
||||
-spell_command = aspell list -l en_US
|
||||
+spell_command = hunspell -l -d en_US
|
||||
stop_words_file = xt/40_stop_words
|
||||
|
||||
[Documentation::RequirePodSections]
|
||||
--
|
||||
2.21.0
|
||||
|
|
@ -1,16 +1,23 @@
|
|||
# Run author tests
|
||||
%if ! (0%{?rhel})
|
||||
%bcond_without perl_Perl_Critic_enables_extra_test
|
||||
%else
|
||||
%bcond_with perl_Perl_Critic_enables_extra_test
|
||||
%endif
|
||||
|
||||
Name: perl-Perl-Critic
|
||||
Version: 1.130
|
||||
Release: 3%{?dist}
|
||||
Version: 1.134
|
||||
Release: 5%{?dist}
|
||||
Summary: Critique Perl source code for best-practices
|
||||
License: GPL+ or Artistic
|
||||
URL: http://search.cpan.org/dist/Perl-Critic/
|
||||
Source0: http://search.cpan.org/CPAN/authors/id/P/PE/PETDANCE/Perl-Critic-%{version}.tar.gz
|
||||
URL: https://metacpan.org/release/Perl-Critic
|
||||
Source0: https://cpan.metacpan.org/modules/by-module/Perl/Perl-Critic-%{version}.tar.gz
|
||||
Patch0: 0001-Change-default-spell-check-tool-from-aspell-to-hunsp.patch
|
||||
BuildArch: noarch
|
||||
|
||||
# Build process
|
||||
BuildRequires: coreutils
|
||||
BuildRequires: findutils
|
||||
BuildRequires: make
|
||||
BuildRequires: perl-generators
|
||||
BuildRequires: perl-interpreter
|
||||
BuildRequires: perl(lib)
|
||||
|
@ -18,18 +25,16 @@ BuildRequires: perl(Module::Build) >= 0.42
|
|||
BuildRequires: perl(Task::Weaken)
|
||||
|
||||
# Module requirements
|
||||
%if ! (0%{?rhel:1})
|
||||
BuildRequires: aspell-en
|
||||
%endif
|
||||
BuildRequires: hunspell >= 1.2.12
|
||||
BuildRequires: hunspell-en
|
||||
BuildRequires: perl(B::Keywords) >= 1.05
|
||||
BuildRequires: perl(base)
|
||||
BuildRequires: perl(Carp)
|
||||
BuildRequires: perl(Config::Tiny) >= 2
|
||||
BuildRequires: perl(Email::Address) >= 1.889
|
||||
BuildRequires: perl(English)
|
||||
BuildRequires: perl(Exception::Class) >= 1.23
|
||||
BuildRequires: perl(Exporter) >= 5.58
|
||||
BuildRequires: perl(File::HomeDir)
|
||||
BuildRequires: perl(File::Find)
|
||||
BuildRequires: perl(File::Path)
|
||||
BuildRequires: perl(File::Spec)
|
||||
BuildRequires: perl(File::Spec::Unix)
|
||||
|
@ -46,19 +51,25 @@ BuildRequires: perl(Pod::PlainText)
|
|||
BuildRequires: perl(Pod::Select)
|
||||
BuildRequires: perl(Pod::Spell) >= 1
|
||||
BuildRequires: perl(Pod::Usage)
|
||||
BuildRequires: perl(PPI) >= 1.224
|
||||
BuildRequires: perl(PPI) >= 1.265
|
||||
BuildRequires: perl(PPIx::QuoteLike)
|
||||
BuildRequires: perl(PPIx::Regexp) >= 0.010
|
||||
BuildRequires: perl(PPIx::Utilities::Node)
|
||||
BuildRequires: perl(PPIx::Utilities::Statement) >= 1.001
|
||||
BuildRequires: perl(Readonly) >= 2
|
||||
BuildRequires: perl(Scalar::Util)
|
||||
BuildRequires: perl(strict)
|
||||
BuildRequires: perl(String::Format) >= 1.13
|
||||
BuildRequires: perl(Term::ANSIColor) >= 2.02
|
||||
BuildRequires: perl(Test::Builder) >= 0.92
|
||||
BuildRequires: perl(Text::ParseWords) >= 3
|
||||
BuildRequires: perl(version) >= 0.77
|
||||
BuildRequires: perl(warnings)
|
||||
|
||||
# Main test suite
|
||||
%if 0%{?fedora} > 23 || 0%{?rhel} > 7
|
||||
BuildRequires: glibc-langpack-en
|
||||
%endif
|
||||
BuildRequires: perl(Fatal)
|
||||
BuildRequires: perl(File::Spec::Functions)
|
||||
BuildRequires: perl(Test::Deep)
|
||||
|
@ -67,14 +78,12 @@ BuildRequires: perl(Test::More)
|
|||
|
||||
# We don't run the author tests when bootstrapping due to circular dependencies
|
||||
# Test::Perl::Critic obviously pulls in Perl::Critic too
|
||||
%if 0%{!?perl_bootstrap:1}
|
||||
%if 0%{!?perl_bootstrap:1} && %{with perl_Perl_Critic_enables_extra_test}
|
||||
BuildRequires: perl(Devel::EnforceEncapsulation)
|
||||
BuildRequires: perl(Perl::Critic::Policy::Editor::RequireEmacsFileVariables)
|
||||
BuildRequires: perl(Perl::Critic::Policy::ErrorHandling::RequireUseOfExceptions)
|
||||
BuildRequires: perl(Perl::Critic::Policy::Miscellanea::RequireRcsKeywords)
|
||||
%if ! (0%{?rhel:1})
|
||||
BuildRequires: perl(Test::Kwalitee) >= 1.15
|
||||
%endif
|
||||
BuildRequires: perl(Test::Perl::Critic)
|
||||
BuildRequires: perl(Test::Pod) >= 1.00
|
||||
BuildRequires: perl(Test::Pod::Coverage) >= 1.04
|
||||
|
@ -83,14 +92,11 @@ BuildRequires: perl(Test::Without::Module)
|
|||
|
||||
# Optional/not automatically detected runtime dependencies
|
||||
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
|
||||
%if ! (0%{?rhel:1})
|
||||
Requires: aspell
|
||||
%endif
|
||||
Requires: perl(File::HomeDir)
|
||||
Requires: hunspell >= 1.2.12
|
||||
Requires: perl(File::Which)
|
||||
Requires: perl(Module::Pluggable) >= 3.1
|
||||
Requires: perl(Pod::Parser)
|
||||
Requires: perl(PPI) >= 1.224
|
||||
Requires: perl(PPI) >= 1.265
|
||||
Requires: perl(Term::ANSIColor) >= 2.02
|
||||
|
||||
%description
|
||||
|
@ -118,6 +124,9 @@ of Perl code were mixed directly in the test script. That sucked.
|
|||
%prep
|
||||
%setup -q -n Perl-Critic-%{version}
|
||||
|
||||
# Switch spell checker tool from aspell to hunspell
|
||||
%patch0 -p1
|
||||
|
||||
# Drop exec bits from samples/docs to avoid dependency bloat
|
||||
find tools examples -type f -exec chmod -c -x {} ';'
|
||||
|
||||
|
@ -130,7 +139,11 @@ perl Build.PL --installdirs=vendor
|
|||
%{_fixperms} -c %{buildroot}
|
||||
|
||||
%check
|
||||
LC_ALL=en_US ./Build %{!?perl_bootstrap:author}test
|
||||
%if 0%{!?perl_bootstrap:1} && %{with perl_Perl_Critic_enables_extra_test}
|
||||
LC_ALL=en_US ./Build authortest
|
||||
%else
|
||||
LC_ALL=en_US ./Build test
|
||||
%endif
|
||||
|
||||
%files
|
||||
%if 0%{?_licensedir:1}
|
||||
|
@ -138,7 +151,7 @@ LC_ALL=en_US ./Build %{!?perl_bootstrap:author}test
|
|||
%else
|
||||
%doc LICENSE
|
||||
%endif
|
||||
%doc Changes README TODO.pod examples/ extras/ tools/
|
||||
%doc Changes CONTRIBUTING.md README TODO.pod examples/ extras/ tools/
|
||||
%{_bindir}/perlcritic
|
||||
%{perl_vendorlib}/Perl/
|
||||
%{_mandir}/man1/perlcritic.1*
|
||||
|
@ -149,6 +162,82 @@ LC_ALL=en_US ./Build %{!?perl_bootstrap:author}test
|
|||
%{_mandir}/man3/Test::Perl::Critic::Policy.3*
|
||||
|
||||
%changelog
|
||||
* Thu Sep 5 2019 Paul Howarth <paul@city-fan.org> - 1.134-5
|
||||
- Do not run extra tests on RHEL
|
||||
|
||||
* Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.134-4
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
|
||||
|
||||
* Sun Jun 02 2019 Jitka Plesnikova <jplesnik@redhat.com> - 1.134-3
|
||||
- Perl 5.30 re-rebuild of bootstrapped packages
|
||||
|
||||
* Fri May 31 2019 Jitka Plesnikova <jplesnik@redhat.com> - 1.134-2
|
||||
- Perl 5.30 rebuild
|
||||
|
||||
* Thu May 23 2019 Paul Howarth <paul@city-fan.org> - 1.134-1
|
||||
- Update to 1.134
|
||||
New Features
|
||||
- Added new policy BuiltinFunctions::ProhibitShiftRef (GH#837)
|
||||
- Support indented heredocs (GH#861)
|
||||
- In Subroutines::ProhibitManyArgs, you can now omit the object variable
|
||||
(C<$self> or C<$class>) from the argument count (GH#815)
|
||||
Policy Changes
|
||||
- The policy Documentation::RequirePodLinksIncludeText is obsolete and has
|
||||
been removed (GH#494)
|
||||
Dependencies
|
||||
- Removed use of File::HomeDir
|
||||
- Upgrade to PPI 1.265 (GH#860)
|
||||
- Fix failed tests caused by new PPI (GH#858)
|
||||
Internals
|
||||
- Updated the Appveyor config (GH#851)
|
||||
|
||||
* Mon Apr 29 2019 Paul Howarth <paul@city-fan.org> - 1.132-8
|
||||
- Add workaround for PPI ≥ 1.262
|
||||
|
||||
* Fri Apr 26 2019 Paul Howarth <paul@city-fan.org> - 1.132-7
|
||||
- Add workaround for PPI ≥ 1.250
|
||||
https://github.com/Perl-Critic/Perl-Critic/issues/858
|
||||
|
||||
* Fri Feb 01 2019 Fedora Release Engineering <releng@fedoraproject.org> - 1.132-6
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
|
||||
|
||||
* Tue Nov 6 2018 Paul Howarth <paul@city-fan.org> - 1.132-5
|
||||
- Explicitly BR: glibc-langpack-en
|
||||
|
||||
* Fri Jul 13 2018 Fedora Release Engineering <releng@fedoraproject.org> - 1.132-4
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
|
||||
|
||||
* Sun Jul 01 2018 Jitka Plesnikova <jplesnik@redhat.com> - 1.132-3
|
||||
- Perl 5.28 re-rebuild of bootstrapped packages
|
||||
|
||||
* Fri Jun 29 2018 Jitka Plesnikova <jplesnik@redhat.com> - 1.132-2
|
||||
- Perl 5.28 rebuild
|
||||
|
||||
* Fri Jun 1 2018 Paul Howarth <paul@city-fan.org> - 1.132-1
|
||||
- Update to 1.132
|
||||
New Features
|
||||
- In the ProhibitLeadingZeros policy, added an exception for mkfifo (GH#786)
|
||||
- Add colour support for Windows platforms (GH#700)
|
||||
- Perl::Critic now assumes that .psgi files are Perl, too (GH#805)
|
||||
- Variables::ProhibitUnusedVariables no longer gives a false positive for
|
||||
variables used in interpolation (GH#801)
|
||||
- Added the ability to specify a regex to tell what unused private
|
||||
subroutines are OK in Subroutines::ProhibitUnusedPrivateSubroutines; this
|
||||
is handy for Moose classes where there could be many false positives on
|
||||
_build_xxxx() subroutines (GH#811, GH#812)
|
||||
Dependencies
|
||||
- Perl::Critic now no longer relies on the deprecated Email::Address
|
||||
(GH #816)
|
||||
Bug Fixes
|
||||
- Recode Perl::Critic::Utils::all_perl_files() to use File::Find instead of
|
||||
opendir/readdir; this solves endless directory traversals if the
|
||||
directories contain circular symbolic references
|
||||
- Added missing requirement for Fatal.pm
|
||||
Documentation
|
||||
- Added CONTRIBUTING.md
|
||||
- Switch upstream from search.cpan.org to metacpan.org
|
||||
- Switch spell checker from aspell to hunspell
|
||||
|
||||
* Fri Feb 09 2018 Fedora Release Engineering <releng@fedoraproject.org> - 1.130-3
|
||||
- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
|
||||
|
||||
|
|
2
sources
2
sources
|
@ -1 +1 @@
|
|||
SHA512 (Perl-Critic-1.130.tar.gz) = b443ddbb5905a61835061f49d7f10e2e71579e5df96778eb183c3d1e9987342e1536db61196b32e66a192c92916eafd9ebb7b713b0be71ce89c1f93155e89828
|
||||
SHA512 (Perl-Critic-1.134.tar.gz) = 73d3fd891e055aec5dd38680696ae30f6662d0906baeea878f393adb96e34079e561cd4c3dad00f0c84c7d3a72f3119b2f8ef0c0a1601aaccc8456f1c0039b7a
|
||||
|
|
Loading…
Reference in New Issue