Spec tidy-up

- Use author-independent source URL
- Classify buildreqs by usage
- Fix permissions verbosely
- Drop redundant buildroot cleaning in %install section
- Simplify find command using -delete
- Make %files list more explicit

perl-Crypt-CBC.rpmlintrc

@@ -0,0 +1,2 @@
+from Config import *
+addFilter("spelling-error %description -l en_US decrypt -> ")

perl-Crypt-CBC.spec

@@ -1,31 +1,45 @@
-Summary: Encrypt Data with Cipher Block Chaining Mode
-Name: perl-Crypt-CBC
-Version: 2.33
-Release: 24%{?dist}
+Summary:        Encrypt Data with Cipher Block Chaining Mode
+Name:           perl-Crypt-CBC
+Version:        2.33
+Release:        25%{?dist}
 # Upstream confirms that they're under the same license as perl.
 # Wording in CBC.pm is less than clear, but still.
-License: GPL+ or Artistic
-URL: https://metacpan.org/release/Crypt-CBC
-Source0: https://cpan.metacpan.org/authors/id/L/LD/LDS/Crypt-CBC-%{version}.tar.gz
-BuildArch: noarch
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
-BuildRequires: perl-generators
-BuildRequires: perl(bytes)
-BuildRequires: perl(constant)
-BuildRequires: perl(Digest::MD5) >= 2.00
-BuildRequires: perl(ExtUtils::MakeMaker)
+License:        GPL+ or Artistic
+URL:            https://metacpan.org/release/Crypt-CBC
+Source0:        https://cpan.metacpan.org/modules/by-module/Crypt/Crypt-CBC-%{version}.tar.gz
+BuildArch:      noarch
+# Build:
+BuildRequires:  coreutils
+BuildRequires:  findutils
+BuildRequires:  make
+BuildRequires:  perl-generators
+BuildRequires:  perl-interpreter
+BuildRequires:  perl(ExtUtils::MakeMaker)
+# Runtime
+BuildRequires:  perl(bytes)
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(constant)
+BuildRequires:  perl(Digest::MD5) >= 2.00
+BuildRequires:  perl(Scalar::Util)
+BuildRequires:  perl(strict)
+BuildRequires:  perl(vars)
+# Test Suite
+BuildRequires:  perl(lib)
+# Optional Tests
 # Modules used for test suite, skipped when bootstrapping as
 # some of these modules use Crypt::CBC themselves
+%if 0%{!?perl_bootstrap:1} && ! (0%{?rhel} >= 7)
 # Crypt::CAST5 not yet packaged in Fedora
-# Crypt::IDEA is unavailable due to patents
-%if 0%{!?perl_bootstrap:1}
-BuildRequires: perl(Crypt::DES)
-%if ! (0%{?rhel} >= 7)
-BuildRequires: perl(Crypt::Blowfish)
-BuildRequires: perl(Crypt::Blowfish_PP)
-BuildRequires: perl(Crypt::Rijndael)
-%endif
+BuildRequires:  perl(Crypt::DES)
+BuildRequires:  perl(Crypt::Blowfish)
+BuildRequires:  perl(Crypt::Blowfish_PP)
+BuildRequires:  perl(Crypt::Rijndael)
 %endif
+# Crypt::IDEA doesn't need bootstrapping and we get extra test coverage by including it
+BuildRequires:  perl(Crypt::IDEA)
+# Dependencies
+Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
+Requires:       perl(Scalar::Util)
 
 %description
 This is Crypt::CBC, a Perl-only implementation of the cryptographic
@@ -36,17 +50,16 @@ compatible with the encryption format used by SSLeay.
 
 %prep
 %setup -q -n Crypt-CBC-%{version}
-chmod 644 eg/*.pl
+chmod -c 644 eg/*.pl
 
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make
 
 %install
-rm -rf $RPM_BUILD_ROOT
-make pure_install DESTDIR=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-%{_fixperms} $RPM_BUILD_ROOT
+make pure_install DESTDIR=%{buildroot}
+find %{buildroot} -type f -name .packlist -delete
+%{_fixperms} -c %{buildroot}
 
 %check
 make test
@@ -54,9 +67,18 @@ make test
 %files
 %doc Changes README eg/
 %{perl_vendorlib}/Crypt/
-%{_mandir}/man3/*.3*
+%{_mandir}/man3/Crypt::CBC.3*
 
 %changelog
+* Tue Oct 15 2019 Paul Howarth <paul@city-fan.org> - 2.33-25
+- Spec tidy-up
+  - Use author-independent source URL
+  - Classify buildreqs by usage
+  - Fix permissions verbosely
+  - Drop redundant buildroot cleaning in %%install section
+  - Simplify find command using -delete
+  - Make %%files list more explicit
+
 * Fri Jul 26 2019 Fedora Release Engineering <releng@fedoraproject.org> - 2.33-24
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild