From e3268241d72812624270cb87e6cdb14a001f1a0e Mon Sep 17 00:00:00 2001 From: Jan Kurik Date: Thu, 8 Apr 2021 08:42:10 +0200 Subject: [PATCH] Compliance with python's FPG test --- tests/Sanity/pcp-python-compliance/Makefile | 63 +++++++++++++++++ tests/Sanity/pcp-python-compliance/PURPOSE | 3 + tests/Sanity/pcp-python-compliance/main.fmf | 13 ++++ tests/Sanity/pcp-python-compliance/runtest.sh | 69 +++++++++++++++++++ 4 files changed, 148 insertions(+) create mode 100644 tests/Sanity/pcp-python-compliance/Makefile create mode 100644 tests/Sanity/pcp-python-compliance/PURPOSE create mode 100644 tests/Sanity/pcp-python-compliance/main.fmf create mode 100755 tests/Sanity/pcp-python-compliance/runtest.sh diff --git a/tests/Sanity/pcp-python-compliance/Makefile b/tests/Sanity/pcp-python-compliance/Makefile new file mode 100644 index 0000000..17cc220 --- /dev/null +++ b/tests/Sanity/pcp-python-compliance/Makefile @@ -0,0 +1,63 @@ +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Makefile of /tools/pcp/Sanity/pcp-python-compliance +# Description: Check for a compliance with Fedora Packaging Guidelines +# Author: Jan Kuřík +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2020 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +export TEST=/tools/pcp/Sanity/pcp-python-compliance +export TESTVERSION=1.0 + +BUILT_FILES= + +FILES=$(METADATA) runtest.sh Makefile PURPOSE + +.PHONY: all install download clean + +run: $(FILES) build + ./runtest.sh + +build: $(BUILT_FILES) + test -x runtest.sh || chmod a+x runtest.sh + +clean: + rm -f *~ $(BUILT_FILES) + + +include /usr/share/rhts/lib/rhts-make.include + +$(METADATA): Makefile + @echo "Owner: Jan Kuřík " > $(METADATA) + @echo "Name: $(TEST)" >> $(METADATA) + @echo "TestVersion: $(TESTVERSION)" >> $(METADATA) + @echo "Path: $(TEST_DIR)" >> $(METADATA) + @echo "Description: Check for a compliance with Fedora Packaging Guidelines" >> $(METADATA) + @echo "Type: Sanity" >> $(METADATA) + @echo "TestTime: 15m" >> $(METADATA) + @echo "RunFor: pcp" >> $(METADATA) + @echo "Requires: python3-pcp python-pcp" >> $(METADATA) + @echo "Priority: Normal" >> $(METADATA) + @echo "License: GPLv2+" >> $(METADATA) + @echo "Confidential: no" >> $(METADATA) + @echo "Destructive: no" >> $(METADATA) + @echo "Releases: -RHEL4 -RHELClient5 -RHELServer5" >> $(METADATA) + + rhts-lint $(METADATA) diff --git a/tests/Sanity/pcp-python-compliance/PURPOSE b/tests/Sanity/pcp-python-compliance/PURPOSE new file mode 100644 index 0000000..1f9ab7f --- /dev/null +++ b/tests/Sanity/pcp-python-compliance/PURPOSE @@ -0,0 +1,3 @@ +PURPOSE of /tools/pcp/Sanity/pcp-python-compliance +Description: Check for a compliance with Fedora Packaging Guidelines +Author: Jan Kuřík diff --git a/tests/Sanity/pcp-python-compliance/main.fmf b/tests/Sanity/pcp-python-compliance/main.fmf new file mode 100644 index 0000000..87bd429 --- /dev/null +++ b/tests/Sanity/pcp-python-compliance/main.fmf @@ -0,0 +1,13 @@ +summary: Check for a compliance with Fedora Packaging Guidelines +description: '' +contact: Jan Kuřík +component: +- pcp +test: ./runtest.sh +framework: beakerlib +recommend: +- python3-pcp +- python-pcp +duration: 15m +extra-summary: /tools/pcp/Sanity/pcp-python-compliance +extra-task: /tools/pcp/Sanity/pcp-python-compliance diff --git a/tests/Sanity/pcp-python-compliance/runtest.sh b/tests/Sanity/pcp-python-compliance/runtest.sh new file mode 100755 index 0000000..889570d --- /dev/null +++ b/tests/Sanity/pcp-python-compliance/runtest.sh @@ -0,0 +1,69 @@ +#!/bin/bash +# vim: dict+=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# runtest.sh of /tools/pcp/Sanity/pcp-python-compliance +# Description: Check for a compliance with Fedora Packaging Guidelines +# Author: Jan Kuřík +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +# +# Copyright (c) 2020 Red Hat, Inc. +# +# This program is free software: you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation, either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be +# useful, but WITHOUT ANY WARRANTY; without even the implied +# warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR +# PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see http://www.gnu.org/licenses/. +# +# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +# Include Beaker environment +. /usr/share/beakerlib/beakerlib.sh || exit 1 + +PACKAGE="pcp" +PYPACKAGE="$(rpm -q --qf '%{name}\n' python3-pcp python-pcp 2>/dev/null | grep '^python')" + +rlJournalStart + rlPhaseStartSetup + rlLog "Compliance with Fedora Packaging Guidelines test" + rlLog "Check https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/" + rlAssertRpm ${PACKAGE} + rlAssertRpm ${PYPACKAGE} + rlRun "TmpDir=\$(mktemp -d)" 0 "Creating tmp directory" + rlRun "pushd $TmpDir" + rlPhaseEnd + + rlPhaseStartTest "Check for *.pyc files" + rlRun "rpm -ql ${PYPACKAGE} > filelist.list" + while read f; do + if [[ ${f##*.} == "py" ]]; then + rlLog "Checking PYC file for $f" + BASE=$(basename $f) + DIR=$(dirname $f) + if [[ "${PYPACKAGE%%-*}" == "python3" ]]; then + rlAssertGrep "${DIR}/__pycache__/${BASE%.*}\..*\.pyc" filelist.list -E + else + rlAssertGrep "${DIR}/${BASE%.*}.*\.pyc" filelist.list -E + fi + fi + done < "filelist.list" + rlPhaseEnd + + rlPhaseStartTest "Check for egg-info files" + rlAssertGrep "/${PACKAGE}-.*\.egg-info" filelist.list -E + rlPhaseEnd + + rlPhaseStartCleanup + rlRun "popd" + rlRun "rm -r $TmpDir" 0 "Removing tmp directory" + rlPhaseEnd +rlJournalPrintText +rlJournalEnd