Fix syntax error in specfile and sync. up with what's under review

This commit is contained in:
Elio Maldonado 2016-06-15 08:41:56 -07:00
parent e31a061409
commit 50d1896848
2 changed files with 26 additions and 47 deletions

View File

@ -98,17 +98,19 @@ Patch49: nss-skip-bltest-and-fipstest.patch
Patch50: iquote.patch
# Local patch for TLS_ECDHE_{ECDSA|RSA}_WITH_3DES_EDE_CBC_SHA ciphers
Patch58: rhbz1185708-enable-ecc-3des-ciphers-by-default.patch
# TODO: file a bug usptream
# Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1279520
Patch59: nss-check-policy-file.patch
# Remove it when we rebase to nss-pem upstream that has the fix
Patch60: nss-pem-unitialized-vars.path
# Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1277569
Patch61: mozbz1277569backport.patch
# Upstream: https://git.fedorahosted.org/cgit/nss-pem.git/commit/
# TODO: file a bug usptream
# Upstream commit that caused problems with gtests
# https://git.fedorahosted.org/cgit/nss-pem.git/commit/
Patch62: nss-skip-util-gtest.patch
# TODO: file a bug usptream when enough tests are run
# Upstream: https://bugzilla.mozilla.org/show_bug.cgi?id=1279520
Patch63: tests-check-policy-file.patch
# TODO: Under test and could me merged with nss-check-policy-file.patch
# TODO: Under test and could be merged with nss-check-policy-file.patch
Patch64: nss-conditionally-ignore-system-policy.patch
%description
@ -319,7 +321,6 @@ export POLICY_PATH="/etc/crypto-policies/back-ends"
# to keep nss from loading the policy file
%if %{nss_ignore_system_policy}
# when set nss will skip loading policy file.
export NSS_IGNORE_SYSTEM_POLICY=1
%endif
@ -438,24 +439,16 @@ export NSS_IGNORE_SYSTEM_POLICY=1
# ****************************************************************
# Patching the test data here is more upstream friendly and
# eventually could be incorporated into what ssl.sh init does.
if [ ${NSS_IGNORE_SYSTEM_POLICY:-0} -eq 1 ]; then
echo "testing with system crypto policy ignored"
# eventually should be incorporated into what ssl.sh init does.
%if %{nss_ignore_system_policy}
# no need to patch the test data
else
echo "testing with system crypto policy enforced"
# expected results on some sslauth tests depend on
# whether the system crypto policy is being enforced or not.
%else
# expected results on some sslauth tests depend on whether
# the system crypto policy is being enforced or not.
pushd nss
patch -p1 < %{SOURCE28}
popd
fi
pushd nss/tests/ssl
# Create versions of sslcov.txt and sslstress.txt that disable
# tests for non policy compliant ciphers.
cat sslcov.txt| sed -r "s/^([^#].*EXPORT|^[^#].*_WITH_DES_*)/#disabled \1/" > sslcov.noPolicy.txt
cat sslstress.txt| sed -r "s/^([^#].*EXPORT|^[^#].*with MD5)/#disabled \1/" > sslstress.noPolicy.txt
popd
%endif
# ****************************************************************
# enable the following line to force a test failure
@ -499,7 +492,8 @@ pushd ./nss/tests/
# don't need to run all the tests when testing packaging
# nss_cycles: standard pkix upgradedb sharedb
%define nss_tests "libpkix cert dbtests tools fips sdr crmf smime ssl ocsp merge pkits chains"
# TODO: Add ssl_gtests when we rebase to nss-3.25
%define nss_tests "libpkix cert dbtests tools fips sdr crmf smime ssl ocsp merge pkits chains pk11_gtests der_gtests"
# nss_ssl_tests: crl bypass_normal normal_bypass normal_fips fips_normal iopr
# nss_ssl_run: cov auth stress
#
@ -846,7 +840,7 @@ fi
%changelog
* Thu Jun 09 2016 Elio Maldonado <emaldona@redhat.com> - 3.24.0-2.4
* Wed Jun 15 2016 Elio Maldonado <emaldona@redhat.com> - 3.24.0-2.4
- Add support for conditionally ignoring the system policy
* Fri Jun 03 2016 Elio Maldonado <emaldona@redhat.com> - 3.24.0-2.3

View File

@ -1,6 +1,6 @@
--- ./tests/ssl/ssl.sh.check_policy 2016-05-17 00:58:45.000000000 -0700
+++ ./tests/ssl/ssl.sh 2016-06-07 18:50:58.916987315 -0700
@@ -56,20 +56,36 @@
+++ ./tests/ssl/ssl.sh 2016-06-10 10:06:40.715661079 -0700
@@ -56,16 +56,24 @@
}
fi
@ -14,33 +14,18 @@
+ : ""
+ # Means that will use test data that compliant with policy
+ # and will invoke selfserv nd tstclnt with the proper range
+ ADJUST_FOR_POLICY=[ -n "${NSS_POLICY_FILE}" ] && \
+ [ -n "${NSS_IGNORE_SYSTEM_POLICY}" ] && \
+ [ "${NSS_IGNORE_SYSTEM_POLICY}" == "1" ] \
+ ADJUST_FOR_POLICY=[ -n "${NSS_POLICY_FILE}" -a -z "${NSS_IGNORE_SYSTEM_POLICY}" ] \
+ ? "1" \
+ : ""
# Test case files
- SSLCOV=${QADIR}/ssl/sslcov.txt
- SSLAUTH=${QADIR}/ssl/sslauth.txt
- SSLSTRESS=${QADIR}/ssl/sslstress.txt
+ if [ -n "${ADJUST_FOR_POLICY}" ]; then
+ SSLAUTH=${QADIR}/ssl/sslauth.noPolicy.txt
+ SSLCOV=${QADIR}/ssl/sslcov.noPolicy.txt
+ SSLSTRESS=${QADIR}/ssl/sslstress.noPolicy.txt
+ else
+ SSLAUTH=${QADIR}/ssl/sslauth.txt
+ SSLCOV=${QADIR}/ssl/sslcov.txt
+ SSLSTRESS=${QADIR}/ssl/sslstress.txt
+ fi
SSLCOV=${QADIR}/ssl/sslcov.txt
SSLAUTH=${QADIR}/ssl/sslauth.txt
SSLSTRESS=${QADIR}/ssl/sslstress.txt
SSLPOLICY=${QADIR}/ssl/sslpolicy.txt
REQUEST_FILE=${QADIR}/ssl/sslreq.dat
#temparary files
SERVEROUTFILE=${TMP}/tests_server.$$
SERVERPID=${TMP}/tests_pid.$$
R_SERVERPID=../tests_pid.$$
@@ -117,17 +133,21 @@
@@ -117,17 +125,21 @@
if [ "${OS_ARCH}" = "WINNT" ] && \
[ "$OS_NAME" = "CYGWIN_NT" -o "$OS_NAME" = "MINGW32_NT" ]; then
PID=${SHELL_SERVERPID}
@ -62,7 +47,7 @@
# local shell function to wait until selfserver is running and initialized
########################################################################
wait_for_selfserv()
@@ -140,17 +160,21 @@
@@ -140,17 +152,21 @@
if [ $? -ne 0 ]; then
sleep 5
echo "retrying to connect to selfserv at `date`"
@ -84,7 +69,7 @@
########################### kill_selfserv ##############################
# local shell function to kill the selfserver after the tests are done
########################################################################
@@ -208,28 +232,35 @@
@@ -208,28 +224,35 @@
[ -z "$NO_ECC_CERTS" -o "$NO_ECC_CERTS" != "1" ] ; then
ECC_OPTIONS="-e ${HOSTADDR}-ec"
else
@ -123,7 +108,7 @@
# process (sh.exe). MKS's kill command has a bug: invoking kill
# on the helper process does not terminate the real background
# process. Our workaround has been to have selfserv save its PID
@@ -270,16 +301,21 @@
@@ -270,16 +293,21 @@
VMAX="tls1.1"
exec < ${SSLCOV}
@ -134,7 +119,7 @@
+ # trace these types of tests when build has policy enabled
+ if [ -n "${ADJUST_FOR_POLICY}" ] && [ ${EXP} -eq 0 ]; then
+ echo "$testname has legay ciphers"
+ echo "$testname has legacy ciphers"
+ fi
+
if [ "$ectype" = "ECC" -a -n "$NSS_DISABLE_ECC" ] ; then