Remove some obsolete or dangerous configure options by

the request from the upstream (and ref: bug 1666505)

20190112-memo-build-options-from-upstream.txt

@@ -0,0 +1,41 @@
+2019/01/12 17:24 From Holger Vogt <holger.vogt@uni-due.de>
+
+Dear Mamoru,
+
+a KiCad user has reported a bug
+(https://forum.kicad.info/t/trying-to-get-ngspice-working-on-fedora/14628/9)
+concerning strange debug output from ngspice shared lib.
+
+I have ahd a look at the Fedora log protocol
+(https://koji.fedoraproject.org/koji/taskinfo?taskID=31757152) and
+https://kojipkgs.fedoraproject.org//work/tasks/7152/31757152/build.log
+
+ngspice shared lib has been made with the following configure flags:
+--disable-silent-rules --disable-xgraph --enable-adms --enable-xspice
+--enable-maintainer-mode --enable-dependency-tracking
+--enable-capzerobypass --enable-cider --enable-expdevices
+--enable-intnoise --enable-openmp --enable-predictor --enable-numparam
+--enable-dot-global --enable-shared --enable-ndev --with-readline=yes
+--with-tcl=/usr/lib64/ --libdir=/usr/lib64/tclspice --enable-oldapps
+
+This is wrong.
+
+For making ngspice-30, do not use
+--disable-xgraph (xgraph is no longer part of the ngspice distribution)
+--enable-capzerobypass (no longer available)
+--enable-expdevices (not used, experimental devices may destroy the code
+stability)
+--enable-numparam (numparam is always enabled)
+--enable-ndev (this is causing the bug: unmaintained code, risky, does
+lead to spurious ngspice outputs. Has definitely to be removed!)
+--with-readline=yes (there is no use of readline in a shared lib, but
+probably does not hurt here)
+--enable-intnoise (flag is no longer available)
+--enable-dot-global (flag is no longer available)
+
+May I ask you to redo the build with a suitable set of configure flags?
+
+Best regards
+
+Holger
+

ngspice.spec

@@ -22,7 +22,7 @@ Version:		30
 %if %{?devel}
 %global snap	.20111129cvs
 %endif
-Release:		1%{?snap}%{?dist}
+Release:		2%{?snap}%{?dist}
 Summary:		A mixed level/signal circuit simulator
 
 License:		BSD
@@ -207,26 +207,22 @@ export CPPFLAGS=-DUSE_INTERP_RESULT
 # comment by Mamoru TASAKA (20170330)
 # Looking at the actually source code, --enable-newpred does not seem to
 # make sense, and it seems to cause calculation error (bug 844100, bug 1429130)
+#
+# (20190120) Remove some obsolete or dangerous configure option
+# by the request from the upstream
 %configure \
 	--disable-silent-rules \
-	--disable-xgraph \
 	--enable-adms \
 	--enable-xspice \
 	--enable-maintainer-mode \
 	--enable-dependency-tracking \
-	--enable-capzerobypass \
 	--enable-cider \
 %if 0
 	--enable-newpred \
 %endif
-	--enable-expdevices \
-	--enable-intnoise \
 	--enable-openmp \
 	--enable-predictor \
-	--enable-numparam \
-	--enable-dot-global \
 	--enable-shared \
-	--enable-ndev \
 	--with-readline=yes \
 	--with-tcl=%{_libdir}/ \
 	--libdir=%{_libdir}/tclspice \
@@ -245,24 +241,18 @@ do
 %configure \
 	--disable-silent-rules \
 	--${opt} \
-	--disable-xgraph \
 	--enable-adms \
 	--enable-xspice \
 	--enable-maintainer-mode \
 	--enable-dependency-tracking \
-	--enable-capzerobypass \
 	--enable-cider \
 %if 0
+	# bug 844100, bug 1429130
 	--enable-newpred \
 %endif
-	--enable-expdevices \
-	--enable-intnoise \
 	--enable-openmp \
 	--enable-predictor \
-	--enable-numparam \
-	--enable-dot-global \
 	--enable-shared \
-	--enable-ndev \
 	--with-readline=yes \
 	--libdir=%{_libdir} \
 	--enable-oldapps \
@@ -380,6 +370,10 @@ cd tests
 %{_includedir}/ngspice/
 
 %changelog
+* Sun Jan 20 2019 Mamoru TASAKA <mtasaka@fedoraproject.org> - 30-2
+- Remove some obsolete or dangerous configure options by
+  the request from the upstream (and ref: bug 1666505)
+
 * Tue Jan  1 2019 Mamoru TASAKA <mtasaka@fedoraproject.org> - 30-1
 - Update to 30