Go to file
Coiby Xu df6f25ff20 Tell nmcli to not escape colon when getting the path of connection profile
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2151504

When a NetworManager connection profile contains a colon in the name,
"nmcli --get-values UUID,FILENAME" by default would escape the colon
because a colon is also used for separating the values. In this case,
99kdumpbase fails to get the correct connection profile path,
	kdumpctl[5439]: cp: cannot stat '/run/NetworkManager/system-connections/static-52\\\:54\\\:01.nmconnection': No such file or directory
	kdumpctl[5440]: sed: can't read /tmp/1977-DRACUT_KDUMP_NM/ifcfg-static-52-54-01: No such file or directory
	kdumpctl[5449]: dracut-install: ERROR: installing '/tmp/1977-DRACUT_KDUMP_NM/ifcfg-static-52-54-01' to '/etc/NetworkManager/system-connections/ifcfg-static-52-54-01'

As a result, dumping vmcore to a remote nfs would fail.

In our case of getting connection profile path, there is no need to escape the
colon so pass "-escape no" to nmcli,

	[root@localhost ~]# nmcli --get-values UUID,FILENAME c show
	659e09c1-a6bd-3549-9be4-a07a1a9a8ffd:/etc/NetworkManager/system-connections/aa\:bb.nmconnection

	[root@localhost ~]# nmcli -escape no --get-values UUID,FILENAME c show
	659e09c1-a6bd-3549-9be4-a07a1a9a8ffd:/etc/NetworkManager/system-connections/aa:bb.nmconnection

Suggested-by: Beniamino Galvani <bgalvani@redhat.com>
Reported-by: Martin Pitt <mpitt@redhat.com>
Signed-off-by: Coiby Xu <coxu@redhat.com>
Reviewed-by: Philipp Rudo <prudo@redhat.com>
2023-04-14 20:22:49 +08:00
spec unit tests: add tests for prepare_cmdline 2023-01-30 17:37:23 +08:00
tests tests: use .nmconnection to set up test network 2022-11-09 14:07:29 +08:00
.editorconfig dracut-early-kdump: explicitly use bash 2023-01-30 17:37:23 +08:00
.gitignore
.shellspec
60-fadump.install fadump: add a kernel install hook to clean up fadump initramfs 2022-12-07 09:42:29 +08:00
60-kdump.install
92-crashkernel.install Prefix reset-crashkernel-{for-installed_kernel,after-update} with underscore 2022-10-20 13:54:10 +08:00
98-kexec.rules
98-kexec.rules.ppc64
crashkernel-howto.txt remind the users to run zipl after calling grubby on s390x 2022-08-03 11:09:55 +08:00
dracut-early-kdump-module-setup.sh
dracut-early-kdump.sh kdumpctl: merge check_current_{kdump,fadump}_status 2023-01-30 17:37:23 +08:00
dracut-fadump-init-fadump.sh
dracut-fadump-module-setup.sh
dracut-kdump-capture.service
dracut-kdump-emergency.service
dracut-kdump-emergency.target
dracut-kdump.sh Wait for the network to be truly ready before dumping vmcore 2022-11-23 06:39:27 +08:00
dracut-module-setup.sh Tell nmcli to not escape colon when getting the path of connection profile 2023-04-14 20:22:49 +08:00
dracut-monitor_dd_progress
early-kdump-howto.txt
fadump-howto.txt update fadump-howto 2022-04-24 09:35:05 +08:00
gen-kdump-conf.sh kdump.conf: use a simple generator script to maintain 2022-11-25 17:16:09 +08:00
gen-kdump-sysconfig.sh sysconfig: add zfcp.allow_lun_scan to KDUMP_COMMANDLINE_REMOVE on s390 2023-03-13 15:30:00 +08:00
kdump-dep-generator.sh
kdump-in-cluster-environment.txt Add fence_kdump support for generic clusters 2014-04-03 14:43:06 +08:00
kdump-lib-initramfs.sh Address the cases where a NIC has a different name in kdump kernel 2022-11-23 06:39:27 +08:00
kdump-lib.sh kdump-lib: fix prepare_cmdline 2023-01-30 17:37:23 +08:00
kdump-logger.sh
kdump-migrate-action.sh
kdump-restart.sh
kdump-udev-throttler
kdump.conf.5
kdump.service
kdumpctl kdumpctl: lower the log level in reset_crashkernel_for_installed_kernel 2023-04-10 12:20:15 +08:00
kdumpctl.8
kexec-kdump-howto.txt update kexec-kdump-howto 2022-04-24 09:35:05 +08:00
kexec-tools-2.0.23-s390_handle_R_390_PLT32DBL_reloc_entries_in_machine_apply_elf_rel_.patch
kexec-tools-2.0.26-makedumpfile-Fix-wrong-exclusion-of-slab-pages-on-Linux-6.2.patch makedumpfile: Fix wrong exclusion of slab pages on Linux 6.2-rc1 2023-01-30 17:37:23 +08:00
kexec-tools.spec Release 2.0.26-3 2023-01-30 17:39:35 +08:00
live-image-kdump-howto.txt
mkdumprd Install nfsv4-related drivers when users specify nfs dumping via dracut_args 2023-03-21 15:55:57 +08:00
mkdumprd.8
mkfadumprd mkfadumprd: drop unset globals from debug output 2023-01-30 17:37:23 +08:00
README
sources Release 2.0.26-1 2022-12-22 12:55:14 +08:00
zanata-notes.txt

Adding a patch to kexec-tools
=============================
There is a mailing list kexec@lists.fedoraproject.org where all the dicussion
related to fedora kexec-tools happen. All the patches are posted there for
inclusion and committed to kexec-tools after review.

So if you want your patches to be included in fedora kexec-tools package,
post these to kexec@lists.fedoraproject.org.

One can subscribe to list and browse through archives here.

https://admin.fedoraproject.org/mailman/listinfo/kexec