14ec322b4b
For -q option, as man grep says: Exit immediately with zero status if any match is found, even if an error was detected. So when matching, the read side of pipe is closed by "grep -q", while the write side still try to write more data, which cause SIGPIPE to the process, and the shell can not exit with 0. It depends on the kernel's implementation of pipe to decide how much data written by the producer can trigger the bug. Bash test script: #!/bin/sh set -o pipefail dd if=/dev/zero of=text.file bs=1M count=1 sed -i '1s/^/keyword /' text.file cat text.file | grep -q keyword echo $? Notice the "set -o pipefail" is set by dracut, so mkdumprd -> dracut -> dracut-module-setup.sh -> is_pcs_fence_kdump() trigger the bug. Signed-off-by: Pingfan Liu <piliu@redhat.com> Acked-by: Dave Young <dyoung@redhat.com> Acked-by: Pratyush Anand <panand@redhat.com> |
||
|---|---|---|
| anaconda-addon | ||
| .gitignore | ||
| 98-kexec.rules | ||
| dracut-kdump-capture.service | ||
| dracut-kdump-emergency.service | ||
| dracut-kdump-error-handler.service | ||
| dracut-kdump-error-handler.sh | ||
| dracut-kdump.sh | ||
| dracut-module-setup.sh | ||
| dracut-monitor_dd_progress | ||
| fadump-howto.txt | ||
| kdump-dep-generator.sh | ||
| kdump-in-cluster-environment.txt | ||
| kdump-lib-initramfs.sh | ||
| kdump-lib.sh | ||
| kdump.conf | ||
| kdump.conf.5 | ||
| kdump.service | ||
| kdump.sysconfig | ||
| kdump.sysconfig.i386 | ||
| kdump.sysconfig.ppc64 | ||
| kdump.sysconfig.ppc64le | ||
| kdump.sysconfig.s390x | ||
| kdump.sysconfig.x86_64 | ||
| kdumpctl | ||
| kdumpctl.8 | ||
| kexec-kdump-howto.txt | ||
| kexec-tools-2.0.3-disable-kexec-test.patch | ||
| kexec-tools.spec | ||
| live-image-kdump-howto.txt | ||
| mkdumprd | ||
| mkdumprd.8 | ||
| README | ||
| sources | ||
| zanata-notes.txt | ||
Adding a patch to kexec-tools ============================= There is a mailing list kexec@lists.fedoraproject.org where all the dicussion related to fedora kexec-tools happen. All the patches are posted there for inclusion and committed to kexec-tools after review. So if you want your patches to be included in fedora kexec-tools package, post these to kexec@lists.fedoraproject.org. One can subscribe to list and browse through archives here. https://admin.fedoraproject.org/mailman/listinfo/kexec