From e42a823daec946da013b63460cded5bd0ff53e48 Mon Sep 17 00:00:00 2001 From: Coiby Xu Date: Thu, 1 Jun 2023 16:05:05 +0800 Subject: [PATCH] mkdumprd: Use the correct syntax to redirect the stderr to null A space was added by mistake and unfortunately fips-mode-setup refuses an extra parameter, # fips-mode-setup --is-enabled 2 > /dev/null # echo $? 2 # fips-mode-setup --is-enabled 2 Check, enable, or disable the system FIPS mode. usage: /usr/bin/fips-mode-setup --enable|--disable [--no-bootcfg] usage: /usr/bin/fips-mode-setup --check usage: /usr/bin/fips-mode-setup --is-enabled So in this case mkdumprd can never detect if FIPS is enabled. Fix this mistake. Fixes: 443a43e0 ("mkdumprd: call dracut with --add-device to install the drivers needed by /boot partition automatically for FIPS") Signed-off-by: Coiby Xu Reviewed-by: Tao Liu --- mkdumprd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkdumprd b/mkdumprd index 3932a1f..f93874d 100644 --- a/mkdumprd +++ b/mkdumprd @@ -464,7 +464,7 @@ if ! is_fadump_capable; then add_dracut_arg "--no-hostonly-default-device" - if fips-mode-setup --is-enabled 2 > /dev/null; then + if fips-mode-setup --is-enabled 2> /dev/null; then add_dracut_arg --add-device "$(findmnt -n -o SOURCE --target /boot)" fi fi