47 lines
1.5 KiB
Diff
47 lines
1.5 KiB
Diff
From 5189fa19a4b2b4c3bec37c3a019d446148827717 Mon Sep 17 00:00:00 2001
|
|
From: "H. Peter Anvin" <hpa@zytor.com>
|
|
Date: Fri, 2 Mar 2012 10:43:49 -0800
|
|
Subject: [PATCH 2/2] regset: Return -EFAULT, not -EIO, on host-side memory
|
|
fault
|
|
|
|
There is only one error code to return for a bad user-space buffer
|
|
pointer passed to a system call in the same address space as the
|
|
system call is executed, and that is EFAULT. Furthermore, the
|
|
low-level access routines, which catch most of the faults, return
|
|
EFAULT already.
|
|
|
|
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
|
|
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
|
|
Acked-by: Roland McGrath <roland@hack.frob.com>
|
|
Cc: <stable@vger.kernel.org>
|
|
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
|
|
---
|
|
include/linux/regset.h | 4 ++--
|
|
1 files changed, 2 insertions(+), 2 deletions(-)
|
|
|
|
diff --git a/include/linux/regset.h b/include/linux/regset.h
|
|
index 5150fd1..686f373 100644
|
|
--- a/include/linux/regset.h
|
|
+++ b/include/linux/regset.h
|
|
@@ -339,7 +339,7 @@ static inline int copy_regset_to_user(struct task_struct *target,
|
|
return -EOPNOTSUPP;
|
|
|
|
if (!access_ok(VERIFY_WRITE, data, size))
|
|
- return -EIO;
|
|
+ return -EFAULT;
|
|
|
|
return regset->get(target, regset, offset, size, NULL, data);
|
|
}
|
|
@@ -365,7 +365,7 @@ static inline int copy_regset_from_user(struct task_struct *target,
|
|
return -EOPNOTSUPP;
|
|
|
|
if (!access_ok(VERIFY_READ, data, size))
|
|
- return -EIO;
|
|
+ return -EFAULT;
|
|
|
|
return regset->set(target, regset, offset, size, NULL, data);
|
|
}
|
|
--
|
|
1.7.7.6
|
|
|