88b9de105c
mac80211: do not call rate control .tx_status before .rate_init mwifiex: clear previous security setting during association ath9k: stop on rates with idx -1 in ath9k rate control's .tx_status ath9k_hw: prevent writes to const data on AR9160 rt2x00: fix a possible NULL pointer dereference iwlwifi: fix key removal mac80211: zero initialize count field in ieee80211_tx_rate mac80211: Fix a warning on changing to monitor mode from STA brcm80211: smac: fix endless retry of A-MPDU transmissions brcm80211: smac: only print block-ack timeout message at trace level
40 lines
1.3 KiB
Diff
40 lines
1.3 KiB
Diff
From 2504a6423b9ab4c36df78227055995644de19edb Mon Sep 17 00:00:00 2001
|
|
From: Pavel Roskin <proski@gnu.org>
|
|
Date: Sat, 11 Feb 2012 10:01:53 -0500
|
|
Subject: [PATCH] ath9k: stop on rates with idx -1 in ath9k rate control's
|
|
.tx_status
|
|
|
|
Rate control algorithms are supposed to stop processing when they
|
|
encounter a rate with the index -1. Checking for rate->count not being
|
|
zero is not enough.
|
|
|
|
Allowing a rate with negative index leads to memory corruption in
|
|
ath_debug_stat_rc().
|
|
|
|
One consequence of the bug is discussed at
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=768639
|
|
|
|
Signed-off-by: Pavel Roskin <proski@gnu.org>
|
|
Cc: stable@vger.kernel.org
|
|
Signed-off-by: John W. Linville <linville@tuxdriver.com>
|
|
---
|
|
drivers/net/wireless/ath/ath9k/rc.c | 2 +-
|
|
1 files changed, 1 insertions(+), 1 deletions(-)
|
|
|
|
diff --git a/drivers/net/wireless/ath/ath9k/rc.c b/drivers/net/wireless/ath/ath9k/rc.c
|
|
index 635b592..a427a16 100644
|
|
--- a/drivers/net/wireless/ath/ath9k/rc.c
|
|
+++ b/drivers/net/wireless/ath/ath9k/rc.c
|
|
@@ -1346,7 +1346,7 @@ static void ath_tx_status(void *priv, struct ieee80211_supported_band *sband,
|
|
fc = hdr->frame_control;
|
|
for (i = 0; i < sc->hw->max_rates; i++) {
|
|
struct ieee80211_tx_rate *rate = &tx_info->status.rates[i];
|
|
- if (!rate->count)
|
|
+ if (rate->idx < 0 || !rate->count)
|
|
break;
|
|
|
|
final_ts_idx = i;
|
|
--
|
|
1.7.4.4
|
|
|