36 lines
1.2 KiB
Diff
36 lines
1.2 KiB
Diff
From cced5041ed5a2d1352186510944b0ddfbdbe4c0b Mon Sep 17 00:00:00 2001
|
|
From: Stratos Psomadakis <psomas@gentoo.org>
|
|
Date: Sun, 4 Dec 2011 02:23:54 +0200
|
|
Subject: [PATCH] [SCSI] sym53c8xx: Fix NULL pointer dereference in
|
|
slave_destroy
|
|
|
|
sym53c8xx_slave_destroy unconditionally assumes that sym53c8xx_slave_alloc has
|
|
succesesfully allocated a sym_lcb. This can lead to a NULL pointer dereference
|
|
(exposed by commit 4e6c82b).
|
|
|
|
Signed-off-by: Stratos Psomadakis <psomas@gentoo.org>
|
|
Cc: stable@vger.kernel.org
|
|
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
|
|
---
|
|
drivers/scsi/sym53c8xx_2/sym_glue.c | 4 ++++
|
|
1 files changed, 4 insertions(+), 0 deletions(-)
|
|
|
|
diff --git a/drivers/scsi/sym53c8xx_2/sym_glue.c b/drivers/scsi/sym53c8xx_2/sym_glue.c
|
|
index b4543f5..36d1ed7 100644
|
|
--- a/drivers/scsi/sym53c8xx_2/sym_glue.c
|
|
+++ b/drivers/scsi/sym53c8xx_2/sym_glue.c
|
|
@@ -839,6 +839,10 @@ static void sym53c8xx_slave_destroy(struct scsi_device *sdev)
|
|
struct sym_lcb *lp = sym_lp(tp, sdev->lun);
|
|
unsigned long flags;
|
|
|
|
+ /* if slave_alloc returned before allocating a sym_lcb, return */
|
|
+ if (!lp)
|
|
+ return;
|
|
+
|
|
spin_lock_irqsave(np->s.host->host_lock, flags);
|
|
|
|
if (lp->busy_itlq || lp->busy_itl) {
|
|
--
|
|
1.7.7.5
|
|
|