41 lines
1.2 KiB
Diff
41 lines
1.2 KiB
Diff
From 4a491b1ab11ca0556d2fda1ff1301e862a2d44c4 Mon Sep 17 00:00:00 2001
|
|
From: Jason Yan <yanaijie@huawei.com>
|
|
Date: Thu, 4 Jan 2018 21:04:31 +0800
|
|
Subject: [PATCH] scsi: libsas: fix memory leak in sas_smp_get_phy_events()
|
|
|
|
We've got a memory leak with the following producer:
|
|
|
|
while true;
|
|
do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null;
|
|
done
|
|
|
|
The buffer req is allocated and not freed after we return. Fix it.
|
|
|
|
Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
|
|
Signed-off-by: Jason Yan <yanaijie@huawei.com>
|
|
CC: John Garry <john.garry@huawei.com>
|
|
CC: chenqilin <chenqilin2@huawei.com>
|
|
CC: chenxiang <chenxiang66@hisilicon.com>
|
|
Reviewed-by: Christoph Hellwig <hch@lst.de>
|
|
Reviewed-by: Hannes Reinecke <hare@suse.com>
|
|
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
|
|
---
|
|
drivers/scsi/libsas/sas_expander.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
|
|
index ca1566237ae7..1de59c0fdbc0 100644
|
|
--- a/drivers/scsi/libsas/sas_expander.c
|
|
+++ b/drivers/scsi/libsas/sas_expander.c
|
|
@@ -695,6 +695,7 @@ int sas_smp_get_phy_events(struct sas_phy *phy)
|
|
phy->phy_reset_problem_count = scsi_to_u32(&resp[24]);
|
|
|
|
out:
|
|
+ kfree(req);
|
|
kfree(resp);
|
|
return res;
|
|
|
|
--
|
|
2.14.3
|
|
|