62 lines
1.9 KiB
Diff
62 lines
1.9 KiB
Diff
From fa08d92aa0b550b3db2b569a7a93de117c5b7542 Mon Sep 17 00:00:00 2001
|
|
From: Felipe Balbi <balbi@ti.com>
|
|
Date: Mon, 27 Jan 2014 09:27:46 -0600
|
|
Subject: [PATCH] usb: phy: move some error messages to debug
|
|
|
|
the PHY layer is supposed to be optional,
|
|
considering some PHY have no control bus
|
|
for SW to poke around.
|
|
|
|
After commit 1ae5799 (usb: hcd: Initialize
|
|
USB phy if needed) any HCD which didn't provide
|
|
a PHY driver would emit annoying error messages.
|
|
|
|
In this patch we're decreasing those messages
|
|
to debugging only and we also add a PHY prefix
|
|
or use dev_dbg so we know where they're coming from.
|
|
|
|
Reported-by: Josh Boyer <jwboyer@fedoraproject.org>
|
|
Signed-off-by: Felipe Balbi <balbi@ti.com>
|
|
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
|
|
---
|
|
drivers/usb/phy/phy.c | 8 +++-----
|
|
1 file changed, 3 insertions(+), 5 deletions(-)
|
|
|
|
diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c
|
|
index e6f61e4..8afa813 100644
|
|
--- a/drivers/usb/phy/phy.c
|
|
+++ b/drivers/usb/phy/phy.c
|
|
@@ -130,7 +130,7 @@ struct usb_phy *usb_get_phy(enum usb_phy_type type)
|
|
|
|
phy = __usb_find_phy(&phy_list, type);
|
|
if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) {
|
|
- pr_err("unable to find transceiver of type %s\n",
|
|
+ pr_debug("PHY: unable to find transceiver of type %s\n",
|
|
usb_phy_type_string(type));
|
|
goto err0;
|
|
}
|
|
@@ -228,7 +228,7 @@ struct usb_phy *usb_get_phy_dev(struct device *dev, u8 index)
|
|
|
|
phy = __usb_find_phy_dev(dev, &phy_bind_list, index);
|
|
if (IS_ERR(phy) || !try_module_get(phy->dev->driver->owner)) {
|
|
- pr_err("unable to find transceiver\n");
|
|
+ dev_dbg(dev, "unable to find transceiver\n");
|
|
goto err0;
|
|
}
|
|
|
|
@@ -424,10 +424,8 @@ int usb_bind_phy(const char *dev_name, u8 index,
|
|
unsigned long flags;
|
|
|
|
phy_bind = kzalloc(sizeof(*phy_bind), GFP_KERNEL);
|
|
- if (!phy_bind) {
|
|
- pr_err("phy_bind(): No memory for phy_bind");
|
|
+ if (!phy_bind)
|
|
return -ENOMEM;
|
|
- }
|
|
|
|
phy_bind->dev_name = dev_name;
|
|
phy_bind->phy_dev_name = phy_dev_name;
|
|
--
|
|
1.8.5.3
|
|
|