33 lines
968 B
Diff
33 lines
968 B
Diff
From 9a6aa279d3d17af73a029fa40654e92f4e75e8bb Mon Sep 17 00:00:00 2001
|
|
From: Alexey Kardashevskiy <aik@ozlabs.ru>
|
|
Date: Wed, 5 Jun 2013 08:54:16 -0600
|
|
Subject: [PATCH] vfio: fix crash on rmmod
|
|
|
|
devtmpfs_delete_node() calls devnode() callback with mode==NULL but
|
|
vfio still tries to write there.
|
|
|
|
The patch fixes this.
|
|
|
|
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
|
|
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
|
|
---
|
|
drivers/vfio/vfio.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
|
|
index acb7121..6d78736 100644
|
|
--- a/drivers/vfio/vfio.c
|
|
+++ b/drivers/vfio/vfio.c
|
|
@@ -1360,7 +1360,7 @@ static const struct file_operations vfio_device_fops = {
|
|
*/
|
|
static char *vfio_devnode(struct device *dev, umode_t *mode)
|
|
{
|
|
- if (MINOR(dev->devt) == 0)
|
|
+ if (mode && (MINOR(dev->devt) == 0))
|
|
*mode = S_IRUGO | S_IWUGO;
|
|
|
|
return kasprintf(GFP_KERNEL, "vfio/%s", dev_name(dev));
|
|
--
|
|
1.8.1.4
|
|
|