rpms/kernel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
5,136 Commits 71 Branches 0 Tags 303 MiB
6af9855755
Commit Graph

114 Commits

Author SHA1 Message Date
Peter Robinson
a2e4f52009 some fixups for general fedpkg prep on 4.21 2019-01-03 01:18:51 +00:00
Laura Abbott
c97d3b0f76 Linux v4.20-9163-g195303136f19 2018-12-30 09:30:50 -08:00
Laura Abbott
cd87327143 Forgot to add these files 2018-12-28 13:55:34 -08:00
Laura Abbott
baea90e1b4 Linux v4.20-3117-ga5f2bd479f58 2018-12-26 13:30:36 -08:00
Justin M. Forbes
92ac1e3421 Linux v4.20-rc6-82-g65e08c5e8631 2018-12-13 16:32:46 -06:00
Peter Robinson
4d72568350 drop duplicate REGULATOR_MAX8952 entries (NFC) 2018-12-12 08:36:46 +00:00
Justin M. Forbes
10c4e09883 Linux v4.20-rc5 2018-12-03 12:02:17 -06:00
Peter Robinson
b9bb3eb2c7 minor config cleanups 2018-12-03 07:29:43 +00:00
Peter Jones
fe9e33a887 Re-enable CONFIG_CRYPTO_DEV_SP_PSP so I can work on SEV stuff. 
Waaay back in October, we saw some issues with various system firmware
talking to the AMD SP PSP devices (the secure processor feature), and so
CONFIG_CRYPTO_DEV_SP_PSP got disabled in all of our kernel trees, as
Laura noted here: https://bugzilla.redhat.com/show_bug.cgi?id=1608242#c44 .

I'm trying to use it, and this obviously makes that impossible to do, so
I'm going to re-enable it in rawhide, because the timeout that's being
discussed in that bugzilla thread is already there, and so this firmware
bugs people saw before shouldn't make things completely unusable.

If you *do* see debilitating stalls on AMD EPYC hardware starting after
the next rawhide build, make some noise so we can disable it again.

(I've also posted this to kernel@l.fp.o: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org/thread/22XCMRU4R75M4D5OSXE7YMWYVOBQIU2M/ )

Signed-off-by: Peter Jones <pjones@redhat.com>
 2018-11-30 14:36:02 -05:00
Peter Jones
f8216ee47a Enable CONFIG_AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT 
This makes it so users don't have to do mem_encrypt=1 to enable SEV VMs.

Signed-off-by: Peter Jones <pjones@redhat.com>
 2018-11-30 14:05:53 -05:00
Hans de Goede
0adb640029 Turn on CONFIG_PINCTRL_GEMINILAKE on x86_64 (rhbz#1639155) 2018-11-20 10:54:58 +01:00
Hans de Goede
6c672bed3d Enable a few modules needed for accelerometer and other sensor support 
on some HP X2 2-in-1s
 2018-11-16 14:55:41 +01:00
Paul Bolle
3e4010f25e configs: correct cpu accounting configuration 
The shipped .config files all have CONFIG_TICK_CPU_ACCOUNTING and
CONFIG_VIRT_CPU_ACCOUNTING_NATIVE set. The x86_64 .config files
additionaly have CONFIG_VIRT_CPU_ACCOUNTING_GEN set.

This is wrong because each .config should have just one of these three
set. As a result the build generates
    [...]⚠️ override: VIRT_CPU_ACCOUNTING_NATIVE changes choice state

24 times and
    [...]⚠️ override: VIRT_CPU_ACCOUNTING_GEN changes choice state

4 times. So let's make sure the shipped .config files only have one of
these three Kconfig macros set (ie, the one that's relevant for that
.config target).

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
 2018-11-15 13:44:46 -08:00
Paul Bolle
ae8e3e89c1 configs: use CONFIG_UNWINDER_ORC only in x86/x86_64 
The shipped .config files for i686 have both CONFIG_UNWINDER_ORC and
CONFIG_UNWINDER_FRAME_POINTER set. This is wrong because those .config
files should only have CONFIG_UNWINDER_FRAME_POINTER set. As a result
the build generates
    [...]⚠️ override: UNWINDER_ORC changes choice state

4 times.

Move CONFIG_UNWINDER_ORC to x86/x86_64 to correct this. Note that this
doesn't change the final .config files that the kernel's build system
actually uses.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
 2018-11-15 13:44:46 -08:00
Peter Robinson
71860be326 - Further updates for ARM 
- More Qualcomm SD845 enablement
- FPGA Device Feature List (DFL) support
- Minor cleanups
 2018-11-13 03:06:17 +00:00
Paul Bolle
da848d916b Remove all references to unknown Kconfig symbols 
There are 244 Kconfig symbols referenced in the files used for
configuration generation and in the shipped .config files that are
unknown in v4.20-rc1. Neither are these symbols added in the patches
that Fedora applies. The references to these symbols can be safely
removed.

These symbols are:
    CONFIG_8723AU_AP_MODE
    CONFIG_8723AU_BT_COEXIST
    CONFIG_ACPI_NFIT_DEBUG
    CONFIG_ACPI_PROCFS
    CONFIG_ADE7753
    CONFIG_ADE7754
    CONFIG_ADE7758
    CONFIG_ADE7759
    CONFIG_ADIS16060
    CONFIG_ALTERNATIVES
    CONFIG_ARM64_PTDUMP
    CONFIG_ARM_ASM_UNIFIED
    CONFIG_ARM_PTDUMP
    CONFIG_ATH9K_DEBUG
    CONFIG_AVERAGE
    CONFIG_AXON_RAM
    CONFIG_BACKLIGHT_LM3630
    CONFIG_BLK_DEV_NVME_SCSI
    CONFIG_BLK_DEV_OSD
    CONFIG_BLK_DEV_RAM_DAX
    CONFIG_BOOTPARAM_LOCKDEP_CROSSRELEASE_FULLSTACK
    CONFIG_BT_HCIBTUART
    CONFIG_BUILD_DOCSRC
    CONFIG_BUILD_ID_SALT
    CONFIG_CC_STACKPROTECTOR_AUTO
    CONFIG_CC_STACKPROTECTOR_NONE
    CONFIG_CC_STACKPROTECTOR_REGULAR
    CONFIG_CIFS_SMB2
    CONFIG_CIFS_SMB311
    CONFIG_CIFS_STATS
    CONFIG_CPU_FREQ_STAT_DETAILS
    CONFIG_CPU_NOTIFIER_ERROR_INJECT
    CONFIG_CROS_EC_CHARDEV
    CONFIG_CROSS_COMPILE
    CONFIG_CRYPTO_CRC32_ARM64
    CONFIG_CRYPTO_CRC32_ARM64_CE
    CONFIG_CRYPTO_MCRYPTD
    CONFIG_CRYPTO_SALSA20_586
    CONFIG_CRYPTO_SALSA20_X86_64
    CONFIG_CRYPTO_SHA1_MB
    CONFIG_CRYPTO_SHA256_MB
    CONFIG_CRYPTO_SHA512_MB
    CONFIG_CRYPTO_SKEIN
    CONFIG_CTC
    CONFIG_DEBUG_NX_TEST
    CONFIG_DEBUG_REFCOUNT
    CONFIG_DEBUG_SET_MODULE_RONX
    CONFIG_DGAP
    CONFIG_DGNC
    CONFIG_DIRECT_GBPAGES
    CONFIG_DISABLE_MPROFILE_KERNEL
    CONFIG_DM_CACHE_CLEANER
    CONFIG_DM_MQ_DEFAULT
    CONFIG_DRM_AMD_DC_FBC
    CONFIG_DRM_AMD_DC_PRE_VEGA
    CONFIG_DRM_AMD_POWERPLAY
    CONFIG_DRM_DEBUG_MM_SELFTEST
    CONFIG_DRM_ETNAVIV_REGISTER_LOGGING
    CONFIG_DRM_IMX_IPUV3
    CONFIG_DRM_OMAP_NUM_CRTCS
    CONFIG_DRM_TILCDC_SLAVE_COMPAT
    CONFIG_DT3155
    CONFIG_DVB_USB_FRIIO
    CONFIG_DW_DMAC_BIG_ENDIAN_IO
    CONFIG_EFI_ALLOW_SECURE_BOOT_EXIT
    CONFIG_EFI_SECURE_BOOT_LOCK_DOWN
    CONFIG_EFI_SECURE_BOOT_SIG_ENFORCE
    CONFIG_ENABLE_WARN_DEPRECATED
    CONFIG_FB_AUO_K190X
    CONFIG_FUJITSU_LAPTOP_DEBUG
    CONFIG_GPIO_AXP209
    CONFIG_GPIO_DEVRES
    CONFIG_GPIO_MCP23S08
    CONFIG_GPIO_SX150X
    CONFIG_HFI1_VERBS_31BIT_PSN
    CONFIG_HFSPLUS_FS_POSIX_ACL
    CONFIG_HOTPLUG
    CONFIG_HT_IRQ
    CONFIG_I2C_DESIGNWARE
    CONFIG_I2O
    CONFIG_I40E_FCOE
    CONFIG_I7300_IDLE
    CONFIG_IDMA64
    CONFIG_INFINIBAND_CXGB3_DEBUG
    CONFIG_INFINIBAND_EXP_USER_ACCESS
    CONFIG_INPUT_GPIO
    CONFIG_INPUT_GPIO_TILT_POLLED
    CONFIG_INTEL_RDT_A
    CONFIG_IOMMU_STRESS
    CONFIG_IP1000
    CONFIG_IP_DCCP_CCID2
    CONFIG_IPL
    CONFIG_IPV6_SEG6_INLINE
    CONFIG_IRDA
    CONFIG_IR_LIRC_CODEC
    CONFIG_IRQ_DOMAIN_DEBUG
    CONFIG_IWM
    CONFIG_KEXEC_SIG
    CONFIG_KEXEC_SIG_FORCE
    CONFIG_KVM_DEVICE_ASSIGNMENT
    CONFIG_LGUEST
    CONFIG_LGUEST_GUEST
    CONFIG_LIRC_BT829
    CONFIG_LIRC_IMON
    CONFIG_LIRC_PARALLEL
    CONFIG_LIRC_SERIAL
    CONFIG_LIRC_SERIAL_TRANSMITTER
    CONFIG_LIRC_STAGING
    CONFIG_LIRC_ZILOG
    CONFIG_LNET
    CONFIG_LOGFS
    CONFIG_LPFC_NVME_INITIATOR
    CONFIG_LPFC_NVME_TARGET
    CONFIG_MACH_MESON8B
    CONFIG_MCE_AMD_INJ
    CONFIG_MEDIA_CEC_DEBUG
    CONFIG_MEDIA_RC_SUPPORT
    CONFIG_MFD_CROS_EC_I2C
    CONFIG_MFD_CROS_EC_SPI
    CONFIG_MG_DISK
    CONFIG_MLX_CPLD_PLATFORM
    CONFIG_MOVABLE_NODE
    CONFIG_MTD_NAND_DOCG4
    CONFIG_MTD_NAND_PXA3xx
    CONFIG_MVEBU_CLK_CORE
    CONFIG_NET_CADENCE
    CONFIG_NET_CLS_ROUTE
    CONFIG_NET_DCCPPROBE
    CONFIG_NET_DSA_HWMON
    CONFIG_NETFILTER_DEBUG
    CONFIG_NET_PACKET_ENGINE
    CONFIG_NET_SCTPPROBE
    CONFIG_NET_TCPPROBE
    CONFIG_NET_VENDOR_EXAR
    CONFIG_NET_VENDOR_SNI
    CONFIG_NF_CONNTRACK_IPV4
    CONFIG_NF_CONNTRACK_IPV6
    CONFIG_NF_CONNTRACK_PROC_COMPAT
    CONFIG_NFC_WILINK
    CONFIG_NFP_NET_DEBUG
    CONFIG_NFP_NETVF
    CONFIG_NFT_BRIDGE_META
    CONFIG_NFT_EXTHDR
    CONFIG_NFT_META
    CONFIG_NFT_RBTREE
    CONFIG_NFT_RT
    CONFIG_NFT_SET_BITMAP
    CONFIG_NFT_SET_HASH
    CONFIG_NFT_SET_RBTREE
    CONFIG_NL80211
    CONFIG_NMI_LOG_BUF_SHIFT
    CONFIG_NO_BOOTMEM
    CONFIG_NO_HZ_FULL_ALL
    CONFIG_NO_HZ_FULL_SYSIDLE
    CONFIG_NR_DEV_DAX
    CONFIG_OLPC_XO1
    CONFIG_OMAP2_DSS_RFBI
    CONFIG_OMAP_PM_NOOP
    CONFIG_PHONE
    CONFIG_PHY_MIPHY365X
    CONFIG_PHY_STIH41X_USB
    CONFIG_PNFS_OBJLAYOUT
    CONFIG_PPC_CPUFEATURES_ENABLE_UNKNOWN
    CONFIG_PPC_ICSWX
    CONFIG_PPC_ICSWX_PID
    CONFIG_PPC_ICSWX_USE_SIGILL
    CONFIG_PROVE_RCU_REPEATEDLY
    CONFIG_QETH_IPV6
    CONFIG_R8723AU
    CONFIG_RCU_KTHREAD_PRIO
    CONFIG_RCU_NOCB_CPU_ALL
    CONFIG_RCU_TORTURE_TEST_SLOW_CLEANUP
    CONFIG_RCU_TORTURE_TEST_SLOW_INIT
    CONFIG_RCU_TORTURE_TEST_SLOW_INIT_DELAY
    CONFIG_RCU_TORTURE_TEST_SLOW_PREINIT
    CONFIG_RESET_GPIO
    CONFIG_RESET_HSDK_V1
    CONFIG_RIO
    CONFIG_RTC_DRV_DS1307_HWMON
    CONFIG_RTC_DRV_ISL12057
    CONFIG_RTC_DS1685_PROC_REGS
    CONFIG_RTC_DS1685_SYSFS_REGS
    CONFIG_S390_GUEST_OLD_TRANSPORT
    CONFIG_SAMSUNG_USBPHY
    CONFIG_SCM_BLOCK_CLUSTER_WRITE
    CONFIG_SCSI_EATA
    CONFIG_SCSI_EATA_PIO
    CONFIG_SCSI_FUTURE_DOMAIN
    CONFIG_SCSI_IN2000
    CONFIG_SCSI_SRP
    CONFIG_SECURITY_SELINUX_POLICYDB_VERSION_MAX
    CONFIG_SENSORS_TWL4030_MADC
    CONFIG_SHARED_KERNEL
    CONFIG_SIGMA
    CONFIG_SILEAD_DMI
    CONFIG_SND_HDA_POWER_SAVE
    CONFIG_SND_SOC_DIO2125
    CONFIG_SOC_EXYNOS4212
    CONFIG_SOC_EXYNOS4415
    CONFIG_SOC_EXYNOS5440
    CONFIG_SOLO6X10
    CONFIG_SPARSE_RCU_POINTER
    CONFIG_SSB_DEBUG
    CONFIG_SSB_SILENT
    CONFIG_STE_MODEM_RPROC
    CONFIG_STRIP
    CONFIG_SYNOPSYS_DWC_ETH_QOS
    CONFIG_TEST_FIND_BIT
    CONFIG_TI_DAC7512
    CONFIG_TOUCHSCREEN_FT6236
    CONFIG_TOUCHSCREEN_INTEL_MID
    CONFIG_TR
    CONFIG_TRACE_ENUM_MAP_FILE
    CONFIG_TSL2x7x
    CONFIG_UCSI
    CONFIG_UIO_PDRV
    CONFIG_USB_ATMEL
    CONFIG_USB_CHIPIDEA_ULPI
    CONFIG_USB_DEBUG
    CONFIG_USB_EZUSB
    CONFIG_USB_GADGET_LEGACY
    CONFIG_USB_SERIAL_KEYSPAN_MPR
    CONFIG_USB_SERIAL_KEYSPAN_USA18X
    CONFIG_USB_SERIAL_KEYSPAN_USA19
    CONFIG_USB_SERIAL_KEYSPAN_USA19QI
    CONFIG_USB_SERIAL_KEYSPAN_USA19QW
    CONFIG_USB_SERIAL_KEYSPAN_USA19W
    CONFIG_USB_SERIAL_KEYSPAN_USA28
    CONFIG_USB_SERIAL_KEYSPAN_USA28X
    CONFIG_USB_SERIAL_KEYSPAN_USA28XA
    CONFIG_USB_SERIAL_KEYSPAN_USA28XB
    CONFIG_USB_SERIAL_KEYSPAN_USA49W
    CONFIG_USB_SERIAL_KEYSPAN_USA49WLC
    CONFIG_USE_THIN_ARCHIVES
    CONFIG_VIDEO_CPIA
    CONFIG_VIDEO_SAMSUNG_S5P_TV
    CONFIG_VIDEO_SH_MOBILE_CSI2
    CONFIG_VIDEO_STK1160_AC97
    CONFIG_VIDEO_TW686X_KH
    CONFIG_VIDEO_VIVI
    CONFIG_W1_SLAVE_BQ27000
    CONFIG_W1_SLAVE_DS2760
    CONFIG_XEN_DEBUG
    CONFIG_XEN_SCRUB_PAGES

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
 2018-11-08 10:44:32 -06:00
Justin M. Forbes
0979d54b30 Clean up i686PAE configs as they are no longer in use 2018-11-08 10:37:14 -06:00
Paul Bolle
75a56a83ac Fix typos in five filenames 
Five files that are used in the configuration generation have typos in
their names. Those typos have no effect on the build, but should still
be fixed since they could be confusing (to people and scripts).

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
 2018-11-07 16:27:39 -06:00
Justin M. Forbes
8874744008 Add config files 2018-11-02 12:08:23 -05:00
Justin M. Forbes
4eb72d37dc Linux v4.19-9448-g673c790e7282 2018-10-29 13:54:19 -05:00
Justin M. Forbes
0f348d0bc2 Linux v4.19-5646-g3acbd2de6bc3 2018-10-25 12:49:20 -05:00
Justin M. Forbes
bc5d8157d1 Linux v4.19-4345-g638820d8da8e 2018-10-24 13:39:38 -05:00
Jeremy Cline
d39a8c5da3
Linux v4.19-rc8-95-g91b15613ce7f 
Also enable pinctrl-cannonlake (rhbz 1641057)
 2018-10-19 10:09:23 -04:00
Laura Abbott
675bf4ccbb Disable CONFIG_CRYPTO_DEV_SP_PSP (rhbz 1608242) 2018-10-01 12:45:09 -07:00
Peter Robinson
28c16a6fad drop duplicate config (NFC) 2018-09-21 00:57:25 +01:00
Jeremy Cline
a54055adb1
Linux v4.19-rc4 2018-09-17 11:00:09 -04:00
Peter Robinson
be2111b4e4 a few minor ARM config tweaks 2018-09-16 17:46:54 +01:00
Peter Robinson
1c4d7f9336 initial ARM config updates for 4.19 2018-09-04 11:10:48 +01:00
Jeremy Cline
9b4f0fa712
Linux v4.18-11682-g815f0ddb346c 2018-08-23 10:08:57 -04:00
Jeremy Cline
f17554469f
Linux v4.18-11219-gad1d69735878 2018-08-22 10:08:14 -04:00
Jeremy Cline
390cb4d0f8
Linux v4.18-10986-g778a33959a8a 2018-08-21 11:36:51 -04:00
Jeremy Cline
2cc93cea51
Bring back AEGIS and MORUS ciphers (rhbz 1610180) 2018-08-16 17:22:54 +01:00
Jeremy Cline
a23ced99bd
Linux v4.18-7873-gf91e654474d4 2018-08-16 14:56:49 +01:00
Laura Abbott
c0a58bf015 Linux v4.18-2978-g1eb46908b35d 2018-08-15 10:58:06 -07:00
Jeremy Cline
6003595fcc
Linux v4.18-1283-g10f3e23f07cb 2018-08-14 13:00:57 +01:00
Justin M. Forbes
b11fbf04e7 Back out AEGIS and MORUS ciphers (rhbz 1610180) 2018-08-01 16:35:31 -05:00
Hans de Goede
2964bf6887 Enable Apollo Lake Whiskey Cove PMIC support 2018-08-01 17:23:19 +02:00
Jeremy Cline
a1853172d8
Enable AEGIS and MORUS ciphers (rhbz 1610180) 2018-08-01 10:31:02 -04:00
Hans de Goede
838818e5a9 Add patch queued in -next to make quiet more quiet 
Add patches queued in -next to make efifb / fbcon retain the vendor logo
  (ACPI BRGT boot graphics) until the first text is output to the console
 2018-07-30 16:46:56 +02:00
Dan Horák
ae8c56c0d4 VFIO_PCI_IGD needs explicit enable now 2018-07-12 16:09:09 +02:00
Peter Robinson
c36cd75159 ARM updates for 4.18, cleanup some dropped config options 2018-06-15 12:57:54 +01:00
Laura Abbott
ee004bf48f Linux v4.17-11928-g2837461dbe6f 2018-06-14 10:04:58 -07:00
Laura Abbott
4b8512e91a Linux v4.17-7997-g68abbe729567 2018-06-08 11:37:45 -07:00
Hans de Goede
ae3a573424 Enable GPIO_AMDPT, PINCTRL_AMD and X86_AMD_PLATFORM_DEVICE Kconfig options 
This fixes i2c and GPIOs not working on AMD based laptops (rhbz#1510649).
 2018-05-20 15:43:29 +02:00
Justin M. Forbes
dec69994ee Config updates for upstream kconfig patch 17baab68d337a0bf4654091e2b4cd67c3fdb44d8 2018-05-15 10:39:52 -05:00
Justin M. Forbes
68f9cff457 Linux v4.17-rc3 2018-04-30 10:58:41 -05:00
Peter Robinson
b9b2a331d5 Enable UFS storage options on ARM, just enable on ARM/x86 as it's only likely to be on those platgforms at this point 2018-04-19 17:00:25 +01:00
Peter Robinson
2753dad8da Enable drivers for Xilinx ZYMQ-MP Ultra96 2018-04-18 00:16:05 +01:00
Justin M. Forbes
8cf006311d Linux v4.17-rc1 2018-04-16 11:04:31 -05:00
Peter Robinson
40766321c4 Disable tps65217-charger, fix for the BeagleBone boot failure, Further fix for ThunderX ZIP driver, fix olpc i686 config 2018-04-12 18:11:57 +01:00
Laura Abbott
6cb6bcb528 Enable a few infiniband options (rhbz 1291902) 2018-04-11 10:59:42 -07:00
Justin M. Forbes
5bf5e37a74 Linux v4.16-9576-g38c23685b273 2018-04-06 12:00:21 -05:00
Justin M. Forbes
bb64576091 Linux v4.16-7248-g06dd3dfeea60 2018-04-05 12:30:09 -05:00
Peter Robinson
0e8aa23324 drop removed X86_PPRO_FENCE config option 2018-03-27 03:19:08 +01:00
Jeremy Cline
06a455a312
Linux v4.16-rc5 2018-03-12 10:49:13 -04:00
Justin M. Forbes
f20e0a3b66 Update efi-lockdown patch with current. 2018-03-12 08:46:00 -05:00
Laura Abbott
356f92a381 Don't build in CONFIG_X86_PMEM_LEGACY (rhbz 1460398) 2018-02-28 09:34:54 -08:00
Justin M. Forbes
0b116e4726 Add configs 2018-02-12 07:32:33 -06:00
Justin M. Forbes
bf681f6a5b Linux v4.15-11704-ga2e5790d8416 2018-02-07 09:13:24 -06:00
Hans de Goede
8d6edefe57 Set CONFIG_VBOXGUEST=m 2018-02-07 12:06:32 +01:00
Justin M. Forbes
a84c4d8276 Linux v4.15-9939-g4bf772b14675 2018-02-02 14:38:32 -06:00
Justin M. Forbes
98c76e090f Linux v4.15-1549-g6304672b7f0a 2018-01-30 12:26:27 -06:00
Justin M. Forbes
78b277bd72 Initial retpoline patches for Spectre v2 2018-01-11 10:28:58 -06:00
Don Zickus
4d6d8cc5c1 configs: Move base-debug and base-generic to configs/fedora 
It was suggested that base-debug and base-generic were not good names
to use.  Further discussion led to using configs/fedora for the base
config files and configs/rhel for any overrides.

This patch does a plain

mkdir configs/fedora
git mv configs/base-{generic,debug} configs/fedora

No code changes.
 2018-01-05 14:40:14 -08:00