Fix a few vc4 crashes on the Raspberry Pi using 4.14 fixes, drop a patch already applied that git would still apply

This commit is contained in:
Peter Robinson 2017-09-19 15:46:17 +01:00
parent 5bce212ddd
commit 886e8bd8e1
3 changed files with 1809 additions and 46 deletions

View File

@ -1,42 +0,0 @@
From patchwork Thu Feb 9 18:16:00 2017
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: drm/vc4: Fix OOPSes from trying to cache a partially constructed BO.
From: Eric Anholt <eric@anholt.net>
X-Patchwork-Id: 138087
Message-Id: <20170209181600.24048-1-eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org, pbrobinson@gmail.com
Date: Thu, 9 Feb 2017 10:16:00 -0800
If a CMA allocation failed, the partially constructed BO would be
unreferenced through the normal path, and we might choose to put it in
the BO cache. If we then reused it before it expired from the cache,
the kernel would OOPS.
Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.")
---
drivers/gpu/drm/vc4/vc4_bo.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 5ec14f25625d..fd83a2807656 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -314,6 +314,14 @@ void vc4_free_object(struct drm_gem_object *gem_bo)
goto out;
}
+ /* If this object was partially constructed but CMA allocation
+ * had failed, just free it.
+ */
+ if (!bo->base.vaddr) {
+ vc4_bo_destroy(bo);
+ goto out;
+ }
+
cache_list = vc4_get_cache_list_for_size(dev, gem_bo->size);
if (!cache_list) {
vc4_bo_destroy(bo);

1803
bcm283x-vc4-fixes.patch Normal file

File diff suppressed because it is too large Load Diff

View File

@ -615,9 +615,6 @@ Patch313: qcom-Force-host-mode-for-USB-on-apq8016-sbc.patch
# https://patchwork.kernel.org/patch/9850189/
Patch314: qcom-msm-ci_hdrc_msm_probe-missing-of_node_get.patch
# http://www.spinics.net/lists/dri-devel/msg132235.html
Patch320: bcm283x-vc4-Fix-OOPSes-from-trying-to-cache-a-partially-constructed-BO..patch
# Fix USB on the RPi https://patchwork.kernel.org/patch/9879371/
Patch321: bcm283x-dma-mapping-skip-USB-devices-when-configuring-DMA-during-probe.patch
@ -628,8 +625,10 @@ Patch322: bcm2837-move-dt.patch
#
Patch323: bcm2837-bluetooth-support.patch
Patch324: bcm283x-vc4-fixes.patch
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20170912&id=723288836628bc1c0855f3bb7b64b1803e4b9e4a
Patch324: arm-of-restrict-dma-configuration.patch
Patch330: arm-of-restrict-dma-configuration.patch
# 400 - IBM (ppc/s390x) patches
@ -2223,6 +2222,9 @@ fi
#
#
%changelog
* Tue Sep 19 2017 Peter Robinson <pbrobinson@fedoraproject.org>
- Fix a few vc4 crashes on the Raspberry Pi
* Mon Sep 18 2017 Justin M. Forbes <jforbes@edoraproject.org>
- Fixes for QXL (rhbz 1462381)
- Fix rhbz 1431375