fix a deadlock in scsi_dh_hp_sw
This commit is contained in:
parent
8d4bec9c02
commit
3c5f6df32d
|
@ -747,6 +747,8 @@ Patch12405: iwlwifi-add-_ack_plpc_check-module-parameters.patch
|
|||
# intel_ips driver bug (#703511) causes cooling fan to run
|
||||
Patch12406: ips-use-interruptible-waits-in-ips-monitor.patch
|
||||
|
||||
Patch12407: scsi_dh_hp_sw-fix-deadlock-in-start_stop_endio.patch
|
||||
|
||||
%endif
|
||||
|
||||
BuildRoot: %{_tmppath}/kernel-%{KVERREL}-root
|
||||
|
@ -1387,6 +1389,8 @@ ApplyPatch iwlwifi-add-_ack_plpc_check-module-parameters.patch
|
|||
# intel_ips driver bug (#703511) causes cooling fan to run
|
||||
ApplyPatch ips-use-interruptible-waits-in-ips-monitor.patch
|
||||
|
||||
ApplyPatch scsi_dh_hp_sw-fix-deadlock-in-start_stop_endio.patch
|
||||
|
||||
# END OF PATCH APPLICATIONS
|
||||
|
||||
%endif
|
||||
|
@ -1995,6 +1999,10 @@ fi
|
|||
# and build.
|
||||
|
||||
%changelog
|
||||
* Fri May 13 2011 Kyle McMartin <kmcmartin@redhat.com>
|
||||
- [fabbione@] Fix a deadlock when using hp_sw with an HP san.
|
||||
(7a1e9d82 upstream)
|
||||
|
||||
* Wed May 11 2011 Chuck Ebbert <cebbert@redhat.com>
|
||||
- Fix Intel IPS driver so it doesn't run continuously (#703511)
|
||||
|
||||
|
|
|
@ -0,0 +1,32 @@
|
|||
From 7a1e9d829f8bd821466c5ea834ad6f378740d2be Mon Sep 17 00:00:00 2001
|
||||
From: Mike Snitzer <snitzer@redhat.com>
|
||||
Date: Tue, 25 Jan 2011 11:52:17 -0500
|
||||
Subject: [SCSI] scsi_dh_hp_sw: fix deadlock in start_stop_endio
|
||||
|
||||
The use of blk_execute_rq_nowait() implies __blk_put_request() is needed
|
||||
in start_stop_endio() rather than blk_put_request() --
|
||||
blk_finish_request() is called with queue lock already held.
|
||||
|
||||
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
|
||||
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
|
||||
---
|
||||
drivers/scsi/device_handler/scsi_dh_hp_sw.c | 3 ++-
|
||||
1 files changed, 2 insertions(+), 1 deletions(-)
|
||||
|
||||
diff --git a/drivers/scsi/device_handler/scsi_dh_hp_sw.c b/drivers/scsi/device_handler/scsi_dh_hp_sw.c
|
||||
index e391664..d0363c8 100644
|
||||
--- a/drivers/scsi/device_handler/scsi_dh_hp_sw.c
|
||||
+++ b/drivers/scsi/device_handler/scsi_dh_hp_sw.c
|
||||
@@ -225,7 +225,8 @@ static void start_stop_endio(struct request *req, int error)
|
||||
}
|
||||
}
|
||||
done:
|
||||
- blk_put_request(req);
|
||||
+ req->end_io_data = NULL;
|
||||
+ __blk_put_request(req->q, req);
|
||||
if (h->callback_fn) {
|
||||
h->callback_fn(h->callback_data, err);
|
||||
h->callback_fn = h->callback_data = NULL;
|
||||
--
|
||||
1.7.5.1
|
||||
|
Loading…
Reference in New Issue